UAS: Use kzalloc instead of kmalloc
Quoted 13 lines · Luben Tuikov
--- On Mon, 11/8/10, Matthew Wilcox <willy-VuQAYsv1563Yd54FQh9/[email protected]>
Quoted 3 lines · wrote:
Quoted 1 line · Luben Tuikov
"Be conservative in what you send, liberal in
what
Quoted 1 line
Quoted 1 line
you accept." -- In the spirit of this adage,
don't
Quoted 4 lines
Quoted 3 lines
send Command IUs with randomly filled in data in
the reserved fields. (Yes, this shows up on the
wire.)
Quoted 7 lines
Quoted 1 line
Applied, with a better changelog entry ...
"Better"? Where did you apply it? Your willy/uas.git doesn't show it (updated 3 months ago), neither do Greg's.
BTW, is it customary to change the change log? What did you change? Do you mind sharing?
Matthew, could you reply-all here with your new, changed and modified change log?
I'd like you to be accountable to what and how you've changed the changelog HERE and not in a git three somewhere and have an open comparison to what your new change log is and what is says.
Mine, quoted above:
a) mentions an adage that's been around for 30 years at least, in the UNIX/net field to which we adhere.
b) mentions (only!) the Command IU of making out on the wire with stale system data of the memory used for it.
Could you please reconsider your professional integrity and submit the patch as is with the original log?
Quoted 12 lines
Quoted 12 lines
Review static int uas_probe(struct
Quoted 1 line
(quoted diff) +0
-0@@ -660,7 +660,7 @@ static int uas_probe(struct
usb_interface*intf, const structusb_device_id*id)Quoted 1 line
return
-ENODEV;Quoted 3 lines
}
- devinfo = kmalloc(sizeof(struct
uas_dev_info),GFP_KERNEL);Quoted 1 line
+ devinfo = kzalloc(sizeof(struct
uas_dev_info),GFP_KERNEL);Quoted 2 lines
if (!devinfo)
return
Quoted 8 lines
Quoted 4 lines
-ENOMEM;Quoted 1 line
Except for this hunk, which isn't an IU and doesn't go
out
Quoted 1 line
on the wire.
Lol, no of course it doesn't, silly!
And notice that /my/ change log doesn't claim that uas_dev_info makes it out the wire. It only mentions that the Command IU makes it out the wire with stale data.
Quoted 10 lines
So help us understand: You've preserved all changes from
kmalloc->kzallocand left a single kmalloc alone. And your reason is that "*This* one doesn't go out on the wire?"Wouldn't if have been more consistent (and harmless) to have changed all of them, just as the patch did?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html