Skip to contentSkip to conversation

[004] dmfe : Add suspend/resume support

PATCH In review Levitsky Maxim 3 participants 3 messages Feb 7, 2007 – Feb 11, 2007

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 [004] dmfe : Add suspend/resume support

From: Maxim Levitsky <[email protected]>
Subject: [PATCH] [NETDEV] [004] dmfe : Add suspend/resume support

Adds support for suspend/resume

---

drivers/net/tulip/dmfe.c  2007-02-07 18:50:52.000000000 +0200 renamed from drivers/net/tulip/dmfe.c   2007-02-07 18:46:13.000000000 +0200 +0 -0
@@ -55,9 +55,6 @@


     TODO

-    Implement pci_driver::suspend() and pci_driver::resume()
-    power management methods.
-
     Check on 64 bit boxes.
     Check and fix on big endian boxes.

@@ -2027,11 +2024,59 @@ static struct pci_device_id dmfe_pci_tbl MODULE_DEVICE_TABLE(pci, dmfe_pci_tbl);


+
+static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state) +{
+    u32 tmp;
+
+    struct net_device *dev = pci_get_drvdata(pci_dev);
+    struct dmfe_board_info *db = netdev_priv(dev);
+
+    /* Disable upper layer interface */
+    netif_device_detach(dev);
+
+    /* Disable Tx/Rx */
+    db->cr6_data &= ~(CR6_RXSC | CR6_TXSC);
+    update_cr6(db->cr6_data, dev->base_addr);
+
+    /* Disable Interrupt */
+    outl(0, dev->base_addr + DCR7);
+    outl(inl(dev->base_addr + DCR5), dev->base_addr + DCR5); +
+    /* Fre RX buffers */
+    dmfe_free_rxbuffer(db);
+
+    /* Power down device*/
+    pci_set_power_state(pci_dev ,  pci_choose_state(pci_dev,state));
+    pci_save_state(pci_dev);
+
+    return 0;
+}
+
+static int dmfe_resume(struct pci_dev *pci_dev)
+{
+    struct net_device *dev = pci_get_drvdata(pci_dev);
+    u32 tmp;
+
+    pci_restore_state(pci_dev);
+    pci_set_power_state(pci_dev ,PCI_D0);
+
+    /* Re-initilize DM910X board */
+    dmfe_init_dm910x(dev);
+
+    /* Restart upper layer interface */
+    netif_device_attach(dev);
+
+    return 0;
+}
+
 static struct pci_driver dmfe_driver = {
        .name           = "dmfe",
        .id_table       = dmfe_pci_tbl,
        .probe          = dmfe_init_one,
        .remove         = __devexit_p(dmfe_remove_one),
+        .suspend        = dmfe_suspend,
+        .resume         = dmfe_resume
 };

 MODULE_AUTHOR("Sten Wang, [email protected]");

____________________________________________________________________________________
Do you Yahoo!?
Everyone is raving about the all-new Yahoo! Mail beta.
http://new.mail.yahoo.com

#1 lore raw

Hi!

Quoted 4 lines

From: Maxim Levitsky <[email protected]>
Subject: [PATCH] [NETDEV] [004] dmfe : Add suspend/resume support

Adds support for suspend/resume

Patch looks ok, but your mailer damaged it heavily.

Quoted 16 lines
drivers/net/tulip/dmfe.c  2007-02-07 18:50:52.000000000 +0200 renamed from drivers/net/tulip/dmfe.c   2007-02-07 18:46:13.000000000 +0200 +0 -0
@@ -55,9 +55,6 @@


     TODO

-    Implement pci_driver::suspend() and pci_driver::resume()
-    power management methods.
-
     Check on 64 bit boxes.
     Check and fix on big endian boxes.

drivers/net/tulip/dmfe.c  2007-02-07 18:50:52.000000000 +0200 renamed from drivers/net/tulip/dmfe.c   2007-02-07 18:46:13.000000000 +0200 +0 -0
@@ -2027,11 +2024,59 @@ static struct pci_device_id dmfe_pci_tbl
  MODULE_DEVICE_TABLE(pci, dmfe_pci_tbl);


drivers/net/tulip/dmfe.c  2007-02-07 18:50:52.000000000 +0200

Quoted 3 lines
drivers/net/tulip/dmfe.c  2007-02-07 18:50:52.000000000 +0200 renamed from drivers/net/tulip/dmfe.c   2007-02-07 18:46:13.000000000 +0200 +3 -0
+
+static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state)
+{

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw
Quoted 23 lines · On Friday 09 February 2007 22:54:52 Pavel Machek wrote:

Hi!

Quoted 4 lines

From: Maxim Levitsky <[email protected]>
Subject: [PATCH] [NETDEV] [004] dmfe : Add suspend/resume support

Adds support for suspend/resume

Patch looks ok, but your mailer damaged it heavily.

Quoted 14 lines

--- linux-2.6.20-mod/drivers/net/tulip/dmfe.c   2007-02-07 18:46:13.000000000 +0200 +++ linux-2.6.20-test/drivers/net/tulip/dmfe.c  2007-02-07 18:50:52.000000000 +0200 @@ -55,9 +55,6 @@

     TODO

-    Implement pci_driver::suspend() and pci_driver::resume()
-    power management methods.
-
     Check on 64 bit boxes.
     Check and fix on big endian boxes.

(quoted diff) +0 -0
@@ -2027,11 +2024,59 @@ static struct pci_device_id dmfe_pci_tbl
Quoted 8 lines

Review

Quoted 6 lines
(quoted diff) +0 -0
  MODULE_DEVICE_TABLE(pci, dmfe_pci_tbl);


(quoted diff) +3 -0
+
+static int dmfe_suspend(struct pci_dev *pci_dev, pm_message_t state)
+{

Pavel

Hi , thanks for reply , I will send them again, and this time I will check that mailer doesn't mess with patches.

I fixed word wrap problem.

I also want to note that my address is now [email protected] , the address I took recently because yahoo is only aviable via webmail and it is not good for patches.

Thanks for reply,

regards , Maxim Levitsky