xen/x86: properly retrieve NMI reason
Subsystems (4)
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port 0x61 in a DomU would be even worse, while the shared info field would just hold zero all the time.
--- arch/x86/xen/enlighten.c | 22 +++++++++++++++++- include/xen/interface/nmi.h | 52 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 1 deletion(-)
arch/x86/xen/enlighten.c +21 -1
@@ -40,6 +40,7 @@#include <xen/interface/physdev.h> #include <xen/interface/vcpu.h> #include <xen/interface/memory.h> +#include <xen/interface/nmi.h> #include <xen/interface/xen-mca.h> #include <xen/features.h> #include <xen/page.h>
@@ -66,6 +67,7 @@#include <asm/reboot.h> #include <asm/stackprotector.h> #include <asm/hypervisor.h> +#include <asm/mach_traps.h> #include <asm/mwait.h> #include <asm/pci_x86.h> #include <asm/pat.h>
@@ -1357,6 +1359,21 @@ static const struct machine_ops xen_mach .emergency_restart = xen_emergency_restart, }; +static unsigned char xen_get_nmi_reason (void ) +{ +unsigned char reason =0 ; + +/* Construct a value which looks like it came from port 0x61. */ +if (test_bit (_XEN_NMIREASON_io_error, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_IOCHK ; +if (test_bit (_XEN_NMIREASON_pci_serr, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_SERR ; + +return reason; +} +static void __init xen_boot_params_init_edd (void ) {#if IS_ENABLED (CONFIG_EDD )
@@ -1541,9 +1558,12 @@ asmlinkage __visible void __init xen_sta pv_info = xen_info; pv_init_ops = xen_init_ops; pv_apic_ops = xen_apic_ops; -if (!xen_pvh_domain ()) +if (!xen_pvh_domain ()) { pv_cpu_ops = xen_cpu_ops; + x86_platform.get_nmi_reason = xen_get_nmi_reason; + } +if (xen_feature (XENFEAT_auto_translated_physmap)) x86_init.resources.memory_setup = xen_auto_xlated_memory_setup;else
include/xen/interface/nmi.h renamed from usr/local/src/linux-3.18/include/xen/interface/nmi.h +52 -0
52 lines not on this page · raw message
Quoted 7 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.
Quoted 118 lines
Signed-off-by Jan Beulich <[email protected]>--- arch/x86/xen/enlighten.c | 22 +++++++++++++++++- include/xen/interface/nmi.h | 52 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 1 deletion(-)arch/x86/xen/enlighten.c +21
-1@@ -40,6 +40,7 @@#include <xen/interface/physdev.h> #include <xen/interface/vcpu.h> #include <xen/interface/memory.h> +#include <xen/interface/nmi.h> #include <xen/interface/xen-mca.h> #include <xen/features.h> #include <xen/page.h> @@ -66,6 +67,7 @@#include <asm/reboot.h> #include <asm/stackprotector.h> #include <asm/hypervisor.h> +#include <asm/mach_traps.h> #include <asm/mwait.h> #include <asm/pci_x86.h> #include <asm/pat.h> @@ -1357,6 +1359,21 @@ static const struct machine_ops xen_mach .emergency_restart = xen_emergency_restart, }; +static unsigned char xen_get_nmi_reason (void ) +{ +unsigned char reason =0 ; + +/* Construct a value which looks like it came from port 0x61. */ +if (test_bit (_XEN_NMIREASON_io_error, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_IOCHK ; +if (test_bit (_XEN_NMIREASON_pci_serr, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_SERR ; + +return reason; +} +static void __init xen_boot_params_init_edd (void ) {#if IS_ENABLED (CONFIG_EDD )@@ -1541,9 +1558,12 @@ asmlinkage __visible void __init xen_sta pv_info = xen_info; pv_init_ops = xen_init_ops; pv_apic_ops = xen_apic_ops; -if (!xen_pvh_domain ()) +if (!xen_pvh_domain ()) { pv_cpu_ops = xen_cpu_ops; + x86_platform.get_nmi_reason = xen_get_nmi_reason; + } +if (xen_feature (XENFEAT_auto_translated_physmap)) x86_init.resources.memory_setup = xen_auto_xlated_memory_setup;else include/xen/interface/nmi.h renamed from usr/local/src/linux-3.18/include/xen/interface/nmi.h +52
-0@@ -0,0 +1,52 @@ +/****************************************************************************** +* nmi.h +* +* NMI callback registration and reason codes. +* +* Copyright (c) 2005, Keir Fraser <[email protected]> +*/ + +#ifndef __XEN_PUBLIC_NMI_H__ +#define __XEN_PUBLIC_NMI_H__ + +#include <xen/interface/xen.h> + +/* +* NMI reason codes: +* Currently these are x86-specific, stored in arch_shared_info.nmi_reason. +*/ +/* I/O-check error reported via ISA port 0x61, bit 6. */ +#define _XEN_NMIREASON_io_error 0 +#define XEN_NMIREASON_io_error (1UL << _XEN_NMIREASON_io_error) +/* PCI SERR reported via ISA port 0x61, bit 7. */ +#define _XEN_NMIREASON_pci_serr 1 +#define XEN_NMIREASON_pci_serr (1UL << _XEN_NMIREASON_pci_serr) +/* Unknown hardware-generated NMI. */ +#define _XEN_NMIREASON_unknown 2 +#define XEN_NMIREASON_unknown (1UL << _XEN_NMIREASON_unknown) + +/* +* long nmi_op(unsigned int cmd, void *arg) +* NB. All ops return zero on success, else a negative error code. +*/ + +/* +* Register NMI callback for this (calling) VCPU. Currently this only makes +* sense for domain 0, vcpu 0. All other callers will be returned EINVAL. +* arg == pointer to xennmi_callback structure. +*/ +#define XENNMI_register_callback 0 +struct xennmi_callback { +unsigned long handler_address; +unsigned long pad; +}; +typedef struct xennmi_callback xennmi_callback_t ; +DEFINE_XEN_GUEST_HANDLE (xennmi_callback_t); + +/* +* Deregister NMI callback for this (calling) VCPU. +* arg == NULL. +*/ +#define XENNMI_unregister_callback 1 + +#endif /* __XEN_PUBLIC_NMI_H__ */
Quoted 7 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.
Quoted 118 lines
Signed-off-by Jan Beulich <[email protected]>--- arch/x86/xen/enlighten.c | 22 +++++++++++++++++- include/xen/interface/nmi.h | 52 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 1 deletion(-)arch/x86/xen/enlighten.c +21
-1@@ -40,6 +40,7 @@#include <xen/interface/physdev.h> #include <xen/interface/vcpu.h> #include <xen/interface/memory.h> +#include <xen/interface/nmi.h> #include <xen/interface/xen-mca.h> #include <xen/features.h> #include <xen/page.h> @@ -66,6 +67,7 @@#include <asm/reboot.h> #include <asm/stackprotector.h> #include <asm/hypervisor.h> +#include <asm/mach_traps.h> #include <asm/mwait.h> #include <asm/pci_x86.h> #include <asm/pat.h> @@ -1357,6 +1359,21 @@ static const struct machine_ops xen_mach .emergency_restart = xen_emergency_restart, }; +static unsigned char xen_get_nmi_reason (void ) +{ +unsigned char reason =0 ; + +/* Construct a value which looks like it came from port 0x61. */ +if (test_bit (_XEN_NMIREASON_io_error, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_IOCHK ; +if (test_bit (_XEN_NMIREASON_pci_serr, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_SERR ; + +return reason; +} +static void __init xen_boot_params_init_edd (void ) {#if IS_ENABLED (CONFIG_EDD )@@ -1541,9 +1558,12 @@ asmlinkage __visible void __init xen_sta pv_info = xen_info; pv_init_ops = xen_init_ops; pv_apic_ops = xen_apic_ops; -if (!xen_pvh_domain ()) +if (!xen_pvh_domain ()) { pv_cpu_ops = xen_cpu_ops; + x86_platform.get_nmi_reason = xen_get_nmi_reason; + } +if (xen_feature (XENFEAT_auto_translated_physmap)) x86_init.resources.memory_setup = xen_auto_xlated_memory_setup;else include/xen/interface/nmi.h renamed from usr/local/src/linux-3.18/include/xen/interface/nmi.h +52
-0@@ -0,0 +1,52 @@ +/****************************************************************************** +* nmi.h +* +* NMI callback registration and reason codes. +* +* Copyright (c) 2005, Keir Fraser <[email protected]> +*/ + +#ifndef __XEN_PUBLIC_NMI_H__ +#define __XEN_PUBLIC_NMI_H__ + +#include <xen/interface/xen.h> + +/* +* NMI reason codes: +* Currently these are x86-specific, stored in arch_shared_info.nmi_reason. +*/ +/* I/O-check error reported via ISA port 0x61, bit 6. */ +#define _XEN_NMIREASON_io_error 0 +#define XEN_NMIREASON_io_error (1UL << _XEN_NMIREASON_io_error) +/* PCI SERR reported via ISA port 0x61, bit 7. */ +#define _XEN_NMIREASON_pci_serr 1 +#define XEN_NMIREASON_pci_serr (1UL << _XEN_NMIREASON_pci_serr) +/* Unknown hardware-generated NMI. */ +#define _XEN_NMIREASON_unknown 2 +#define XEN_NMIREASON_unknown (1UL << _XEN_NMIREASON_unknown) + +/* +* long nmi_op(unsigned int cmd, void *arg) +* NB. All ops return zero on success, else a negative error code. +*/ + +/* +* Register NMI callback for this (calling) VCPU. Currently this only makes +* sense for domain 0, vcpu 0. All other callers will be returned EINVAL. +* arg == pointer to xennmi_callback structure. +*/ +#define XENNMI_register_callback 0 +struct xennmi_callback { +unsigned long handler_address; +unsigned long pad; +}; +typedef struct xennmi_callback xennmi_callback_t ; +DEFINE_XEN_GUEST_HANDLE (xennmi_callback_t); + +/* +* Deregister NMI callback for this (calling) VCPU. +* arg == NULL. +*/ +#define XENNMI_unregister_callback 1 + +#endif /* __XEN_PUBLIC_NMI_H__ */
Quoted 7 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.
What's the user visible impact of this fix?
David
Quoted 124 lines
Signed-off-by Jan Beulich <[email protected]>--- arch/x86/xen/enlighten.c | 22 +++++++++++++++++- include/xen/interface/nmi.h | 52 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 1 deletion(-)arch/x86/xen/enlighten.c +21
-1@@ -40,6 +40,7 @@#include <xen/interface/physdev.h> #include <xen/interface/vcpu.h> #include <xen/interface/memory.h> +#include <xen/interface/nmi.h> #include <xen/interface/xen-mca.h> #include <xen/features.h> #include <xen/page.h> @@ -66,6 +67,7 @@#include <asm/reboot.h> #include <asm/stackprotector.h> #include <asm/hypervisor.h> +#include <asm/mach_traps.h> #include <asm/mwait.h> #include <asm/pci_x86.h> #include <asm/pat.h> @@ -1357,6 +1359,21 @@ static const struct machine_ops xen_mach .emergency_restart = xen_emergency_restart, }; +static unsigned char xen_get_nmi_reason (void ) +{ +unsigned char reason =0 ; + +/* Construct a value which looks like it came from port 0x61. */ +if (test_bit (_XEN_NMIREASON_io_error, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_IOCHK ; +if (test_bit (_XEN_NMIREASON_pci_serr, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_SERR ; + +return reason; +} +static void __init xen_boot_params_init_edd (void ) {#if IS_ENABLED (CONFIG_EDD )@@ -1541,9 +1558,12 @@ asmlinkage __visible void __init xen_sta pv_info = xen_info; pv_init_ops = xen_init_ops; pv_apic_ops = xen_apic_ops; -if (!xen_pvh_domain ()) +if (!xen_pvh_domain ()) { pv_cpu_ops = xen_cpu_ops; + x86_platform.get_nmi_reason = xen_get_nmi_reason; + } +if (xen_feature (XENFEAT_auto_translated_physmap)) x86_init.resources.memory_setup = xen_auto_xlated_memory_setup;else include/xen/interface/nmi.h renamed from usr/local/src/linux-3.18/include/xen/interface/nmi.h +52
-0@@ -0,0 +1,52 @@ +/****************************************************************************** +* nmi.h +* +* NMI callback registration and reason codes. +* +* Copyright (c) 2005, Keir Fraser <[email protected]> +*/ + +#ifndef __XEN_PUBLIC_NMI_H__ +#define __XEN_PUBLIC_NMI_H__ + +#include <xen/interface/xen.h> + +/* +* NMI reason codes: +* Currently these are x86-specific, stored in arch_shared_info.nmi_reason. +*/ +/* I/O-check error reported via ISA port 0x61, bit 6. */ +#define _XEN_NMIREASON_io_error 0 +#define XEN_NMIREASON_io_error (1UL << _XEN_NMIREASON_io_error) +/* PCI SERR reported via ISA port 0x61, bit 7. */ +#define _XEN_NMIREASON_pci_serr 1 +#define XEN_NMIREASON_pci_serr (1UL << _XEN_NMIREASON_pci_serr) +/* Unknown hardware-generated NMI. */ +#define _XEN_NMIREASON_unknown 2 +#define XEN_NMIREASON_unknown (1UL << _XEN_NMIREASON_unknown) + +/* +* long nmi_op(unsigned int cmd, void *arg) +* NB. All ops return zero on success, else a negative error code. +*/ + +/* +* Register NMI callback for this (calling) VCPU. Currently this only makes +* sense for domain 0, vcpu 0. All other callers will be returned EINVAL. +* arg == pointer to xennmi_callback structure. +*/ +#define XENNMI_register_callback 0 +struct xennmi_callback { +unsigned long handler_address; +unsigned long pad; +}; +typedef struct xennmi_callback xennmi_callback_t ; +DEFINE_XEN_GUEST_HANDLE (xennmi_callback_t); + +/* +* Deregister NMI callback for this (calling) VCPU. +* arg == NULL. +*/ +#define XENNMI_unregister_callback 1 + +#endif /* __XEN_PUBLIC_NMI_H__ */ _______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 11 lines
Quoted 1 line
Quoted 1 line
David Vrabel <[email protected]> 12/23/14 12:01 PM >>>
Quoted 7 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.What's the user visible impact of this fix?
Depends on what "user visible" is: It ought to prevent "Dazed and confused..." messages when not really applicable, and allow to get forwarded particularly SERR ones to APEI (GHES) code instead. I can't say I've seen this work in practice, as I lack ways to force SERR on otherwise well behaving hardware, but code inspection shows that the way it is now it can't work as intended.
Jan
Quoted 11 lines
Quoted 1 line
Quoted 1 line
David Vrabel <[email protected]> 12/23/14 12:01 PM >>>
Quoted 7 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.What's the user visible impact of this fix?
Depends on what "user visible" is: It ought to prevent "Dazed and confused..." messages when not really applicable, and allow to get forwarded particularly SERR ones to APEI (GHES) code instead. I can't say I've seen this work in practice, as I lack ways to force SERR on otherwise well behaving hardware, but code inspection shows that the way it is now it can't work as intended.
Jan
Quoted 7 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.
What's the user visible impact of this fix?
David
Quoted 124 lines
Signed-off-by Jan Beulich <[email protected]>--- arch/x86/xen/enlighten.c | 22 +++++++++++++++++- include/xen/interface/nmi.h | 52 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 73 insertions(+), 1 deletion(-)arch/x86/xen/enlighten.c +21
-1@@ -40,6 +40,7 @@#include <xen/interface/physdev.h> #include <xen/interface/vcpu.h> #include <xen/interface/memory.h> +#include <xen/interface/nmi.h> #include <xen/interface/xen-mca.h> #include <xen/features.h> #include <xen/page.h> @@ -66,6 +67,7 @@#include <asm/reboot.h> #include <asm/stackprotector.h> #include <asm/hypervisor.h> +#include <asm/mach_traps.h> #include <asm/mwait.h> #include <asm/pci_x86.h> #include <asm/pat.h> @@ -1357,6 +1359,21 @@ static const struct machine_ops xen_mach .emergency_restart = xen_emergency_restart, }; +static unsigned char xen_get_nmi_reason (void ) +{ +unsigned char reason =0 ; + +/* Construct a value which looks like it came from port 0x61. */ +if (test_bit (_XEN_NMIREASON_io_error, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_IOCHK ; +if (test_bit (_XEN_NMIREASON_pci_serr, + &HYPERVISOR_shared_info->arch.nmi_reason)) + reason |=NMI_REASON_SERR ; + +return reason; +} +static void __init xen_boot_params_init_edd (void ) {#if IS_ENABLED (CONFIG_EDD )@@ -1541,9 +1558,12 @@ asmlinkage __visible void __init xen_sta pv_info = xen_info; pv_init_ops = xen_init_ops; pv_apic_ops = xen_apic_ops; -if (!xen_pvh_domain ()) +if (!xen_pvh_domain ()) { pv_cpu_ops = xen_cpu_ops; + x86_platform.get_nmi_reason = xen_get_nmi_reason; + } +if (xen_feature (XENFEAT_auto_translated_physmap)) x86_init.resources.memory_setup = xen_auto_xlated_memory_setup;else include/xen/interface/nmi.h renamed from usr/local/src/linux-3.18/include/xen/interface/nmi.h +52
-0@@ -0,0 +1,52 @@ +/****************************************************************************** +* nmi.h +* +* NMI callback registration and reason codes. +* +* Copyright (c) 2005, Keir Fraser <[email protected]> +*/ + +#ifndef __XEN_PUBLIC_NMI_H__ +#define __XEN_PUBLIC_NMI_H__ + +#include <xen/interface/xen.h> + +/* +* NMI reason codes: +* Currently these are x86-specific, stored in arch_shared_info.nmi_reason. +*/ +/* I/O-check error reported via ISA port 0x61, bit 6. */ +#define _XEN_NMIREASON_io_error 0 +#define XEN_NMIREASON_io_error (1UL << _XEN_NMIREASON_io_error) +/* PCI SERR reported via ISA port 0x61, bit 7. */ +#define _XEN_NMIREASON_pci_serr 1 +#define XEN_NMIREASON_pci_serr (1UL << _XEN_NMIREASON_pci_serr) +/* Unknown hardware-generated NMI. */ +#define _XEN_NMIREASON_unknown 2 +#define XEN_NMIREASON_unknown (1UL << _XEN_NMIREASON_unknown) + +/* +* long nmi_op(unsigned int cmd, void *arg) +* NB. All ops return zero on success, else a negative error code. +*/ + +/* +* Register NMI callback for this (calling) VCPU. Currently this only makes +* sense for domain 0, vcpu 0. All other callers will be returned EINVAL. +* arg == pointer to xennmi_callback structure. +*/ +#define XENNMI_register_callback 0 +struct xennmi_callback { +unsigned long handler_address; +unsigned long pad; +}; +typedef struct xennmi_callback xennmi_callback_t ; +DEFINE_XEN_GUEST_HANDLE (xennmi_callback_t); + +/* +* Deregister NMI callback for this (calling) VCPU. +* arg == NULL. +*/ +#define XENNMI_unregister_callback 1 + +#endif /* __XEN_PUBLIC_NMI_H__ */ _______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 9 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.Signed-off-by Jan Beulich <[email protected]>
This doesn't build.
In file included from /local/davidvr/work/k.org/tip/arch/x86/xen/enlighten.c:43:0:
/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: warning:
data definition has no type or storage class [enabled by default] /local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: error:
type defaults to ‘int’ in declaration of ‘DEFINE_XEN_GUEST_HANDLE’ [-Werror=implicit-int]
cc1: some warnings being treated as errors
David
Quoted 14 lines
Quoted 1 line
Quoted 1 line
David Vrabel <[email protected]> 01/05/15 11:35 AM >>>
Quoted 9 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.Signed-off-by Jan Beulich <[email protected]>This doesn't build.
Quoted 8 lines
In file included from /local/davidvr/work/k.org/tip/arch/x86/xen/enlighten.c:43:0:
/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: warning:
data definition has no type or storage class [enabled by default] /local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: error:
type defaults to ‘int’ in declaration of ‘DEFINE_XEN_GUEST_HANDLE’ [-Werror=implicit-int]
cc1: some warnings being treated as errors
Hmm, I can see why this happens (Linux renaming the macro from what the canonical headers use), but I'll have to check why my build test didn't catch this...
Jan
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
Quoted 9 lines · Jan Beulich
Using the native code here can't work properly, as the hypervisor would normally have cleared the two reason bits by the time Dom0 gets to see the NMI (if passed to it at all). There's a shared info field for this, and there's an existing hook to use - just fit the two together. Note that the hook can (and should) be used irrespective of whether being in Dom0, as accessing port
0x61in a DomU would be even worse, while the shared info field would just hold zero all the time.Signed-off-by Jan Beulich <[email protected]>
This doesn't build.
In file included from /local/davidvr/work/k.org/tip/arch/x86/xen/enlighten.c:43:0:
/local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: warning:
data definition has no type or storage class [enabled by default] /local/davidvr/work/k.org/tip/include/xen/interface/nmi.h:44:1: error:
type defaults to ‘int’ in declaration of ‘DEFINE_XEN_GUEST_HANDLE’ [-Werror=implicit-int]
cc1: some warnings being treated as errors
David