Skip to contentSkip to conversation

staging: vt6655: fix sparse warnings: incorrect argument type

PATCH In review Mike Krinkin 2 participants 2 messages Dec 21, 2014 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vt6655: fix sparse warnings: incorrect argument type

this patch fixes following sparse warnings:

drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *

---
 drivers/staging/vt6655/device_main.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/vt6655/device_main.c +4 -2
index 83e4162..ce616f9 100644
@@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
 		if (conf->enable_beacon) {
 			vnt_beacon_enable(priv, vif, conf);
 
-			MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
+			MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
+				      TCR_AUTOBCNTX);
 		} else {
-			MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
+			MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
+				       TCR_AUTOBCNTX);
 		}
 	}
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 14 lines · Mike Krinkin

this patch fixes following sparse warnings:

drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1503:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *
drivers/staging/vt6655/device_main.c:1505:25: warning: incorrect type in argument 2 (different address spaces)
drivers/staging/vt6655/device_main.c:1505:25: expected void [noderef] <asn:2>*<noident>
drivers/staging/vt6655/device_main.c:1505:25: got struct vnt_private *

Good catch

also needed for 3.19

Thanks

Malcolm

Quoted 25 lines
---
  drivers/staging/vt6655/device_main.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/vt6655/device_main.c +4 -2
index 83e4162..ce616f9 100644
@@ -1500,9 +1500,11 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
  		if (conf->enable_beacon) {
  			vnt_beacon_enable(priv, vif, conf);
 
-			MACvRegBitsOn(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
+			MACvRegBitsOn(priv->PortOffset, MAC_REG_TCR,
+				      TCR_AUTOBCNTX);
  		} else {
-			MACvRegBitsOff(priv, MAC_REG_TCR, TCR_AUTOBCNTX);
+			MACvRegBitsOff(priv->PortOffset, MAC_REG_TCR,
+				       TCR_AUTOBCNTX);
  		}
  	}