Skip to contentSkip to conversation

ARM: qcom: select ARM_CPU_SUSPEND for power management

PATCH In review Arnd Bergmann 3 participants 3 messages Nov 24, 2015 – Nov 25, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: qcom: select ARM_CPU_SUSPEND for power management

The qcom spm driver uses cpu_resume_arm(), which is not included in the kernel in all configurations:

drivers/built-in.o: In function `qcom_cpu_spc':
:(.text+0xbc022): undefined reference to cpu_suspend' drivers/built-in.o: In function qcom_cpuidle_init':
:(.init.text+0x610c): undefined reference to `cpu_resume_arm'

This adds a 'select' Kconfig statement to ensure it's always enabled.

---
This has been broken for a while but not even shown up in many thousands of randconfig builds until today. Please queue it up for 4.5 unless you think it should really go into 4.4 as well.

drivers/soc/qcom/Kconfig +1 -0
index 3c6e3893b76c..461b387d03cc 100644
@@ -13,6 +13,7 @@ config QCOM_GSBI
 config QCOM_PM
 	bool "Qualcomm Power Management"
 	depends on ARCH_QCOM && !ARM64
+	select ARM_CPU_SUSPEND
 	select QCOM_SCM
 	help
 	  QCOM Platform specific power driver to manage cores and L2 low power
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Arnd Bergmann

The qcom spm driver uses cpu_resume_arm(), which is not included in the kernel in all configurations:

drivers/built-in.o: In function `qcom_cpu_spc':
:(.text+0xbc022): undefined reference to cpu_suspend' drivers/built-in.o: In function qcom_cpuidle_init':
:(.init.text+0x610c): undefined reference to `cpu_resume_arm'

Quoted 5 lines

This adds a 'select' Kconfig statement to ensure it's always enabled.

---

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#2 lore raw
In reply to Arnd Bergmann
Quoted 8 lines · Arnd Bergmann

The qcom spm driver uses cpu_resume_arm(), which is not included in the kernel in all configurations:

drivers/built-in.o: In function `qcom_cpu_spc':
:(.text+0xbc022): undefined reference to cpu_suspend' drivers/built-in.o: In function qcom_cpuidle_init':
:(.init.text+0x610c): undefined reference to `cpu_resume_arm'

Quoted 8 lines

This adds a 'select' Kconfig statement to ensure it's always enabled.

---
This has been broken for a while but not even shown up in many thousands of randconfig builds until today. Please queue it up for 4.5 unless you think it should really go into 4.4 as well.

Thanks Arnd. I'll add this to my list for the pull request.