package/wpa_supplicant: use correct include path for libnl-3.0

PATCH New Romain Naour 2 participants 3 messages Dec 16, 2014 – Dec 21, 2014

lore

Share & tools

lore

Romain Naour

author

2014-12-16 23:07 UTC #0 lore raw

PATCH 1/1 package/wpa_supplicant: use correct include path for libnl-3.0

Fixes:
ERROR: unsafe header/library path used in cross-compilation: '/usr/include/libnl3'

Add a dependancy on host-pkgconf when BR2_PACKAGE_LIBNL is enabled.

Signed-off-by Romain Naour <[email protected]>

Reported-by J?rg Krause <[email protected]>

Cc J?rg Krause <[email protected]>

---
 ...02-use-correct-include-path-for-libnl-3.0.patch | 26 ++++++++++++++++++++++
 package/wpa_supplicant/wpa_supplicant.mk           |  2 +-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 package/wpa_supplicant/0002-use-correct-include-path-for-libnl-3.0.patch

package/wpa_supplicant/0002-use-correct-include-path-for-libnl-3.0.patch new file +26 -0

new file mode 100644
index 0000000..6ed0eed
@@ -0,0 +1,26 @@
+From 4426de35f0e5dd5b0152474ce6a885b73de60656 Mon Sep 17 00:00:00 2001
+From: Romain Naour <[email protected]>
+Date: Tue, 16 Dec 2014 23:50:33 +0100
+Subject: [PATCH 2/2] use correct include path for libnl-3.0
+
+Signed-off-by: Romain Naour <[email protected]>
+---
+ src/drivers/drivers.mak | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/drivers/drivers.mak b/src/drivers/drivers.mak
+index cdb913e..e9fc83c 100644
+--- a/src/drivers/drivers.mak
++++ b/src/drivers/drivers.mak
+@@ -35,7 +35,7 @@ NEED_RFKILL=y
+ ifdef CONFIG_LIBNL32
+   DRV_LIBS += -lnl-3
+   DRV_LIBS += -lnl-genl-3
+-  DRV_CFLAGS += -DCONFIG_LIBNL20 -I/usr/include/libnl3
++  DRV_CFLAGS += -DCONFIG_LIBNL20 `pkg-config --cflags libnl-3.0`
+ ifdef CONFIG_LIBNL3_ROUTE
+   DRV_LIBS += -lnl-route-3
+   DRV_CFLAGS += -DCONFIG_LIBNL3_ROUTE
+-- 
+1.9.3
+

package/wpa_supplicant/wpa_supplicant.mk +1 -1

index 0c4abb5..10b2c0a 100644
@@ -35,7 +35,7 @@ ifeq ($(BR2_PACKAGE_LIBNL),y)
 ifeq ($(BR2_STATIC_LIBS),y)
 	WPA_SUPPLICANT_LIBS += -lnl-3 -lm -lpthread
 endif
-	WPA_SUPPLICANT_DEPENDENCIES += libnl
+	WPA_SUPPLICANT_DEPENDENCIES += host-pkgconf libnl
 	WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_LIBNL32
 else
 	WPA_SUPPLICANT_CONFIG_DISABLE += CONFIG_DRIVER_NL80211

Signature · 1 line

1.9.3

Thomas Petazzoni

Applied

2014-12-20 15:11 UTC #1 lore raw

PATCH 1/1 package/wpa_supplicant: use correct include path for libnl-3.0

Dear Romain Naour,

Quoted 5 lines · Romain Naour

Fixes:
ERROR: unsafe header/library path used in cross-compilation: '/usr/include/libnl3'
Add a dependancy on host-pkgconf when BR2_PACKAGE_LIBNL is enabled.

Quoted 8 lines

Signed-off-by Romain Naour <[email protected]>
Reported-by J?rg Krause <[email protected]>
Cc J?rg Krause <[email protected]>
---
 ...02-use-correct-include-path-for-libnl-3.0.patch | 26 ++++++++++++++++++++++
 package/wpa_supplicant/wpa_supplicant.mk           |  2 +-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 package/wpa_supplicant/0002-use-correct-include-path-for-libnl-3.0.patch

Thanks, applied. Please submit the patch to upstream wpa_supplicant.

Best regards,

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Romain Naour

author

2014-12-21 21:08 UTC #2 lore raw

PATCH 1/1 package/wpa_supplicant: use correct include path for libnl-3.0

Hi Thomas,

Le 20/12/2014 16:11, Thomas Petazzoni a ?crit :

Quoted 16 lines

Dear Romain Naour,
Quoted 5 lines · Romain Naour
Fixes:
ERROR: unsafe header/library path used in cross-compilation: '/usr/include/libnl3'
Add a dependancy on host-pkgconf when BR2_PACKAGE_LIBNL is enabled.
Quoted 8 lines
Signed-off-by Romain Naour <[email protected]>
Reported-by J?rg Krause <[email protected]>
Cc J?rg Krause <[email protected]>
---
 ...02-use-correct-include-path-for-libnl-3.0.patch | 26 ++++++++++++++++++++++
 package/wpa_supplicant/wpa_supplicant.mk           |  2 +-
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 package/wpa_supplicant/0002-use-correct-include-path-for-libnl-3.0.patch

Quoted 5 lines

Thanks, applied. Please submit the patch to upstream wpa_supplicant.
Best regards,
Thomas

Patch sent to the wpa_supplicant mailing list, but it's waiting for moderation.

This is the same patch as for hostapd.

Best regards,
Romain Naour