Skip to contentSkip to conversation

No need for parade bridge on peach-pi

PATCH New Sjoerd Simons 2 participants 4 messages Dec 5, 2014 – Dec 22, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v3 cover No need for parade bridge on peach-pi

With current u-boot-samsung HEAD on a peach-pi the following error is printed:
exynos_lcd_power_on: ps8625_init() failed

Which is not surprising given that chip does not exist on these boards.

Changes since v2:
* Move the parade_init function to its own header file
Changes since v1:
* Only change the DTS for peach-pi not the default config. Further configuration changes will be done seperately
* Use the approach as suggested by Ajay Kumar to fix compilation without parade support

Sjoerd Simons (2):
Exynos5800: The Peach-Pi board does not have a Parade video bridge
exynos5420: fix compilation without parade video

 arch/arm/dts/exynos5800-peach-pi.dts      |  5 -----
 arch/arm/include/asm/arch-exynos/system.h |  3 ---
 board/samsung/smdk5420/smdk5420.c         |  1 +
 include/parade.h                          | 18 ++++++++++++++++++
 4 files changed, 19 insertions(+), 8 deletions(-)
 create mode 100644 include/parade.h
Signature · 1 line
2.1.3
#1 lore raw

PATCH v3 1/2 Exynos5800: The Peach-Pi board does not have a Parade video bridge

Unlike the Peach-Pit board, there is no parade edp to lvds bridge on the Pi. So drop it from device-tree

---
Changes since v2: Add Ack/Tested by from Simon Glass Changes since v1: Only modify the DTB

 arch/arm/dts/exynos5800-peach-pi.dts | 5 -----
 1 file changed, 5 deletions(-)
arch/arm/dts/exynos5800-peach-pi.dts +0 -5
index 8aedf8e..2f9d2db 100644
@@ -63,11 +63,6 @@
 	              reg = <0x20>;
 	              compatible = "maxim,max98090-codec";
 	       };
-
-	        edp-lvds-bridge at 48 {
-	                compatible = "parade,ps8625";
-	                reg = <0x48>;
-	        };
 	};
 
         sound at 3830000 {
Signature · 1 line
2.1.3
#2 lore raw

PATCH v3 2/2 exynos5420: fix compilation without parade video

In reply to Sjoerd Simons

Not all exynos 5420 based devices with an LCD also have a parade LVDS bridge. So make sure compilation doesn't break if CONFIG_LCD is enabled and CONFIG_VIDEO_PARADE is not.

As a side-effect move the parade functions from the exynos system header file to its own file.

---
Changes since V2: Take the opportunity to move parade_init to it's own include
file. As requested by Minkyu Kang
Changes since V1: New patch

 arch/arm/include/asm/arch-exynos/system.h |  3 ---
 board/samsung/smdk5420/smdk5420.c         |  1 +
 include/parade.h                          | 18 ++++++++++++++++++
 3 files changed, 19 insertions(+), 3 deletions(-)
 create mode 100644 include/parade.h
arch/arm/include/asm/arch-exynos/system.h +0 -3
index 320763f..4968d3d 100644
@@ -41,7 +41,4 @@ void set_usbhost_mode(unsigned int mode);
 void set_system_display_ctrl(void);
 int exynos_lcd_early_init(const void *blob);
 
-/* Initialize the Parade dP<->LVDS bridge if present */
-int parade_init(const void *blob);
-
 #endif	/* _EXYNOS4_SYSTEM_H */
board/samsung/smdk5420/smdk5420.c +1 -0
index a691222..55f0ea2 100644
@@ -9,6 +9,7 @@
 #include <asm/io.h>
 #include <i2c.h>
 #include <lcd.h>
+#include <parade.h>
 #include <spi.h>
 #include <errno.h>
 #include <asm/gpio.h>
include/parade.h new file +18 -0
new file mode 100644
index 0000000..887f56d
@@ -0,0 +1,18 @@
+/*
+ * (C) Copyright 2012 Samsung Electronics
+ * Donghwa Lee <[email protected]>
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
+ */
+
+#ifndef __PARADE_H__
+#define __PARADE_H__
+
+/* Initialize the Parade dP<->LVDS bridge if present */
+#ifdef CONFIG_VIDEO_PARADE
+int parade_init(const void *blob);
+#else
+static inline int parade_init(const void *blob) { return -1; }
+#endif
+
+#endif	/* __PARADE_H__ */
Signature · 1 line
2.1.3
#3 lore raw

v3 cover No need for parade bridge on peach-pi

In reply to Sjoerd Simons
Quoted 17 lines · Sjoerd Simons

With current u-boot-samsung HEAD on a peach-pi the following error is printed:
exynos_lcd_power_on: ps8625_init() failed

Which is not surprising given that chip does not exist on these boards.

Changes since v2:
* Move the parade_init function to its own header file
Changes since v1:
* Only change the DTS for peach-pi not the default config. Further configuration changes will be done seperately
* Use the approach as suggested by Ajay Kumar to fix compilation without parade support

Sjoerd Simons (2):
Exynos5800: The Peach-Pi board does not have a Parade video bridge
exynos5420: fix compilation without parade video

Quoted 7 lines
 arch/arm/dts/exynos5800-peach-pi.dts      |  5 -----
 arch/arm/include/asm/arch-exynos/system.h |  3 ---
 board/samsung/smdk5420/smdk5420.c         |  1 +
 include/parade.h                          | 18 ++++++++++++++++++
 4 files changed, 19 insertions(+), 8 deletions(-)
 create mode 100644 include/parade.h

applied to u-boot-samsung.

Thanks,
Minkyu Kang.