Skip to contentSkip to conversation

ARM: exynos5420: Leave VBUS GPIO configuration up to common code

PATCH New Sjoerd Simons 3 participants 3 messages Dec 5, 2014 – Dec 22, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: exynos5420: Leave VBUS GPIO configuration up to common code

Since commit 4a271cb1b4ffdf330 (exynos: usb: Switch USB VBUS GPIOs to be device tree configured) it's not needed for the board specific files to turn on the VBUS GPIO by hand as that gets done based on device tree. So drop the redundant code from the SMDK5420 board file.

---
 board/samsung/smdk5420/smdk5420.c | 16 ----------------
 1 file changed, 16 deletions(-)
board/samsung/smdk5420/smdk5420.c +0 -16
index a691222..06cba80 100644
@@ -21,24 +21,8 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#ifdef CONFIG_USB_EHCI_EXYNOS
-static int board_usb_vbus_init(void)
-{
-	/* Enable VBUS power switch */
-	gpio_direction_output(EXYNOS5420_GPIO_X26, 1);
-
-	/* VBUS turn ON time */
-	mdelay(3);
-
-	return 0;
-}
-#endif
-
 int exynos_init(void)
 {
-#ifdef CONFIG_USB_EHCI_EXYNOS
-	board_usb_vbus_init();
-#endif
 	return 0;
 }
 
Signature · 1 line
2.1.3
#1 lore raw

PATCH 1/1 ARM: exynos5420: Leave VBUS GPIO configuration up to common code

Quoted 9 lines · Sjoerd Simons

Since commit 4a271cb1b4ffdf330 (exynos: usb: Switch USB VBUS GPIOs to be device tree configured) it's not needed for the board specific files to turn on the VBUS GPIO by hand as that gets done based on device tree. So drop the redundant code from the SMDK5420 board file.

---
 board/samsung/smdk5420/smdk5420.c | 16 ----------------
 1 file changed, 16 deletions(-)

Tested on Pi (exynos5420/5800)

#2 lore raw

PATCH 1/1 ARM: exynos5420: Leave VBUS GPIO configuration up to common code

In reply to Sjoerd Simons
Quoted 30 lines · Sjoerd Simons

Since commit 4a271cb1b4ffdf330 (exynos: usb: Switch USB VBUS GPIOs to be device tree configured) it's not needed for the board specific files to turn on the VBUS GPIO by hand as that gets done based on device tree. So drop the redundant code from the SMDK5420 board file.

---
 board/samsung/smdk5420/smdk5420.c | 16 ----------------
 1 file changed, 16 deletions(-)
board/samsung/smdk5420/smdk5420.c +0 -11
index a691222..06cba80 100644
@@ -21,24 +21,8 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#ifdef CONFIG_USB_EHCI_EXYNOS
-static int board_usb_vbus_init(void)
-{
-	/* Enable VBUS power switch */
-	gpio_direction_output(EXYNOS5420_GPIO_X26, 1);
-
-	/* VBUS turn ON time */
-	mdelay(3);
-
-	return 0;
-}

board/samsung/smdk5420/smdk5420.c line 28

Quoted 10 lines
board/samsung/smdk5420/smdk5420.c +0 -5
-#endif
-
 int exynos_init(void)
 {
-#ifdef CONFIG_USB_EHCI_EXYNOS
-	board_usb_vbus_init();
-#endif
 	return 0;
 }
 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.