Skip to contentSkip to conversation

Ask help about killing irqchip.irq_print_chip on PPC platforms

DISCUSSION Jiang Liu 2 participants 2 messages Dec 23, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Jiang Liu

author
#1 lore raw

Hi Scott and Tudor,
Sorry, resend and Ccing the list.
We are trying to clean up some irqchip interfaces, and
irqchip.irq_print_chip is a candidate for removal. After some changes on x86 side, arch/powerpc/sysdev/fsl_msi.c may be the last user of irqchip.irq_print_chip. So could you please help to advice on whether we could kill irqchip.irq_print_chip by using "fsl-msi" instead of "fsl-msi-%d" for irqchip name? Will it break any userspace interfaces?
Thanks!
Gerry

#2 lore raw
Quoted 2 lines · Jiang Liu

Hi Scott and Tudor,
Sorry, resend and Ccing the list.

Resending reply...

Quoted 9 lines

We are trying to clean up some irqchip interfaces, and
irqchip.irq_print_chip is a candidate for removal. After some changes on x86 side, arch/powerpc/sysdev/fsl_msi.c may be the last user of irqchip.irq_print_chip. So could you please help to advice on whether we could kill irqchip.irq_print_chip by using "fsl-msi" instead of "fsl-msi-%d" for irqchip name? Will it break any userspace interfaces?
Thanks!
Gerry

fsl-msi-%d was introduced to allow userspace to identify the cascade interrupt belonging to a particular MSI, for the purpose of setting affinity, as this cannot be done on the MSI itself due to hardware limitations.

Removing it would not exactly eliminate a lot of code or complexity...

-Scott