commit-tree: simplify parsing of option -S using skip_prefix()

PATCH In review René Scharfe 2 participants 2 messages Jun 15, 2016

lore

Share & tools

lore

René Scharfe

author

2016-06-15 23:03 UTC #0 lore raw

PATCH 1/1 commit-tree: simplify parsing of option -S using skip_prefix()

Signed-off-by Rene Scharfe <[email protected]>

---
 builtin/commit-tree.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

builtin/commit-tree.c +1 -3

index 8a66c74..25aa2cd 100644
@@ -66,10 +66,8 @@ int cmd_commit_tree(int argc, const char **argv, const char *prefix)
 			continue;
 		}
 
-		if (!memcmp(arg, "-S", 2)) {
-			sign_commit = arg + 2;
+		if (skip_prefix(arg, "-S", &sign_commit))
 			continue;
-		}
 
 		if (!strcmp(arg, "--no-gpg-sign")) {
 			sign_commit = NULL;

Signature · 1 line

2.2.1

Jonathan Nieder

Reviewed-by on v1 1/1

2016-06-15 23:03 UTC #1 lore raw

Quoted 4 lines · René Scharfe

Signed-off-by Rene Scharfe <[email protected]>
---
 builtin/commit-tree.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by Jonathan Nieder <[email protected]>

Thanks.