ocfs2/dlm: add missing dlm_lock_put() when recovery master down
PATCH 1/1 ocfs2/dlm: add missing dlm_lock_put() when recovery master down
When recovery master down, the owner of $RECOVERY calls dlm_do_local_recovery_cleanup() to prune any $RECOVERY entries for dead nodes. The lock is in granted list and refcount must be 2. We should put twice to remove this lock. Otherwise, it will lead to memory leak.
Reported-by yangwenfang <[email protected]>
Signed-off-by joyce.xue <[email protected]>
--- fs/ocfs2/dlm/dlmrecovery.c | 7 +++++++ 1 file changed, 7 insertions(+)
fs/ocfs2/dlm/dlmrecovery.c +7 -0
@@ -1070,6 +1070,9 @@ static void dlm_move_reco_locks_to_list(struct dlm_ctxt *dlm, dead_node, dlm->name);list_del_init (&lock->list);dlm_lock_put (lock); +/* Can't schedule DLM_UNLOCK_FREE_LOCK +* - do manually */ +dlm_lock_put (lock);break ; } }
@@ -2341,6 +2344,10 @@ static void dlm_do_local_recovery_cleanup(struct dlm_ctxt *dlm, u8 dead_node) dead_node, dlm->name);list_del_init (&lock->list);dlm_lock_put (lock); +/* Can't schedule +* DLM_UNLOCK_FREE_LOCK +* - do manually */ +dlm_lock_put (lock);break ; } }
Signature · 1 line
1.8.4.3