Skip to contentSkip to conversation

libvncserver: bump version to 0.9.10

PATCH New Floris Bos 4 participants 13 messages Dec 26, 2014 – Dec 27, 2014

lore
Share & tools
lore

Floris Bos

author
#0 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

Signed-off-by Floris Bos <[email protected]>
---
 .../libvncserver-0001-CVE-2014-6051-6052.patch     |  85 ------------
 .../libvncserver-0002-CVE-2014-6053.patch          |  21 ---
 .../libvncserver-0003-CVE-2014-6054.patch          |  87 ------------
 .../libvncserver-0004-CVE-2014-6055.patch          | 150 ---------------------
 package/libvncserver/libvncserver.mk               |   5 +-
 5 files changed, 3 insertions(+), 345 deletions(-)
 delete mode 100644 package/libvncserver/libvncserver-0001-CVE-2014-6051-6052.patch
 delete mode 100644 package/libvncserver/libvncserver-0002-CVE-2014-6053.patch
 delete mode 100644 package/libvncserver/libvncserver-0003-CVE-2014-6054.patch
 delete mode 100644 package/libvncserver/libvncserver-0004-CVE-2014-6055.patch
package/libvncserver/libvncserver-0001-CVE-2014-6051-6052.patch deleted +0 -85
deleted file mode 100644
index 6c21b1d..0000000
@@ -1,85 +0,0 @@
-Description: fix denial of service and possible code execution via
- integer overflow and lack of malloc error handling in MallocFrameBuffer()
-Origin: backport, https://github.com/newsoft/libvncserver/commit/045a044e8ae79db9244593fbce154cdf6e843273
-Origin: backport, https://github.com/newsoft/libvncserver/commit/85a778c0e45e87e35ee7199f1f25020648e8b812
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
-Index: libvncserver-0.9.9+dfsg/libvncclient/rfbproto.c
-===================================================================
---- libvncserver-0.9.9+dfsg.orig/libvncclient/rfbproto.c	2012-05-04 10:19:00.000000000 -0400
-+++ libvncserver-0.9.9+dfsg/libvncclient/rfbproto.c	2014-09-25 11:11:55.884057336 -0400
-@@ -1807,7 +1807,8 @@
- 	client->updateRect.x = client->updateRect.y = 0;
- 	client->updateRect.w = client->width;
- 	client->updateRect.h = client->height;
--	client->MallocFrameBuffer(client);
-+	if (!client->MallocFrameBuffer(client))
-+	  return FALSE;
- 	SendFramebufferUpdateRequest(client, 0, 0, rect.r.w, rect.r.h, FALSE);
- 	rfbClientLog("Got new framebuffer size: %dx%d\n", rect.r.w, rect.r.h);
- 	continue;
-@@ -2260,7 +2261,8 @@
-     client->updateRect.x = client->updateRect.y = 0;
-     client->updateRect.w = client->width;
-     client->updateRect.h = client->height;
--    client->MallocFrameBuffer(client);
-+    if (!client->MallocFrameBuffer(client))
-+      return FALSE;
-     SendFramebufferUpdateRequest(client, 0, 0, client->width, client->height, FALSE);
-     rfbClientLog("Got new framebuffer size: %dx%d\n", client->width, client->height);
-     break;
-@@ -2276,7 +2278,9 @@
-     client->updateRect.x = client->updateRect.y = 0;
-     client->updateRect.w = client->width;
-     client->updateRect.h = client->height;
--    client->MallocFrameBuffer(client);
-+    if (!client->MallocFrameBuffer(client))
-+      return FALSE;
-+
-     SendFramebufferUpdateRequest(client, 0, 0, client->width, client->height, FALSE);
-     rfbClientLog("Got new framebuffer size: %dx%d\n", client->width, client->height);
-     break;
-Index: libvncserver-0.9.9+dfsg/libvncclient/vncviewer.c
-===================================================================
---- libvncserver-0.9.9+dfsg.orig/libvncclient/vncviewer.c	2012-05-04 10:19:00.000000000 -0400
-+++ libvncserver-0.9.9+dfsg/libvncclient/vncviewer.c	2014-09-25 11:10:29.984055035 -0400
-@@ -82,9 +82,27 @@
- #endif
- }
- static rfbBool MallocFrameBuffer(rfbClient* client) {
-+uint64_t allocSize;
-+
-   if(client->frameBuffer)
-     free(client->frameBuffer);
--  client->frameBuffer=malloc(client->width*client->height*client->format.bitsPerPixel/8);
-+
-+  /* SECURITY: promote 'width' into uint64_t so that the multiplication does not overflow
-+     'width' and 'height' are 16-bit integers per RFB protocol design
-+     SIZE_MAX is the maximum value that can fit into size_t
-+  */
-+  allocSize = (uint64_t)client->width * client->height * client->format.bitsPerPixel/8;
-+
-+  if (allocSize >= SIZE_MAX) {
-+    rfbClientErr("CRITICAL: cannot allocate frameBuffer, requested size is too large\n");
-+    return FALSE;
-+  }
-+
-+  client->frameBuffer=malloc( (size_t)allocSize );
-+
-+  if (client->frameBuffer == NULL)
-+    rfbClientErr("CRITICAL: frameBuffer allocation failed, requested size too large or not enough memory?\n");
-+
-   return client->frameBuffer?TRUE:FALSE;
- }
- 
-@@ -225,7 +243,8 @@
- 
-   client->width=client->si.framebufferWidth;
-   client->height=client->si.framebufferHeight;
--  client->MallocFrameBuffer(client);
-+  if (!client->MallocFrameBuffer(client))
-+    return FALSE;
- 
-   if (!SetFormatAndEncodings(client))
-     return FALSE;
package/libvncserver/libvncserver-0002-CVE-2014-6053.patch deleted +0 -21
deleted file mode 100644
index 23b8ada..0000000
@@ -1,21 +0,0 @@
-Description: fix denial of service via large ClientCutText message
-Origin: backport, https://github.com/newsoft/libvncserver/commit/6037a9074d52b1963c97cb28ea1096c7c14cbf28
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
-Index: libvncserver-0.9.9+dfsg/libvncserver/rfbserver.c
-===================================================================
---- libvncserver-0.9.9+dfsg.orig/libvncserver/rfbserver.c	2012-05-04 10:19:00.000000000 -0400
-+++ libvncserver-0.9.9+dfsg/libvncserver/rfbserver.c	2014-09-25 11:12:36.124058413 -0400
-@@ -2457,6 +2457,11 @@
- 	msg.cct.length = Swap32IfLE(msg.cct.length);
- 
- 	str = (char *)malloc(msg.cct.length);
-+	if (str == NULL) {
-+		rfbLogPerror("rfbProcessClientNormalMessage: not enough memory");
-+		rfbCloseClient(cl);
-+		return;
-+	}
- 
- 	if ((n = rfbReadExact(cl, str, msg.cct.length)) <= 0) {
- 	    if (n != 0)
package/libvncserver/libvncserver-0003-CVE-2014-6054.patch deleted +0 -87

87 lines not on this page · raw message

package/libvncserver/libvncserver-0004-CVE-2014-6055.patch deleted +0 -150

150 lines not on this page · raw message

package/libvncserver/libvncserver.mk +3 -2
index 99d757b..b26d5b9 100644
@@ -4,13 +4,14 @@
 #
 ################################################################################
 
-LIBVNCSERVER_VERSION = 0.9.9
+LIBVNCSERVER_VERSION = 0.9.10
 LIBVNCSERVER_SOURCE = LibVNCServer-$(LIBVNCSERVER_VERSION).tar.gz
-LIBVNCSERVER_SITE = http://downloads.sourceforge.net/project/libvncserver/libvncserver/$(LIBVNCSERVER_VERSION)
+LIBVNCSERVER_SITE = https://github.com/LibVNC/libvncserver/archive
 LIBVNCSERVER_LICENSE = GPLv2+
 LIBVNCSERVER_LICENSE_FILES = COPYING
 LIBVNCSERVER_INSTALL_STAGING = YES
 LIBVNCSERVER_CONFIG_SCRIPTS = libvncserver-config
+LIBVNCSERVER_AUTORECONF = YES
 
 # only used for examples
 LIBVNCSERVER_CONF_OPTS += --with-sdl-config=/bin/false
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 libvncserver: add config option for tightpng encoding support

Signed-off-by Floris Bos <[email protected]>
---
 package/libvncserver/Config.in       | 13 +++++++++++++
 package/libvncserver/libvncserver.mk |  6 ++++++
 2 files changed, 19 insertions(+)
package/libvncserver/Config.in +13 -0
index 07b77f5..7d8272f 100644
@@ -5,3 +5,16 @@ config BR2_PACKAGE_LIBVNCSERVER
 	  libvncserver is a VNC server/client library.
 
 	  http://libvncserver.sourceforge.net/
+
+if BR2_PACKAGE_LIBVNCSERVER
+
+config BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG
+	bool "TightPNG encoding support"
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBPNG
+	help
+	  TightPNG encoding speeds up HTML5 based VNC clients like noVNC.
+
+	  http://wiki.qemu.org/VNC_Tight_PNG
+
+endif
package/libvncserver/libvncserver.mk +6 -0
index b26d5b9..8479a62 100644
@@ -56,4 +56,10 @@ else
 LIBVNCSERVER_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG),y)
+LIBVNCSERVER_DEPENDENCIES += libpng
+else
+LIBVNCSERVER_CONF_OPTS += --without-png
+endif
+
 $(eval $(autotools-package))
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 libvncserver: add config option for tightpng encoding support

Dear Floris Bos,

package/libvncserver/Config.in config BR2_PACKAGE_LIBVNCSERVER · line 18

Quoted 10 lines · Floris Bos
package/libvncserver/Config.in +10 -0
+if BR2_PACKAGE_LIBVNCSERVER
+
+config BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG
+	bool "TightPNG encoding support"
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBPNG
+	help
+	  TightPNG encoding speeds up HTML5 based VNC clients like noVNC.
+
+	  http://wiki.qemu.org/VNC_Tight_PNG

I've tried to read a bit, but I don't really understand whether JPEG is absolutely necessary to get TightPNG support. The webpage you mention says "If the client indicates JPEG support by sending a JPEG quality pseudo-encoding, then the server can send JPEG, because PNG will only replace the basic compression type used in normal tight.", which seems to indicate that the JPEG support is only optional.

package/libvncserver/libvncserver.mk else · line 60

Quoted 11 lines
(quoted diff) +1 -0
+endif
package/libvncserver/libvncserver.mk +2 -0
index b26d5b9..8479a62 100644
@@ -56,4 +56,10 @@ else
 LIBVNCSERVER_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG),y)
+LIBVNCSERVER_DEPENDENCIES += libpng

So we don't really need JPEG support after all, since you don't depend on it?

package/libvncserver/libvncserver.mk else · line 65

Quoted 5 lines
package/libvncserver/libvncserver.mk +4 -0
+else
+LIBVNCSERVER_CONF_OPTS += --without-png
+endif
+
 $(eval $(autotools-package))

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#3 lore raw

PATCH 2/2 libvncserver: add config option for tightpng encoding support

Quoted 11 lines · Thomas Petazzoni
Quoted 9 lines · Floris Bos
package/libvncserver/Config.in +9 -0
+if BR2_PACKAGE_LIBVNCSERVER
+
+config BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG
+	bool "TightPNG encoding support"
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBPNG
+	help
+	  TightPNG encoding speeds up HTML5 based VNC clients like noVNC.
+
Quoted 8 lines

package/libvncserver/Config.in config BR2_PACKAGE_LIBVNCSERVER · line 18

Quoted 1 line
package/libvncserver/Config.in +1 -0
+	  http://wiki.qemu.org/VNC_Tight_PNG

I've tried to read a bit, but I don't really understand whether JPEG is absolutely necessary to get TightPNG support. The webpage you mention says "If the client indicates JPEG support by sending a JPEG quality pseudo-encoding, then the server can send JPEG, because PNG will only replace the basic compression type used in normal tight.", which seems to indicate that the JPEG support is only optional.

JPEG and PNG are both necesarry.

Libvncserver will only compile tight.c if HAVE_LIBJPEG

https://github.com/LibVNC/libvncserver/blob/master/libvncserver/Makefile.am#L49

And inside tight.c png is optional, jpeg is not.

Quoted 11 lines
Quoted 11 lines
(quoted diff) +1 -0
+endif
package/libvncserver/libvncserver.mk +0 -0
index b26d5b9..8479a62 100644
@@ -56,4 +56,10 @@ else
 LIBVNCSERVER_CONF_OPTS += --without-zlib
 endif
Quoted 5 lines

package/libvncserver/libvncserver.mk else · line 60

Quoted 2 lines
package/libvncserver/libvncserver.mk +2 -0
+ifeq ($(BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG),y)
+LIBVNCSERVER_DEPENDENCIES += libpng

So we don't really need JPEG support after all, since you don't depend on it?

JPEG is added by the existing code:

==
ifeq ($(BR2_PACKAGE_JPEG),y)
LIBVNCSERVER_DEPENDENCIES += jpeg
else
LIBVNCSERVER_CONF_OPTS += --without-jpeg
endif
==

Wasn't sure whether to touch that, was afraid that would change behavior for existing users.

Your sincerely,

Floris Bos

#4 lore raw

PATCH 2/2 libvncserver: add config option for tightpng encoding support

Dear Floris Bos,

Quoted 7 lines · Floris Bos

JPEG and PNG are both necesarry.

Libvncserver will only compile tight.c if HAVE_LIBJPEG

https://github.com/LibVNC/libvncserver/blob/master/libvncserver/Makefile.am#L49

And inside tight.c png is optional, jpeg is not.

Ok, so I believe we should rather do:

+config BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG
+ bool "TightPNG encoding support"
+ select BR2_PACKAGE_JPEG
+ select BR2_PACKAGE_LIBPNG
+ help
+ TightPNG encoding speeds up HTML5 based VNC clients like noVNC.
+
+ http://wiki.qemu.org/VNC_Tight_PNG

in Config.in (i.e as you did)

And then in libvncserver.mk, do:

ifeq ($(BR2_PACKAGE_LIBPNG),y)
LIBVNCSERVER_DEPENDENCIES += libpng
else
LIBVNCSERVER_CONF_OPTS += --without-png
endif

This way, people not using tightpng support but having libpng enabled will have PNG support in libvncserver.

Can you rework your patch in this direction?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#5 lore raw

PATCH 2/2 libvncserver: add config option for tightpng encoding support

Quoted 26 lines · Thomas Petazzoni

Dear Floris Bos,

Quoted 7 lines · Floris Bos

JPEG and PNG are both necesarry.

Libvncserver will only compile tight.c if HAVE_LIBJPEG

https://github.com/LibVNC/libvncserver/blob/master/libvncserver/Makefile.am#L49

And inside tight.c png is optional, jpeg is not.

Ok, so I believe we should rather do:

package/libvncserver/Config.in +8 -0
+config BR2_PACKAGE_LIBVNCSERVER_TIGHTPNG
+	bool "TightPNG encoding support"
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBPNG
+	help
+	  TightPNG encoding speeds up HTML5 based VNC clients like noVNC.
+
+	  http://wiki.qemu.org/VNC_Tight_PNG

in Config.in (i.e as you did)

And then in libvncserver.mk, do:

Quoted 8 lines

ifeq ($(BR2_PACKAGE_LIBPNG),y)
LIBVNCSERVER_DEPENDENCIES += libpng
else
LIBVNCSERVER_CONF_OPTS += --without-png
endif

This way, people not using tightpng support but having libpng enabled will have PNG support in libvncserver.

Do note that the only thing using PNG inside libvncserver is the TightPNG encoding.
Think it is a bit counter-inductive to give users TightPNG support, just because another package selected libpng, even though they chose not to select the TightPNG feature.

(Just like I believe it is counter-inductive that users are expected to know which dependencies are needed to get a specific feature they want, as seems to be the current case with many buildroot packages, which do not offer any feature options).

Signature · 3 lines
Yours sincerely,

Floris Bos
#6 lore raw

PATCH 2/2 libvncserver: add config option for tightpng encoding support

Dear Floris Bos,

Quoted 10 lines · Floris Bos

Do note that the only thing using PNG inside libvncserver is the TightPNG encoding.
Think it is a bit counter-inductive to give users TightPNG support, just because another package selected libpng, even though they chose not to select the TightPNG feature.

(Just like I believe it is counter-inductive that users are expected to know which dependencies are needed to get a specific feature they want, as seems to be the current case with many buildroot packages, which do not offer any feature options).

This topic has been the source of many discussions in the Buildroot community, and we're trying to find a balance between two options:

* Have sub-options in each package for all the various possible optional features they have. This makes it more explicit for users, but on the flip side generates a huge maintenance burden, as we would have a much much larger number of Config.in options to maintain.

* Make optional features automatically enabled. This is less explicit for users, but it is sometimes good (like if you have OpenSSL enabled, enable SSL support everywhere it is possible), and avoids creating zillions of Config.in options.

So generally, on a case by case basis, we decide which of the solution is the most appropriate. Sometimes the latter is good enough and avoids creating more Config.in options, sometimes the former is really necessary to make it explicit to the user what is happening. I don't think it is possible to settle on one or the other solution and apply this decision unconditionally to all packages.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#7 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

In reply to Floris Bos

Hi Floris,

Quoted 12 lines · Floris Bos
Signed-off-by Floris Bos <[email protected]>
---
 .../libvncserver-0001-CVE-2014-6051-6052.patch     |  85 ------------
 .../libvncserver-0002-CVE-2014-6053.patch          |  21 ---
 .../libvncserver-0003-CVE-2014-6054.patch          |  87 ------------
 .../libvncserver-0004-CVE-2014-6055.patch          | 150 ---------------------
 package/libvncserver/libvncserver.mk               |   5 +-
 5 files changed, 3 insertions(+), 345 deletions(-)
 delete mode 100644 package/libvncserver/libvncserver-0001-CVE-2014-6051-6052.patch
 delete mode 100644 package/libvncserver/libvncserver-0002-CVE-2014-6053.patch
 delete mode 100644 package/libvncserver/libvncserver-0003-CVE-2014-6054.patch
 delete mode 100644 package/libvncserver/libvncserver-0004-CVE-2014-6055.patch

[snip]

Quoted 9 lines
package/libvncserver/libvncserver.mk +0 -0
index 99d757b..b26d5b9 100644
@@ -4,13 +4,14 @@
 #
 ################################################################################

package/libvncserver/libvncserver.mk line 14

Quoted 10 lines
package/libvncserver/libvncserver.mk +3 -2
-LIBVNCSERVER_VERSION = 0.9.9
+LIBVNCSERVER_VERSION = 0.9.10
 LIBVNCSERVER_SOURCE = LibVNCServer-$(LIBVNCSERVER_VERSION).tar.gz
-LIBVNCSERVER_SITE = http://downloads.sourceforge.net/project/libvncserver/libvncserver/$(LIBVNCSERVER_VERSION)
+LIBVNCSERVER_SITE = https://github.com/LibVNC/libvncserver/archive
 LIBVNCSERVER_LICENSE = GPLv2+
 LIBVNCSERVER_LICENSE_FILES = COPYING
 LIBVNCSERVER_INSTALL_STAGING = YES
 LIBVNCSERVER_CONFIG_SCRIPTS = libvncserver-config
+LIBVNCSERVER_AUTORECONF = YES

Why is this needed? Please explain in a comment.

baruch

Quoted 2 lines
package/libvncserver/libvncserver.mk +0 -0
 # only used for examples
 LIBVNCSERVER_CONF_OPTS += --with-sdl-config=/bin/false
Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#8 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

Quoted 10 lines · Baruch Siach
Quoted 10 lines
package/libvncserver/libvncserver.mk +0 -0
index 99d757b..b26d5b9 100644
@@ -4,13 +4,14 @@
 #
 
 ################################################################################
Quoted 13 lines

package/libvncserver/libvncserver.mk line 14

Quoted 11 lines
package/libvncserver/libvncserver.mk +3 -2
-LIBVNCSERVER_VERSION = 0.9.9
+LIBVNCSERVER_VERSION = 0.9.10
 LIBVNCSERVER_SOURCE = LibVNCServer-$(LIBVNCSERVER_VERSION).tar.gz
-LIBVNCSERVER_SITE = 
 http://downloads.sourceforge.net/project/libvncserver/libvncserver/$(LIBVNCSERVER_VERSION)
+LIBVNCSERVER_SITE = https://github.com/LibVNC/libvncserver/archive
 LIBVNCSERVER_LICENSE = GPLv2+
 LIBVNCSERVER_LICENSE_FILES = COPYING
 LIBVNCSERVER_INSTALL_STAGING = YES
 LIBVNCSERVER_CONFIG_SCRIPTS = libvncserver-config
+LIBVNCSERVER_AUTORECONF = YES

Why is this needed? Please explain in a comment.

The autoreconf you mean?

No idea why exactly, but upstream no longer includes a ready-made configure script with the new release.
Since it is mentioned in their changelog ("Cleaned out the autotools build system which now uses autoreconf") I assume it is intentional, instead of overlooked.

Yours sincerely,

Floris Bos

#9 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

Floris, All,

On 2014-12-26 16:03 +0100, Floris Bos spake thusly:

Quoted 23 lines · Baruch Siach
Quoted 9 lines
Quoted 9 lines
package/libvncserver/libvncserver.mk +0 -0
index 99d757b..b26d5b9 100644
@@ -4,13 +4,14 @@
 #
 ################################################################################
Quoted 12 lines
Quoted 10 lines
package/libvncserver/libvncserver.mk +1 -1
-LIBVNCSERVER_VERSION = 0.9.9
+LIBVNCSERVER_VERSION = 0.9.10

LIBVNCSERVER_SOURCE = LibVNCServer-$(LIBVNCSERVER_VERSION).tar.gz

package/libvncserver/libvncserver.mk +1 -1
-LIBVNCSERVER_SITE = http://downloads.sourceforge.net/project/libvncserver/libvncserver/$(LIBVNCSERVER_VERSION)
+LIBVNCSERVER_SITE = https://github.com/LibVNC/libvncserver/archive

LIBVNCSERVER_LICENSE = GPLv2+
LIBVNCSERVER_LICENSE_FILES = COPYING
LIBVNCSERVER_INSTALL_STAGING = YES
LIBVNCSERVER_CONFIG_SCRIPTS = libvncserver-config
+LIBVNCSERVER_AUTORECONF = YES

Why is this needed? Please explain in a comment.

Quoted 1 line

The autoreconf you mean?

Yes.

It is not often that a release tarball does not contain pre-generated autotools files, so adding a comment saying so is required, like:

# Upstream decided to remove generated autotools files from the # tarball, so we need to generate it:
LIBVNCSERVER_AUTORECONF = YES

Quoted 5 lines

No idea why exactly, but upstream no longer includes a ready-made configure script with the new release.
Since it is mentioned in their changelog ("Cleaned out the autotools build system which now uses autoreconf") I assume it is intentional, instead of overlooked.

That's pretty much unusual not to bundle the generated configure. That they be removed from the repository is understandable, of course, but release tarballs usually have them, so users do not have to have the autotools development stuff just to build the package.

But, he... If upstream does not want to bundle it... :-/

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#10 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

In reply to Floris Bos

Dear Floris Bos,

Quoted 12 lines · Floris Bos
Signed-off-by Floris Bos <[email protected]>
---
 .../libvncserver-0001-CVE-2014-6051-6052.patch     |  85 ------------
 .../libvncserver-0002-CVE-2014-6053.patch          |  21 ---
 .../libvncserver-0003-CVE-2014-6054.patch          |  87 ------------
 .../libvncserver-0004-CVE-2014-6055.patch          | 150 ---------------------
 package/libvncserver/libvncserver.mk               |   5 +-
 5 files changed, 3 insertions(+), 345 deletions(-)
 delete mode 100644 package/libvncserver/libvncserver-0001-CVE-2014-6051-6052.patch
 delete mode 100644 package/libvncserver/libvncserver-0002-CVE-2014-6053.patch
 delete mode 100644 package/libvncserver/libvncserver-0003-CVE-2014-6054.patch
 delete mode 100644 package/libvncserver/libvncserver-0004-CVE-2014-6055.patch

Applied, after adding a comment about AUTORECONF = YES, and adding host-pkgconf to the dependencies, since configure.ac uses PKG_CHECK_MODULES
.
Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#11 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

In reply to Floris Bos

Dear Floris Bos,

Quoted 12 lines · Floris Bos
Signed-off-by Floris Bos <[email protected]>
---
 .../libvncserver-0001-CVE-2014-6051-6052.patch     |  85 ------------
 .../libvncserver-0002-CVE-2014-6053.patch          |  21 ---
 .../libvncserver-0003-CVE-2014-6054.patch          |  87 ------------
 .../libvncserver-0004-CVE-2014-6055.patch          | 150 ---------------------
 package/libvncserver/libvncserver.mk               |   5 +-
 5 files changed, 3 insertions(+), 345 deletions(-)
 delete mode 100644 package/libvncserver/libvncserver-0001-CVE-2014-6051-6052.patch
 delete mode 100644 package/libvncserver/libvncserver-0002-CVE-2014-6053.patch
 delete mode 100644 package/libvncserver/libvncserver-0003-CVE-2014-6054.patch
 delete mode 100644 package/libvncserver/libvncserver-0004-CVE-2014-6055.patch

This patch is causing a bunch of new build failures, like:

http://autobuild.buildroot.org/results/75a/75afaad317264fb3cca80fe82cfc5a786f7e42a3/build-end.log

Can you look into this and fix it?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#12 lore raw

PATCH 1/2 libvncserver: bump version to 0.9.10

Quoted 15 lines · Thomas Petazzoni

Dear Floris Bos,

Quoted 8 lines · Floris Bos
Signed-off-by Floris Bos <[email protected]>
---
  .../libvncserver-0001-CVE-2014-6051-6052.patch     |  85 ------------
  .../libvncserver-0002-CVE-2014-6053.patch          |  21 ---
  .../libvncserver-0003-CVE-2014-6054.patch          |  87 ------------
  .../libvncserver-0004-CVE-2014-6055.patch          | 150 ---------------------
  package/libvncserver/libvncserver.mk               |   5 +-
  5 files changed, 3 insertions(+), 345 deletions(-)
Quoted 4 lines

delete mode 100644 package/libvncserver/libvncserver-0001-CVE-2014-6051-6052.patch delete mode 100644 package/libvncserver/libvncserver-0002-CVE-2014-6053.patch delete mode 100644 package/libvncserver/libvncserver-0003-CVE-2014-6054.patch delete mode 100644 package/libvncserver/libvncserver-0004-CVE-2014-6055.patch

Quoted 5 lines

This patch is causing a bunch of new build failures, like:

http://autobuild.buildroot.org/results/75a/75afaad317264fb3cca80fe82cfc5a786f7e42a3/build-end.log

Can you look into this and fix it?

Doesn't get along with the version of libva shipped with buildroot. Will send in a patch that disables that.
(not using libva myself, so did not notice)

Yours sincerely,

Floris Bos