Support for SmPL ellipsis in logical expressions?
Dear Julia,
I have tried the following semantic filter approach out.
@safety_check_with_pointer@
identifier input, member, process, work;
statement is, es;
type input_type, return_type;
@@
return_type work(input_type * input)
{
... when any
(
* if (!input)
return ... ;
|
* if (unlikely(ZERO_OR_NULL_PTR(input)))
return ... ;
|
* if (!input || ... process(& input->member) ... )
return ... ;|
* if (input && ... process(& input->member) ... )
is
else
es
)
... when any
}
elfring at Sonne:~/Projekte/Coccinelle/janitor> spatch.opt -sp-file show_input_parameter_validation7.cocci ~/Projekte/Linux/next-patched/fs/kernfs/dir.cinit_defs_builtins: /usr/local/share/coccinelle/standard.h
293 300
Fatal error: exception Failure("minus: parse error: \n = File \"show_input_parameter_validation7.cocci\", line 16, column 20, charpos = 293\n around = 'process', whole content = * if (!input || ... process(& input->member) ... )\n")
Does the Coccinelle software not like my placement of the SmPL ellipsis within a condition specification?
Regards,
Markus
A message that is not in the archive (sent off-list or not yet received): alpine.DEB.2.10.1412291422340.2558@hadrien
Quoted 1 line
It has nothing particularly to do with a conditional.
Thanks for your quick feedback.
Quoted 1 line
|| has two arguments, both expressions.
That is clear.
Quoted 2 lines
If you want to describe a subterm of an expression, you have to put <+... ...+> around it.
I have tried to express the possibility that additional operators like "logical not" are optional in my semantic filter approach.
I try to find also function implementations which have got similar properties like the function "kernfs_put".
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/fs/kernfs/dir.c?id=9b053f3207e8887fed88162a339fdd4001abcdb2#n383
Regards,
Markus