Exynos: Move down common USB configuration

PATCH New Sjoerd Simons 2 participants 2 messages Dec 29, 2014 – Dec 30, 2014 Arm Samsung Exynos

Share & tools

Sjoerd Simons

author

2014-12-29 21:17 UTC #0 lore raw

PATCH v2 1/1 Exynos: Move down common USB configuration

USB is a pretty common feature on exynos 5 board, so it seems sensible to configure it directly from exynos5-common. As a side-effect this makes USB available from u-boot on exynos 5420 based boards.

While there enable support for common USB ethernet cards to make it more likely the default config allows booting for network and enable XHCI on SMDK5420 which has it defined in the dts but not in its config.

Signed-off-by Sjoerd Simons <[email protected]>

Acked-by Simon Glass <[email protected]>

---

Changes in v2: Rebased on u-boot-samsung (fb56435f504b40)

 include/configs/arndale.h           |  4 ----
 include/configs/exynos5-common.h    | 10 ++++++++++
 include/configs/exynos5250-common.h |  5 -----
 include/configs/exynos5420-common.h |  2 --
 include/configs/smdk5420.h          |  4 ++++
 5 files changed, 14 insertions(+), 11 deletions(-)

include/configs/arndale.h +0 -4

index 81e8a7c..6bd27a2 100644
@@ -24,10 +24,6 @@
 #define CONFIG_USB_EHCI
 #define CONFIG_USB_EHCI_EXYNOS
 
-#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
-#define CONFIG_USB_HOST_ETHER
-#define CONFIG_USB_ETHER_ASIX
-
 /* MMC SPL */
 #define CONFIG_EXYNOS_SPL

include/configs/exynos5-common.h +10 -0

index 8f9b780..ad63f3c 100644
@@ -174,6 +174,16 @@
 
 #define CONFIG_CMD_GPIO
 
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_STORAGE
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
+
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_ASIX
+#define CONFIG_USB_ETHER_SMSC95XX
+
 /* USB boot mode */
 #define CONFIG_USB_BOOTING
 #define EXYNOS_COPY_USB_FNPTR_ADDR	0x02020070

include/configs/exynos5250-common.h +0 -5

index a0107e8..6714313 100644
@@ -22,11 +22,6 @@
 
 #define CONFIG_SPL_MAX_FOOTPRINT	(14 * 1024)
 
-/* USB */
-#define CONFIG_CMD_USB
-#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
-#define CONFIG_USB_STORAGE
-
 #define CONFIG_SPL_TEXT_BASE	0x02023400
 
 #define CONFIG_IRAM_STACK	0x02050000

include/configs/exynos5420-common.h +0 -2

index 7322f33..fe72bd0 100644
@@ -38,6 +38,4 @@
 
 #define CONFIG_BOARD_REV_GPIO_COUNT	2
 
-#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
-
 #endif	/* __CONFIG_EXYNOS5420_H */

include/configs/smdk5420.h +4 -0

index 6b45948..61f582f 100644
@@ -34,6 +34,10 @@
 #define CONFIG_IDENT_STRING	" for SMDK5420"
 #define CONFIG_DEFAULT_CONSOLE		"console=ttySAC1,115200n8\0"
 
+/* USB */
+#define CONFIG_USB_XHCI
+#define CONFIG_USB_XHCI_EXYNOS
+
 /* DRAM Memory Banks */
 #define CONFIG_NR_DRAM_BANKS	7
 #define SDRAM_BANK_SIZE		(512UL << 20UL)	/* 512 MB */

Signature · 1 line

2.1.4

Minkyu Kang

2014-12-30 09:17 UTC #1 lore raw

PATCH v2 1/1 Exynos: Move down common USB configuration

Dear Sjoerd Simons,

Quoted 4 lines · Sjoerd Simons

USB is a pretty common feature on exynos 5 board, so it seems sensible to configure it directly from exynos5-common. As a side-effect this makes USB available from u-boot on exynos 5420 based boards.

Quoted 8 lines

While there enable support for common USB ethernet cards to make it more likely the default config allows booting for network and enable XHCI on SMDK5420 which has it defined in the dts but not in its config.
Signed-off-by Sjoerd Simons <[email protected]>
Acked-by Simon Glass <[email protected]>
---

applied to u-boot-samsung.

Thanks,
Minkyu Kang.