Skip to contentSkip to conversation

Question about moving code in amd-iommu.c

DISCUSSION nick 1 participant 1 message Jan 1, 2015

lore
Share & tools
lore

nick

author
#0 lore raw

Greetings Joerg,
I assume you wrote this code as the maintainer :
/* FIXME: Move this to PCI code */
#define PCI_PRI_TLP_OFF (1 << 15)

static bool pci_pri_tlp_required(struct pci_dev *pdev)

{
        u16 status;
        int pos;

        pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_PRI);
        if (!pos)
               return false;

        pci_read_config_word(pdev, pos + PCI_PRI_STATUS, &status);

        return (status & PCI_PRI_TLP_OFF) ? true : false;
}

I am wondering due to the fix me being rather value as to where to move this code. Have a Great New Year's,
Nick