Skip to contentSkip to conversation

iio: amplifiers: Fix checkpatch.pl warnings

PATCH Applied Roberta Dobrescu 2 participants 5 messages Dec 30, 2014 – Jan 1, 2015

Subsystems (3)
IIO Analog Devices IIO drivers Analog devices inc AD8366 driver
lore
Share & tools
lore

Roberta Dobrescu

author
#0 lore raw

cover iio: amplifiers: Fix checkpatch.pl warnings

This patchset fixes warnings detected using checkpatch.pl,
such as: prohibited space before ',' and wrong order for type specification.

Roberta Dobrescu (2):
iio: amplifiers: ad8366: Remove space before ','
iio: amplifiers: ad8366: Use right order for type specification

 drivers/iio/amplifiers/ad8366.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/2 iio: amplifiers: ad8366: Remove space before ','

This patch fixes the following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

Signed-off-by Roberta Dobrescu <[email protected]>
---
 drivers/iio/amplifiers/ad8366.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/amplifiers/ad8366.c +1 -1
index ba6f6a9..fce25a0 100644
@@ -166,7 +166,7 @@ static int ad8366_probe(struct spi_device *spi)
 	if (ret)
 		goto error_disable_reg;
 
-	ad8366_write(indio_dev, 0 , 0);
+	ad8366_write(indio_dev, 0, 0);
 
 	return 0;
Signature · 1 line
1.9.1
maintainer Applied
#2 lore raw

Re: [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ','

Quoted 4 lines · Roberta Dobrescu

This patch fixes the following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)

Signed-off-by Roberta Dobrescu <[email protected]>

Applied

Quoted 18 lines
---
 drivers/iio/amplifiers/ad8366.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/amplifiers/ad8366.c +1 -1
index ba6f6a9..fce25a0 100644
@@ -166,7 +166,7 @@ static int ad8366_probe(struct spi_device *spi)
 	if (ret)
 		goto error_disable_reg;
 
-	ad8366_write(indio_dev, 0 , 0);
+	ad8366_write(indio_dev, 0, 0);
 
 	return 0;
author
#3 lore raw

PATCH 2/2 iio: amplifiers: ad8366: Use right order for type specification

In reply to Roberta Dobrescu

This patch fixes the following checkpatch.pl warning:
WARNING: type 'char unsigned' should be specified in [[un]signed] [short|int|long|long long] order

Signed-off-by Roberta Dobrescu <[email protected]>
---
 drivers/iio/amplifiers/ad8366.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/amplifiers/ad8366.c +1 -1
index fce25a0..c0d364e 100644
@@ -31,7 +31,7 @@ struct ad8366_state {
 };
 
 static int ad8366_write(struct iio_dev *indio_dev,
-			unsigned char ch_a, char unsigned ch_b)
+			unsigned char ch_a, unsigned char ch_b)
 {
 	struct ad8366_state *st = iio_priv(indio_dev);
 	int ret;
Signature · 1 line
1.9.1
maintainer Applied
#4 lore raw

Re: [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification

Quoted 5 lines · Roberta Dobrescu

This patch fixes the following checkpatch.pl warning:
WARNING: type 'char unsigned' should be specified in [[un]signed] [short|int|long|long long] order

Signed-off-by Roberta Dobrescu <[email protected]>

Applied.

Quoted 18 lines
---
 drivers/iio/amplifiers/ad8366.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iio/amplifiers/ad8366.c +1 -1
index fce25a0..c0d364e 100644
@@ -31,7 +31,7 @@ struct ad8366_state {
 };
 
 static int ad8366_write(struct iio_dev *indio_dev,
-			unsigned char ch_a, char unsigned ch_b)
+			unsigned char ch_a, unsigned char ch_b)
 {
 	struct ad8366_state *st = iio_priv(indio_dev);
 	int ret;