1/1] Adding New Package: szip
PATCH 1/1 1/1] Adding New Package: szip
--- package/Config.in | 1 + package/szip/Config.in | 14 ++++++++++++++ package/szip/szip.mk | 13 +++++++++++++ 3 files changed, 28 insertions(+)
create mode 100644 package/szip/Config.in
create mode 100644 package/szip/szip.mk
package/Config.in +1 -0
@@ -599,6 +599,7 @@ menu "Compression and decompression" source "package/lzo/Config.in" source "package/snappy/Config.in" source "package/zlib/Config.in" + source "package/szip/Config.in" endmenu menu "Crypto"
package/szip/Config.in new file +4 -0
@@ -0,0 +1,14 @@ +config BR2_PACKAGE_SZIP + bool "szip" + help + Szip is an implementation of the extended-Rice lossless +
compression algorithm. + The Consultative Committee on Space Data
Systems (CCSDS) has
+ adopted the extended-Rice algorithm for international standards
+ for space applications[1,6,7]. Szip is reported to provide +
fast and effective compression, specifically for the EOS data +
generated by the NASA Earth Observatory System (EOS)[1]. + It was
originally developed at University of New Mexico (UNM)
+ and integrated with HDF4 by UNM researchers and developers.
+ + http://www.hdfgroup.org/doc_resource/SZIP
\ No newline at end of file
package/szip/szip.mk new file +13 -0
@@ -0,0 +1,13 @@ +################################################################################ +# +# szip +# +################################################################################ + +SZIP_VERSION = 2.1 +SZIP_SITE = http://www.hdfgroup.org/ftp/lib-external/szip/2.1/src +SZIP_LICENSE = szip license +SZIP_LICENSE_FILES = COPYING +SZIP_INSTALL_STAGING = YES + +$(eval $(autotools-package))
Signature · 1 line
2.1.0
PATCH 1/1 1/1] Adding New Package: szip
Dear Ernest L Williams,
Thanks! This looks a lot better! I could apply your patch and fix the issues, but let's try to bring it up to the good state to merge it with no change!
The first thing you could improve is the commit title, it should be just:
szip: new package
And then when generating the patch, do:
git format-patch --subject-prefix="PATCHvX"
where X is the version of your patch. There's no need to have something complicated like [[PATCH][REDO][New Pkg:szip] 1/1].
See below for some more comments.
Quoted 14 lines · Ernest L Williams
Signed-off-by Ernesto L. Williams Jr <[email protected]>--- package/Config.in | 1 + package/szip/Config.in | 14 ++++++++++++++ package/szip/szip.mk | 13 +++++++++++++ 3 files changed, 28 insertions(+)create mode 100644 package/szip/Config.in
create mode 100644package/szip/szip.mkpackage/Config.in +0
-0
package/Config.in menu "Compression and decompression" · line 602
Quoted 4 lines
package/Config.in +1
-0@@ -599,6 +599,7 @@ menu "Compression and decompression" source "package/lzo/Config.in" source "package/snappy/Config.in" source "package/zlib/Config.in" + source "package/szip/Config.in"
Entries should be sorted alphabetically.
package/szip/Config.in line 2
Quoted 8 lines
package/szip/Config.in new file +2
-0@@ -0,0 +1,14 @@ +config BR2_PACKAGE_SZIP + bool "szip"
Indentation should be one tab.
package/szip/Config.in
Quoted 11 lines
package/szip/Config.in new file +2
-0+ help + Szip is an implementation of the extended-Rice lossless +compression algorithm. + The Consultative Committee on Space Data
Systems (CCSDS) haspackage/szip/Config.in new file +2
-0+ adopted the extended-Rice algorithm for international standards + for space applications[1,6,7]. Szip is reported to provide +fast and effective compression, specifically for the EOS data +
generated by the NASA Earth Observatory System (EOS)[1]. + It was
originally developed at University of New Mexico (UNM)package/szip/Config.in new file +2
-0+ and integrated with HDF4 by UNM researchers and developers. + + http://www.hdfgroup.org/doc_resource/SZIP
Please send your patch with 'git send-email' and not with your e-mail client. Your e-mail wraps the lines, which is good for normal text, but doesn't work at all for patches.
Also the indentation for the help text is one tab + two spaces.
Quoted 1 line
\ No newline at end of file
Make sure to add an ending new line to this file.
Quoted 9 lines
package/szip/szip.mk new file +3
-0@@ -0,0 +1,13 @@ +################################################################################ +# +# szip
package/szip/szip.mk line 13
Quoted 10 lines
package/szip/szip.mk new file +10
-0+# +################################################################################ + +SZIP_VERSION = 2.1 +SZIP_SITE = http://www.hdfgroup.org/ftp/lib-external/szip/2.1/src +SZIP_LICENSE = szip license +SZIP_LICENSE_FILES = COPYING +SZIP_INSTALL_STAGING = YES + +$(eval $(autotools-package))
You could also improve this by adding a hash file, see
http://buildroot.org/downloads/manual/manual.html#adding-packages-hash.
Could you fix those issues and resend an updated version?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Williams Jr.
PATCH 1/1 1/1] Adding New Package: szip
Hi Thomas,
Sent from my iPhone
Quoted 11 lines · Thomas Petazzoni
Dear Ernest L Williams,
Thanks! This looks a lot better! I could apply your patch and fix the issues, but let's try to bring it up to the good state to merge it with no change!
The first thing you could improve is the commit title, it should be just:
Quoted 7 lines
szip: new package
And then when generating the patch, do:
git format-patch --subject-prefix="PATCHvX"where X is the version of your patch.
Sounds good
Will do,
Quoted 15 lines
There's no need to have something complicated like [[PATCH][REDO][New Pkg:szip] 1/1].
See below for some more comments.
Quoted 10 lines · Ernest L Williams
Signed-off-by Ernesto L. Williams Jr <[email protected]>--- package/Config.in | 1 + package/szip/Config.in | 14 ++++++++++++++ package/szip/szip.mk | 13 +++++++++++++ 3 files changed, 28 insertions(+) create mode 100644 package/szip/Config.in create mode 100644 package/szip/szip.mk
Quoted 11 lines
package/Config.in menu "Compression and decompression" · line 602
Quoted 9 lines
package/Config.in +1
-0@@ -599,6 +599,7 @@ menu "Compression and decompression" source "package/lzo/Config.in" source "package/snappy/Config.in" source "package/zlib/Config.in" + source "package/szip/Config.in"Entries should be sorted alphabetically.
Ah, you are referring to
"package/Config.in"
Will do
Quoted 11 lines
package/szip/Config.in line 2
Quoted 9 lines
package/szip/Config.in new file +2
-0@@ -0,0 +1,14 @@ +config BR2_PACKAGE_SZIP + bool "szip"Indentation should be one tab.
The file indeed has correct indentation but my email client destroys my formatting. :(
I will fix this
Quoted 13 lines
package/szip/Config.in
Quoted 12 lines
package/szip/Config.in new file +2
-0+ help + Szip is an implementation of the extended-Rice lossless +compression algorithm. + The Consultative Committee on Space Data
Systems (CCSDS) haspackage/szip/Config.in new file +2
-0+ adopted the extended-Rice algorithm for international standards + for space applications[1,6,7]. Szip is reported to provide +fast and effective compression, specifically for the EOS data +
generated by the NASA Earth Observatory System (EOS)[1]. + It was
originally developed at University of New Mexico (UNM)package/szip/Config.in new file +2
-0+ and integrated with HDF4 by UNM researchers and developers. + + http://www.hdfgroup.org/doc_resource/SZIP
Quoted 3 lines
Please send your patch with 'git send-email' and not with your e-mail client. Your e-mail wraps the lines, which is good for normal text, but doesn't work at all for patches.
My email client also screws up the
"Indentation". :(
Okay, I give in; I will setup send mail on my Fedora Box :)
Quoted 2 lines
Also the indentation for the help text is one tab + two spaces.
Using git send-email will resolve this
Quoted 4 lines
Quoted 2 lines
\ No newline at end of file
Make sure to add an ending new line to this file.
Will do
Quoted 15 lines
Quoted 15 lines
package/szip/szip.mk new file +8
-0@@ -0,0 +1,13 @@ +################################################################################ +# +# szip +# +################################################################################ + +SZIP_VERSION = 2.1 +SZIP_SITE = http://www.hdfgroup.org/ftp/lib-external/szip/2.1/src
Quoted 8 lines
package/szip/szip.mk line 13
Quoted 5 lines
package/szip/szip.mk new file +5
-0+SZIP_LICENSE = szip license +SZIP_LICENSE_FILES = COPYING +SZIP_INSTALL_STAGING = YES + +$(eval $(autotools-package))You could also improve this by adding a hash file, see
http://buildroot.org/downloads/manual/manual.html#adding-packages-hash.
Will do
Quoted 2 lines
Could you fix those issues and resend an updated version?
Sure, sounds good
Thanks for your help
Cheers
Ernesto
Quoted 8 lines
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com