Skip to contentSkip to conversation

sound: soc: soc-pcm: Remove useless varialbe 'i'

PATCH In review Chen Gang 2 participants 3 messages Jan 3, 2015

Subsystems (2)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 sound: soc: soc-pcm: Remove useless varialbe 'i'

'i' is useless in soc_pcm_set_msb(), so remove it, the related warning (with allmodconfig under s390):

CC [M] sound/soc/soc-pcm.o
sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]

    int ret, i;
             ^
---
 sound/soc/soc-pcm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-pcm.c +1 -1
index d6e8d6b..6b0136e 100644
@@ -304,7 +304,7 @@ static bool soc_pcm_has_symmetry(struct snd_pcm_substream *substream)
 static void soc_pcm_set_msb(struct snd_pcm_substream *substream, int bits)
 {
 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
-	int ret, i;
+	int ret;
 
 	if (!bits)
 		return;
Signature · 1 line
1.7.9.5
#1 lore raw

At Sat, 03 Jan 2015 17:45:57 +0800,

Quoted 9 lines · Chen Gang

'i' is useless in soc_pcm_set_msb(), so remove it, the related warning (with allmodconfig under s390):

CC [M] sound/soc/soc-pcm.o
sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]

    int ret, i;
             ^

Thanks, but this was already fixed.

Takashi

Quoted 22 lines
---
 sound/soc/soc-pcm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-pcm.c +1 -1
index d6e8d6b..6b0136e 100644
@@ -304,7 +304,7 @@ static bool soc_pcm_has_symmetry(struct snd_pcm_substream *substream)
 static void soc_pcm_set_msb(struct snd_pcm_substream *substream, int bits)
 {
 	struct snd_soc_pcm_runtime *rtd = substream->private_data;
-	int ret, i;
+	int ret;
 
 	if (!bits)
 		return;
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 6 lines · Takashi Iwai

At Sat, 03 Jan 2015 17:45:57 +0800,

Quoted 4 lines · Chen Gang

'i' is useless in soc_pcm_set_msb(), so remove it, the related warning (with allmodconfig under s390):

Quoted 8 lines
Quoted 5 lines

CC [M] sound/soc/soc-pcm.o
sound/soc/soc-pcm.c: In function 'soc_pcm_set_msb':
sound/soc/soc-pcm.c:307:11: warning: unused variable 'i' [-Wunused-variable]

    int ret, i;
             ^

Thanks, but this was already fixed.

OK, thanks.

Signature · 3 lines
Chen Gang

Open, share, and attitude like air, water, and life which God blessed