Skip to contentSkip to conversation

ext4_da_update_reserve_space warning fix not in stable

DISCUSSION Josh Hunt 3 participants 7 messages Jan 7, 2015 – Jan 8, 2015

lore
Share & tools
lore

Josh Hunt

author
#0 lore raw

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363 ext4_da_update_reserve_space+0x261/0x280 [ext4]()

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Thanks
Josh

#1 lore raw
Quoted 11 lines · Josh Hunt

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363

ext4_da_update_reserve_space+0x261/0x280 [ext4]()

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

Quoted 4 lines

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Since the problem is relatively harmless, I think we didn't bother
porting it to 3.10. Feel free to port those two patches to 3.10 and submit them to [email protected].

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
author
#2 lore raw
Quoted 12 lines · Jan Kara
Quoted 11 lines · Josh Hunt

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363

ext4_da_update_reserve_space+0x261/0x280 [ext4]()

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

Quoted 7 lines
Quoted 4 lines

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Since the problem is relatively harmless, I think we didn't bother
porting it to 3.10. Feel free to port those two patches to 3.10 and submit them to [email protected].

Thanks for the reply Jan.

I've ported them locally to 3.10 and they seem to apply cleanly as-is. I can submit the request to stable as long as you believe there's no harm in doing so, or any other dependency which may be required. My testing of a patched 3.10 with the two above patches shows the warning no longer triggers as you report in your commit log.

Thanks
Josh

#3 lore raw
Quoted 21 lines · Josh Hunt
Quoted 12 lines · Jan Kara
Quoted 11 lines · Josh Hunt

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363

ext4_da_update_reserve_space+0x261/0x280 [ext4]()

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

Quoted 7 lines
Quoted 4 lines

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Since the problem is relatively harmless, I think we didn't bother
porting it to 3.10. Feel free to port those two patches to 3.10 and submit them to [email protected].

Quoted 8 lines

Thanks for the reply Jan.

I've ported them locally to 3.10 and they seem to apply cleanly as-is. I can submit the request to stable as long as you believe there's no harm in doing so, or any other dependency which may be required. My testing of a patched 3.10 with the two above patches shows the warning no longer triggers as you report in your commit log.

I'm not aware of any reason why these patches shouldn't be in 3.10 stable
so just go ahead. Thanks!

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
author
#4 lore raw
Quoted 24 lines · Jan Kara
Quoted 23 lines · Josh Hunt
Quoted 12 lines · Jan Kara
Quoted 11 lines · Josh Hunt

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363

ext4_da_update_reserve_space+0x261/0x280 [ext4]()

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

Quoted 7 lines
Quoted 4 lines

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Since the problem is relatively harmless, I think we didn't bother
porting it to 3.10. Feel free to port those two patches to 3.10 and submit them to [email protected].

Thanks for the reply Jan.

Quoted 8 lines
Quoted 6 lines

I've ported them locally to 3.10 and they seem to apply cleanly as-is. I can submit the request to stable as long as you believe there's no harm in doing so, or any other dependency which may be required. My testing of a patched 3.10 with the two above patches shows the warning no longer triggers as you report in your commit log.

I'm not aware of any reason why these patches shouldn't be in 3.10 stable
so just go ahead. Thanks!

It looks like there is a small merge conflict in one of the patches. I will respin it and submit to stable cc'ing you guys.

Thanks
Josh

#5 lore raw
In reply to Josh Hunt
Quoted 5 lines · Josh Hunt

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363

ext4_da_update_reserve_space+0x261/0x280 [ext4]()

Quoted 8 lines

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Have you tried backporting these two commits, and does it fix the problem for you?

I think it was mostly an oversight, although it might have also been my thinking that it was only a warning, so it wasn't that critical to backport. To be honest, I can't really recall exactly what happened with that patch at this point.

If it does seen to work for you, I'm happy to suggest to the 3.10 stable kernel maintainers to have it be backported.

- Ted

author
#6 lore raw
Quoted 11 lines · Theodore Ts'o
Quoted 10 lines · Josh Hunt

We are hitting the following warning in the field pretty frequently on the latest 3.10 stable kernel:

[11708.763067] WARNING: at fs/ext4/inode.c:363

ext4_da_update_reserve_space+0x261/0x280 [ext4]()

The issue was resolved via "ext4: fix warning in ext4_da_update_reserve_space()" (7d7345322d60ed), but the fix was not submitted as a stable update for 3.10. I was wondering if there's a reason why this was not done, or if it was just overlooked?

Quoted 6 lines
Quoted 3 lines

The patch appears to have a dependency on "quota: provide interface for readding allocated space into reserved space" (1c8924eb106c1ac), so I think both would need to be submitted if you feel it's possible.

Have you tried backporting these two commits, and does it fix the problem for you?

Yeah I backported both. They both apply cleanly to 3.10 iirc. I will report back if they do not.

Yes, moving both of these to 3.10 fixes the problem for me.

Quoted 8 lines

I think it was mostly an oversight, although it might have also been my thinking that it was only a warning, so it wasn't that critical to backport. To be honest, I can't really recall exactly what happened with that patch at this point.

If it does seen to work for you, I'm happy to suggest to the 3.10 stable kernel maintainers to have it be backported.

That would be great, thanks!

Josh