[3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC

Regression Joseph Salisbury 2 participants 9 messages Jan 7, 2015 – Jan 8, 2015

Subsystems (3)

Stable branch DRM drivers Radeon and amdgpu DRM drivers

lore

Share & tools

lore

Joseph Salisbury

author

2015-01-07 22:51 UTC #0 lore raw

Hi Alexander,

A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit c08abf11900e19b14dd3a0cc3d105bd74519cd18

Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400

drm/radeon: re-enable dpm by default on BTC

The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.

I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?

Thanks,

Joe

[0] http://pad.lv/1386534

Deucher, Alexander

maintainer

2015-01-08 02:51 UTC #1 lore raw

Quoted 19 lines

-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400

Quoted 9 lines

drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?

Does revering b2dccf24e77 help? I'd hate to revert this patch because it disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board.

Alex

Quoted 6 lines

Thanks,
Joe
[0] http://pad.lv/1386534

Joseph Salisbury

author

2015-01-08 16:12 UTC #2 lore raw

Quoted 20 lines · Alexander

Quoted 20 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC

Quoted 8 lines

Quoted 7 lines
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Does revering b2dccf24e77 help? I'd hate to revert this patch because it disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board.

We'll test and let you know. Thanks for the feedback, Alex!

Quoted 8 lines

Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534

Joseph Salisbury

author

2015-01-08 16:25 UTC #3 lore raw

In reply to Deucher, Alexander

Quoted 20 lines · Alexander

Quoted 20 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC

Quoted 8 lines

Quoted 7 lines
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Does revering b2dccf24e77 help? I'd hate to revert this patch because it disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board.

Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not cc'd to stable. We are also seeing this issue in the 3.13.y stable kernel, which does not have commit b2dccf24e77 applied. However, we can test reverting it in mainline?

Quoted 8 lines

Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534

Deucher, Alexander

maintainer

2015-01-08 17:48 UTC #4 lore raw

Quoted 37 lines

-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 11:26 AM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Quoted 7 lines · Alexander
Quoted 7 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
by
Quoted 20 lines
Quoted 20 lines
default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?

Quoted 7 lines

Quoted 1 line
Does revering b2dccf24e77 help? I'd hate to revert this patch because it
disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board. Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not cc'd to stable. We are also seeing this issue in the 3.13.y stable kernel, which does not have commit b2dccf24e77 applied. However, we can test reverting it in mainline?

Nope. Won't make a difference. The attached patch adds a quirk list for dpm which will fix the issue for the affected boards.

Alex

Quoted 9 lines

Quoted 9 lines
Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534

From 17199f4c6db21d58163e60538de8585a4e1b137c Mon Sep 17 00:00:00 2001
From: Alex Deucher <[email protected]>
Date: Thu, 8 Jan 2015 10:46:33 -0500
Subject: [PATCH] drm/radeon: add a dpm quirk list

Disable dpm on certain problematic boards rather than disabling dpm for the entire chip family since most boards work fine.

Signed-off-by Alex Deucher <[email protected]>

Cc [email protected]

---
 drivers/gpu/drm/radeon/radeon_pm.c | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

drivers/gpu/drm/radeon/radeon_pm.c +33 -0

index 32522cc..f7da8fe 100644
@@ -1287,8 +1287,39 @@ dpm_failed:
 	return ret;
 }
 
+struct radeon_dpm_quirk {
+	u32 chip_vendor;
+	u32 chip_device;
+	u32 subsys_vendor;
+	u32 subsys_device;
+};
+
+/* cards with dpm stability problems */
+static struct radeon_dpm_quirk radeon_dpm_quirk_list[] = {
+	/* TURKS - https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1386534 */
+	{ PCI_VENDOR_ID_ATI, 0x6759, 0x1682, 0x3195 },
+	/* TURKS - https://bugzilla.kernel.org/show_bug.cgi?id=83731 */
+	{ PCI_VENDOR_ID_ATI, 0x6840, 0x1179, 0xfb81 },
+	{ 0, 0, 0, 0 },
+};
+
 int radeon_pm_init(struct radeon_device *rdev)
 {
+	struct radeon_dpm_quirk *p = radeon_dpm_quirk_list;
+	bool disable_dpm = false;
+
+	/* Apply dpm quirks */
+	while (p && p->chip_device != 0) {
+		if (rdev->pdev->vendor == p->chip_vendor &&
+		    rdev->pdev->device == p->chip_device &&
+		    rdev->pdev->subsystem_vendor == p->subsys_vendor &&
+		    rdev->pdev->subsystem_device == p->subsys_device) {
+			disable_dpm = true;
+			break;
+		}
+		++p;
+	}
+
 	/* enable dpm on rv6xx+ */
 	switch (rdev->family) {
 	case CHIP_RV610:

@@ -1344,6 +1375,8 @@ int radeon_pm_init(struct radeon_device *rdev)
 			 (!(rdev->flags & RADEON_IS_IGP)) &&
 			 (!rdev->smc_fw))
 			rdev->pm.pm_method = PM_METHOD_PROFILE;
+		else if (disable_dpm && (radeon_dpm == -1))
+			rdev->pm.pm_method = PM_METHOD_PROFILE;
 		else if (radeon_dpm == 0)
 			rdev->pm.pm_method = PM_METHOD_PROFILE;
 		else

Signature · 1 line

1.8.3.1

Joseph Salisbury

author

2015-01-08 18:00 UTC #5 lore raw

Quoted 43 lines · Alexander

Quoted 36 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 11:26 AM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Quoted 6 lines · Alexander
Quoted 6 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
by
Quoted 20 lines
Quoted 20 lines
default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Quoted 7 lines
Quoted 1 line
Does revering b2dccf24e77 help? I'd hate to revert this patch because it
disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board. Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not cc'd to stable. We are also seeing this issue in the 3.13.y stable kernel, which does not have commit b2dccf24e77 applied. However, we can test reverting it in mainline?

Quoted 3 lines

Nope. Won't make a difference. The attached patch adds a quirk list for dpm which will fix the issue for the affected boards.
Alex

Great. Thanks so much for the assistance, Alex! I'll have the patch tested and post some feedback.

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534

Joseph Salisbury

author

2015-01-08 21:58 UTC #6 lore raw

In reply to Deucher, Alexander

Quoted 43 lines · Alexander

Quoted 36 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 11:26 AM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Quoted 6 lines · Alexander
Quoted 6 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
by
Quoted 20 lines
Quoted 20 lines
default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Quoted 7 lines
Quoted 1 line
Does revering b2dccf24e77 help? I'd hate to revert this patch because it
disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board. Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not cc'd to stable. We are also seeing this issue in the 3.13.y stable kernel, which does not have commit b2dccf24e77 applied. However, we can test reverting it in mainline?

Quoted 3 lines

Nope. Won't make a difference. The attached patch adds a quirk list for dpm which will fix the issue for the affected boards.
Alex

Thanks again for the patch, Alex. The bug reporter has tested a 3.16 kernel with the patch and says it fixes the bug.

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534

Deucher, Alexander

maintainer

2015-01-08 22:00 UTC #7 lore raw

Quoted 56 lines

-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 4:58 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Quoted 6 lines · Alexander
Quoted 6 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 11:26 AM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
dpm
Quoted 8 lines
Quoted 8 lines
by default on BTC
Quoted 5 lines · Alexander
Quoted 5 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-
devel
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
dpm
Quoted 7 lines
Quoted 7 lines
by
Quoted 6 lines
Quoted 6 lines
default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this
bug:
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Does revering b2dccf24e77 help? I'd hate to revert this patch because it
disables power management for a whole family of chips. If it doesn't help
I'd
Quoted 4 lines
Quoted 4 lines
prefer to just add a quirk to disable it for the specific problematic board. Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not cc'd to stable. We are also seeing this issue in the 3.13.y stable kernel, which does not have commit b2dccf24e77 applied. However, we

Quoted 8 lines

can
Quoted 2 lines
Quoted 1 line
test reverting it in mainline?
Nope. Won't make a difference. The attached patch adds a quirk list for
dpm which will fix the issue for the affected boards.
Quoted 2 lines
Alex
Thanks again for the patch, Alex. The bug reporter has tested a 3.16 kernel with the patch and says it fixes the bug.

I'll queue it up for 3.19-fixes and cc stable.

Thanks,

Alex

Quoted 10 lines

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534

Joseph Salisbury

author

2015-01-08 22:11 UTC #8 lore raw

Quoted 55 lines · Alexander

Quoted 55 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 4:58 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
Quoted 6 lines · Alexander
Quoted 6 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, January 08, 2015 11:26 AM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-devel
Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
dpm
Quoted 8 lines
Quoted 8 lines
by default on BTC
Quoted 5 lines · Alexander
Quoted 5 lines
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Wednesday, January 07, 2015 5:51 PM
To: Deucher, Alexander
Cc: [email protected]; LKML; Koenig, Christian; David Airlie; dri-
devel
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
dpm
Quoted 7 lines
Quoted 7 lines
by
Quoted 6 lines
Quoted 6 lines
default on BTC
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this
bug:
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <[email protected]>
Date:   Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in current mainline. It has also made it's way into the stable releases.
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Quoted 4 lines
I was hoping to get your feedback, since you are the patch author. Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Does revering b2dccf24e77 help? I'd hate to revert this patch because it
disables power management for a whole family of chips. If it doesn't help
I'd
Quoted 4 lines
Quoted 4 lines
prefer to just add a quirk to disable it for the specific problematic board. Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not cc'd to stable. We are also seeing this issue in the 3.13.y stable kernel, which does not have commit b2dccf24e77 applied. However, we

Quoted 8 lines

Quoted 7 lines
can
Quoted 2 lines
Quoted 1 line
test reverting it in mainline?
Nope. Won't make a difference. The attached patch adds a quirk list for
dpm which will fix the issue for the affected boards.
Quoted 1 line
Alex
Thanks again for the patch, Alex. The bug reporter has tested a 3.16 kernel with the patch and says it fixes the bug.
I'll queue it up for 3.19-fixes and cc stable.

Great. Thanks, again!

Quoted 12 lines

Thanks,
Alex
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Alex
Quoted 5 lines
Thanks,
Joe
[0] http://pad.lv/1386534