Skip to contentSkip to conversation

dmaengine: at_hdmac: declare slave capabilities

PATCH New Ludovic Desroches 4 participants 4 messages Jan 6, 2015 – Jan 13, 2015

Subsystems (2)
dmaengine Microchip AT91 DMA drivers
lore
Share & tools
lore

Ludovic Desroches

author
#0 lore raw

PATCH 1/1 dmaengine: at_hdmac: declare slave capabilities

Declare slave capabilities to suppress "this driver doesn't support generic slave capabilities reporting" warning.

Signed-off-by Ludovic Desroches <[email protected]>
---
 drivers/dma/at_hdmac.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/dma/at_hdmac.c +9 -0
index 86450b3..1e1a4c5 100644
@@ -42,6 +42,11 @@
 #define	ATC_DEFAULT_CFG		(ATC_FIFOCFG_HALFFIFO)
 #define	ATC_DEFAULT_CTRLB	(ATC_SIF(AT_DMA_MEM_IF) \
 				|ATC_DIF(AT_DMA_MEM_IF))
+#define ATC_DMA_BUSWIDTHS\
+	(BIT(DMA_SLAVE_BUSWIDTH_UNDEFINED) |\
+	BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) |\
+	BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) |\
+	BIT(DMA_SLAVE_BUSWIDTH_4_BYTES))
 
 /*
  * Initial number of descriptors to allocate for each channel. This could

@@ -1531,6 +1536,10 @@ static int __init at_dma_probe(struct platform_device *pdev)
 		atdma->dma_common.device_pause = atc_pause;
 		atdma->dma_common.device_resume = atc_resume;
 		atdma->dma_common.device_terminate_all = atc_terminate_all;
+		atdma->dma_common.src_addr_widths = ATC_DMA_BUSWIDTHS;
+		atdma->dma_common.dst_addr_widths = ATC_DMA_BUSWIDTHS;
+		atdma->dma_common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
+		atdma->dma_common.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
 	}
 
 	dma_writel(atdma, EN, AT_DMA_ENABLE);
Signature · 1 line
2.2.0
#1 lore raw

PATCH 1/1 dmaengine: at_hdmac: declare slave capabilities

Quoted 4 lines · Ludovic Desroches

Declare slave capabilities to suppress "this driver doesn't support generic slave capabilities reporting" warning.

Signed-off-by Ludovic Desroches <[email protected]>
Acked-by Maxime Ripard <[email protected]>

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150109/8d3367a3/attachment.sig>
#2 lore raw

PATCH 1/1 dmaengine: at_hdmac: declare slave capabilities

In reply to Ludovic Desroches

Le 06/01/2015 17:36, Ludovic Desroches a ?crit :

Quoted 4 lines

Declare slave capabilities to suppress "this driver doesn't support generic slave capabilities reporting" warning.

Signed-off-by Ludovic Desroches <[email protected]>

Okay:

Acked-by Nicolas Ferre <[email protected]>

Thanks Ludovic.
Bye.

Quoted 32 lines
---
 drivers/dma/at_hdmac.c | 9 +++++++++
 1 file changed, 9 insertions(+)
drivers/dma/at_hdmac.c +9 -0
index 86450b3..1e1a4c5 100644
@@ -42,6 +42,11 @@
 #define	ATC_DEFAULT_CFG		(ATC_FIFOCFG_HALFFIFO)
 #define	ATC_DEFAULT_CTRLB	(ATC_SIF(AT_DMA_MEM_IF) \
 				|ATC_DIF(AT_DMA_MEM_IF))
+#define ATC_DMA_BUSWIDTHS\
+	(BIT(DMA_SLAVE_BUSWIDTH_UNDEFINED) |\
+	BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) |\
+	BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) |\
+	BIT(DMA_SLAVE_BUSWIDTH_4_BYTES))
 
 /*
  * Initial number of descriptors to allocate for each channel. This could

@@ -1531,6 +1536,10 @@ static int __init at_dma_probe(struct platform_device *pdev)
 		atdma->dma_common.device_pause = atc_pause;
 		atdma->dma_common.device_resume = atc_resume;
 		atdma->dma_common.device_terminate_all = atc_terminate_all;
+		atdma->dma_common.src_addr_widths = ATC_DMA_BUSWIDTHS;
+		atdma->dma_common.dst_addr_widths = ATC_DMA_BUSWIDTHS;
+		atdma->dma_common.directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
+		atdma->dma_common.residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
 	}
 
 	dma_writel(atdma, EN, AT_DMA_ENABLE);
Signature · 1 line
Nicolas Ferre
Applied
#3 lore raw

PATCH 1/1 dmaengine: at_hdmac: declare slave capabilities

In reply to Ludovic Desroches
Quoted 3 lines · Ludovic Desroches

Declare slave capabilities to suppress "this driver doesn't support generic slave capabilities reporting" warning.

Applied, thanks

Signature · 1 line
~Vinod