Skip to contentSkip to conversation

ARM: at91/dt: sam9263: Add missing clocks to lcdc node

PATCH New Alexander Stein 3 participants 3 messages Dec 5, 2014 – Jan 12, 2015

Subsystems (2)
Device tree bindings Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Alexander Stein

author
#0 lore raw

PATCH 1/1 ARM: at91/dt: sam9263: Add missing clocks to lcdc node

atmel_lcdfb needs also uses hclk clock, but AT91SAM9263 doesn't have that specific clock, so use lcd_clk twice. The same is done in arch/arm/mach-at91/at91sam9263.c

Signed-off-by Alexander Stein <[email protected]>
---
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9263.dtsi +2 -0
index 635f871..7989756 100644
@@ -932,6 +932,8 @@
 			interrupts = <26 IRQ_TYPE_LEVEL_HIGH 3>;
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_fb>;
+			clocks = <&lcd_clk>, <&lcd_clk>;
+			clock-names = "lcdc_clk", "hclk";
 			status = "disabled";
 		};
Signature · 1 line
2.2.0
#1 lore raw

PATCH 1/1 ARM: at91/dt: sam9263: Add missing clocks to lcdc node

Quoted 2 lines · Alexander Stein

atmel_lcdfb needs also uses hclk clock, but AT91SAM9263 doesn't have that specific clock, so use lcd_clk twice. The same is done in

I would say "was done" ;)

Quoted 3 lines

arch/arm/mach-at91/at91sam9263.c

Signed-off-by Alexander Stein <[email protected]>
Acked-by Alexandre Belloni <[email protected]>
Quoted 25 lines
---
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9263.dtsi +2 -0
index 635f871..7989756 100644
@@ -932,6 +932,8 @@
 			interrupts = <26 IRQ_TYPE_LEVEL_HIGH 3>;
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_fb>;
+			clocks = <&lcd_clk>, <&lcd_clk>;
+			clock-names = "lcdc_clk", "hclk";
 			status = "disabled";
 		};
Signature · 7 lines
2.2.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 ARM: at91/dt: sam9263: Add missing clocks to lcdc node

In reply to Alexander Stein

Le 05/12/2014 14:31, Alexander Stein a ?crit :

Quoted 5 lines

atmel_lcdfb needs also uses hclk clock, but AT91SAM9263 doesn't have that specific clock, so use lcd_clk twice. The same is done in arch/arm/mach-at91/at91sam9263.c

Signed-off-by Alexander Stein <[email protected]>
Acked-by Nicolas Ferre <[email protected]>

With modification by Alexandre, stacked on at91-3.19-fixes. Thanks, bye.

Quoted 18 lines
---
 arch/arm/boot/dts/at91sam9263.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/at91sam9263.dtsi +2 -0
index 635f871..7989756 100644
@@ -932,6 +932,8 @@
 			interrupts = <26 IRQ_TYPE_LEVEL_HIGH 3>;
 			pinctrl-names = "default";
 			pinctrl-0 = <&pinctrl_fb>;
+			clocks = <&lcd_clk>, <&lcd_clk>;
+			clock-names = "lcdc_clk", "hclk";
 			status = "disabled";
 		};
Signature · 1 line
Nicolas Ferre