Skip to contentSkip to conversation

gfs2: fix sprintf format specifier

PATCH New alex chen 2 participants 2 messages Jan 12, 2015 – Jan 13, 2015 GFS2 file system

lore
Share & tools
lore

alex chen

author
#0 lore raw

PATCH 1/1 gfs2: fix sprintf format specifier

Sprintf format specifier "%d" and "%u" are mixed up in gfs2_recovery_done() and freeze_show(). So correct them.

---
 fs/gfs2/recovery.c | 2 +-
 fs/gfs2/sys.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
fs/gfs2/recovery.c +1 -1
index 573bd3b..1b64577 100644
@@ -439,7 +439,7 @@ static void gfs2_recovery_done(struct gfs2_sbd *sdp, unsigned int jid,
 
         ls->ls_recover_jid_done = jid;
         ls->ls_recover_jid_status = message;
-	sprintf(env_jid, "JID=%d", jid);
+	sprintf(env_jid, "JID=%u", jid);
 	sprintf(env_status, "RECOVERY=%s",
 		message == LM_RD_SUCCESS ? "Done" : "Failed");
         kobject_uevent_env(&sdp->sd_kobj, KOBJ_CHANGE, envp);
fs/gfs2/sys.c +1 -1
index 3ab566b..ae8e881 100644
@@ -96,7 +96,7 @@ static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf)
 	struct super_block *sb = sdp->sd_vfs;
 	int frozen = (sb->s_writers.frozen == SB_UNFROZEN) ? 0 : 1;
 
-	return snprintf(buf, PAGE_SIZE, "%u\n", frozen);
+	return snprintf(buf, PAGE_SIZE, "%d\n", frozen);
 }
 
 static ssize_t freeze_store(struct gfs2_sbd *sdp, const char *buf, size_t len)
Signature · 1 line
1.8.4.3
#1 lore raw

PATCH 1/1 gfs2: fix sprintf format specifier

Hi,

Quoted 5 lines · alex chen

Sprintf format specifier "%d" and "%u" are mixed up in gfs2_recovery_done() and freeze_show(). So correct them.

Now in the GFS2 -nmw tree. Thanks,

Steve.

Quoted 31 lines
---
  fs/gfs2/recovery.c | 2 +-
  fs/gfs2/sys.c      | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)
fs/gfs2/recovery.c +1 -1
index 573bd3b..1b64577 100644
@@ -439,7 +439,7 @@ static void gfs2_recovery_done(struct gfs2_sbd *sdp, unsigned int jid,
 
          ls->ls_recover_jid_done = jid;
          ls->ls_recover_jid_status = message;
-	sprintf(env_jid, "JID=%d", jid);
+	sprintf(env_jid, "JID=%u", jid);
  	sprintf(env_status, "RECOVERY=%s",
  		message == LM_RD_SUCCESS ? "Done" : "Failed");
          kobject_uevent_env(&sdp->sd_kobj, KOBJ_CHANGE, envp);
fs/gfs2/sys.c +1 -1
index 3ab566b..ae8e881 100644
@@ -96,7 +96,7 @@ static ssize_t freeze_show(struct gfs2_sbd *sdp, char *buf)
  	struct super_block *sb = sdp->sd_vfs;
  	int frozen = (sb->s_writers.frozen == SB_UNFROZEN) ? 0 : 1;
 
-	return snprintf(buf, PAGE_SIZE, "%u\n", frozen);
+	return snprintf(buf, PAGE_SIZE, "%d\n", frozen);
  }
 
  static ssize_t freeze_store(struct gfs2_sbd *sdp, const char *buf, size_t len)