Skip to contentSkip to conversation

ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi

PATCH New Hans de Goede 3 participants 5 messages Jan 13, 2015

Subsystems (2)
Device tree bindings Arm/Allwinner sunXi SoC support
lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/2 ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi

The A23 has the same lradc controller as previous Allwinner SoCs.

Signed-off-by Hans de Goede <[email protected]>
---
 arch/arm/boot/dts/sun8i-a23.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/sun8i-a23.dtsi +7 -0
index a31842d..c2ceafb 100644
@@ -419,6 +419,13 @@
 			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
 		};
 
+		lradc: lradc at 01c22800 {
+			compatible = "allwinner,sun4i-a10-lradc-keys";
+			reg = <0x01c22800 0x100>;
+			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			status = "disabled";
+		};
+
 		uart0: serial at 01c28000 {
 			compatible = "snps,dw-apb-uart";
 			reg = <0x01c28000 0x400>;
Signature · 1 line
2.1.0
author
#1 lore raw

PATCH 2/2 ARM: dts: sun8i: Enable lradc on a23-ippo-q8h-v5

The a23-ippo-q8h tablets have volume up/down buttons using the lradc. This has been tested on both a v5 and a v1.2 tablet.

Tested-by Chen-Yu Tsai <[email protected]>
Signed-off-by Hans de Goede <[email protected]>
---
 arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/sun8i-a23-ippo-q8h-v5.dts +20 -0
index 1da31d0..623573e 100644
@@ -52,6 +52,7 @@
 #include "sunxi-common-regulators.dtsi"
 
 #include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
 #include <dt-bindings/pinctrl/sun4i-a10.h>
 
 / {

@@ -86,6 +87,25 @@
 			};
 		};
 
+		lradc: lradc at 01c22800 {
+			vref-supply = <&reg_vcc3v0>;
+			status = "okay";
+
+			button at 200 {
+				label = "Volume Up";
+				linux,code = <KEY_VOLUMEUP>;
+				channel = <0>;
+				voltage = <200000>;
+			};
+
+			button at 400 {
+				label = "Volume Down";
+				linux,code = <KEY_VOLUMEDOWN>;
+				channel = <0>;
+				voltage = <400000>;
+			};
+		};
+
 		i2c0: i2c at 01c2ac00 {
 			pinctrl-names = "default";
 			pinctrl-0 = <&i2c0_pins_a>;
Signature · 1 line
2.1.0
#2 lore raw

PATCH 1/2 ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi

In reply to Hans de Goede

Hello.

Quoted 12 lines · Hans de Goede

The A23 has the same lradc controller as previous Allwinner SoCs.

Signed-off-by Hans de Goede <[email protected]>
---
  arch/arm/boot/dts/sun8i-a23.dtsi | 7 +++++++
  1 file changed, 7 insertions(+)
arch/arm/boot/dts/sun8i-a23.dtsi +0 -0
index a31842d..c2ceafb 100644

arch/arm/boot/dts/sun8i-a23.dtsi line 423

Quoted 5 lines
arch/arm/boot/dts/sun8i-a23.dtsi +2 -0
@@ -419,6 +419,13 @@
  			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
  		};
 
+		lradc: lradc at 01c22800 {
+			compatible = "allwinner,sun4i-a10-lradc-keys";

If this is a keyboard controller, its node name should probably be
"keyboard", according to the ePAPR standard...

WBR, Sergei

author
#3 lore raw

PATCH 1/2 ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi

Hi,

Quoted 19 lines · Sergei Shtylyov

Hello.

Quoted 15 lines · Hans de Goede

The A23 has the same lradc controller as previous Allwinner SoCs.

Signed-off-by Hans de Goede <[email protected]>
---
  arch/arm/boot/dts/sun8i-a23.dtsi | 7 +++++++
  1 file changed, 7 insertions(+)
arch/arm/boot/dts/sun8i-a23.dtsi +0 -0
index a31842d..c2ceafb 100644
@@ -419,6 +419,13 @@
              interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
          };
Quoted 4 lines

arch/arm/boot/dts/sun8i-a23.dtsi line 423

Quoted 2 lines
arch/arm/boot/dts/sun8i-a23.dtsi +2 -0
+        lradc: lradc at 01c22800 {
+            compatible = "allwinner,sun4i-a10-lradc-keys";

If this is a keyboard controller, its node name should probably be "keyboard", according to the ePAPR standard...

I'm not sure this qualifies as a keyboard controller, more over we already have the same name in all other sun?i-a*.dtsi files, so if we fix this it should be fixed by a follow up patch, and be fixed everywhere.

Regards,

Hans

#4 lore raw

PATCH 1/2 ARM: dts: sun8i: Add lradc node to sun8i-a23.dtsi

In reply to Hans de Goede
Quoted 3 lines · Hans de Goede

The A23 has the same lradc controller as previous Allwinner SoCs.

Signed-off-by Hans de Goede <[email protected]>

Applied the two patches, thanks!

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150113/5af414be/attachment.sig>