Skip to contentSkip to conversation

arm: ls102xa: Enable snooping for CCI-400 S0 slave interface

PATCH New Alison Wang 3 participants 3 messages Nov 13, 2014 – Jan 15, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: ls102xa: Enable snooping for CCI-400 S0 slave interface

CAAM is connected to CCI-400 S0 slave interface. Disable snooping for S0 will cause CAAM self test failure. This patch is to enable snooping for S0 slave interface.

---
 board/freescale/ls1021aqds/ls1021aqds.c | 3 +--
 board/freescale/ls1021atwr/ls1021atwr.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
board/freescale/ls1021aqds/ls1021aqds.c +1 -2
index 4dda5e3..e5dea5d 100644
@@ -202,10 +202,9 @@ int board_early_init_f(void)
 		 CCI400_DVM_MESSAGE_REQ_EN | CCI400_SNOOP_REQ_EN);
 
 	/*
-	 * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
+	 * Set CCI-400 Slave interface S1, S2 Shareable Override Register
 	 * All transactions are treated as non-shareable
 	 */
-	out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 
board/freescale/ls1021atwr/ls1021atwr.c +1 -2
index 0629d1c..2c8afc0 100644
@@ -419,10 +419,9 @@ int board_init(void)
 	struct ccsr_cci400 *cci = (struct ccsr_cci400 *)CONFIG_SYS_CCI400_ADDR;
 
 	/*
-	 * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
+	 * Set CCI-400 Slave interface S1, S2 Shareable Override Register
 	 * All transactions are treated as non-shareable
 	 */
-	out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(0x1185000, 0x3);
Signature · 1 line
2.1.0.27.g96db324
#1 lore raw

PATCH 1/1 arm: ls102xa: Enable snooping for CCI-400 S0 slave interface

Alison,

Quoted 33 lines · Alison Wang

CAAM is connected to CCI-400 S0 slave interface. Disable snooping for S0 will cause CAAM self test failure. This patch is to enable snooping for S0 slave interface.

---
 board/freescale/ls1021aqds/ls1021aqds.c | 3 +--
 board/freescale/ls1021atwr/ls1021atwr.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
board/freescale/ls1021aqds/ls1021aqds.c +1 -2
index 4dda5e3..e5dea5d 100644
@@ -202,10 +202,9 @@ int board_early_init_f(void)
 		 CCI400_DVM_MESSAGE_REQ_EN | CCI400_SNOOP_REQ_EN);
 
 	/*
-	 * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
+	 * Set CCI-400 Slave interface S1, S2 Shareable Override Register
 	 * All transactions are treated as non-shareable
 	 */
-	out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 
board/freescale/ls1021atwr/ls1021atwr.c +0 -0
index 0629d1c..2c8afc0 100644
@@ -419,10 +419,9 @@ int board_init(void)
 	struct ccsr_cci400 *cci = (struct ccsr_cci400 *)CONFIG_SYS_CCI400_ADDR;

board/freescale/ls1021atwr/ls1021atwr.c int board_init(void) · line 427

Quoted 10 lines
board/freescale/ls1021atwr/ls1021atwr.c +1 -2
 
 	/*
-	 * Set CCI-400 Slave interface S0, S1, S2 Shareable Override Register
+	 * Set CCI-400 Slave interface S1, S2 Shareable Override Register
 	 * All transactions are treated as non-shareable
 	 */
-	out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(0x1185000, 0x3);

Which patch does this one depend on? The code you remove doesn't exist. Please check and rebase to latest code if necessary.

York

#2 lore raw

PATCH 1/1 arm: ls102xa: Enable snooping for CCI-400 S0 slave interface

Hi, York,

Quoted 42 lines · Alison Wang
Quoted 2 lines

CAAM is connected to CCI-400 S0 slave interface. Disable snooping for S0 will cause CAAM self test failure. This patch is to enable

snooping

Quoted 14 lines

for S0 slave interface.

---
 board/freescale/ls1021aqds/ls1021aqds.c | 3 +--
board/freescale/ls1021atwr/ls1021atwr.c | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
board/freescale/ls1021aqds/ls1021aqds.c +0 -0
index 4dda5e3..e5dea5d 100644

board/freescale/ls1021aqds/ls1021aqds.c int board_early_init_f(void) · line 205

Quoted 4 lines
board/freescale/ls1021aqds/ls1021aqds.c +0 -1
@@ -202,10 +202,9 @@ int board_early_init_f(void)
 		 CCI400_DVM_MESSAGE_REQ_EN | CCI400_SNOOP_REQ_EN);
 
 	/*
-	 * Set CCI-400 Slave interface S0, S1, S2 Shareable Override

Register

Quoted 13 lines
board/freescale/ls1021aqds/ls1021aqds.c +1 -1
+	 * Set CCI-400 Slave interface S1, S2 Shareable Override Register
 	 * All transactions are treated as non-shareable
 	 */
-	out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 
board/freescale/ls1021atwr/ls1021atwr.c +0 -0
index 0629d1c..2c8afc0 100644

board/freescale/ls1021atwr/ls1021atwr.c int board_init(void) · line 423

Quoted 5 lines
board/freescale/ls1021atwr/ls1021atwr.c +0 -1
@@ -419,10 +419,9 @@ int board_init(void)
 	struct ccsr_cci400 *cci = (struct ccsr_cci400
 *)CONFIG_SYS_CCI400_ADDR;
 
 	/*
-	 * Set CCI-400 Slave interface S0, S1, S2 Shareable Override

Register

Quoted 12 lines
Quoted 8 lines
board/freescale/ls1021atwr/ls1021atwr.c +1 -1
+	 * Set CCI-400 Slave interface S1, S2 Shareable Override Register
 	 * All transactions are treated as non-shareable
 	 */
-	out_le32(&cci->slave[0].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[1].sha_ord, CCI400_SHAORD_NON_SHAREABLE);
 	out_le32(&cci->slave[2].sha_ord, CCI400_SHAORD_NON_SHAREABLE);

out_le32(0x1185000, 0x3);

Which patch does this one depend on? The code you remove doesn't exist. Please check and rebase to latest code if necessary.

[Alison Wang] This patch was based on other patch about deep sleep. I will rebase and integrate it into another patch. I will abandon this patch.

Thanks.

Best Regards,
Alison Wang