Skip to contentSkip to conversation

ARM: tegra20: cpuidle: remove unnecessary "resettable" status clear

PATCH In review Dmitry Osipenko 1 participant 2 messages Jan 15, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: tegra20: cpuidle: remove unnecessary "resettable" status clear

CPU1 "resettable" status is already cleared by final suspend function in case of suspend abortion and by reset handler in case of completed CPU powergate, no point to do it again.

---
 arch/arm/mach-tegra/cpuidle-tegra20.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm/mach-tegra/cpuidle-tegra20.c +0 -2
index b30bf5c..ad6158e 100644
@@ -158,8 +158,6 @@ static bool tegra20_idle_enter_lp2_cpu_1(struct cpuidle_device *dev,
 
 	cpu_suspend(0, tegra20_sleep_cpu_secondary_finish);
 
-	tegra20_cpu_clear_resettable();
-
 	clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu);
 
 	return true;
Signature · 1 line
2.2.1
#1 lore raw

15.01.2015 15:49, Dmitry Osipenko пишет:

Quoted 15 lines

CPU1 "resettable" status is already cleared by final suspend function in case of suspend abortion and by reset handler in case of completed CPU powergate, no point to do it again.

---
  arch/arm/mach-tegra/cpuidle-tegra20.c | 2 --
  1 file changed, 2 deletions(-)
arch/arm/mach-tegra/cpuidle-tegra20.c +0 -0
index b30bf5c..ad6158e 100644

arch/arm/mach-tegra/cpuidle-tegra20.c static bool tegra20_idle_enter_lp2_cpu_1(struct cpuidle_device *dev, · line 163

Quoted 8 lines
arch/arm/mach-tegra/cpuidle-tegra20.c +0 -2
@@ -158,8 +158,6 @@ static bool tegra20_idle_enter_lp2_cpu_1(struct cpuidle_device *dev,
 
  	cpu_suspend(0, tegra20_sleep_cpu_secondary_finish);
 
-	tegra20_cpu_clear_resettable();
-
  	clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu);
 
  	return true;

Completely forgot to remove it also from 'sleep.h' and 'sleep-tegra20.S'. Please ignore this patch, I'll include it in ASM -> C conversion series.

Signature · 1 line
Dmitry