Skip to contentSkip to conversation

dvd+rw-tools: new package

PATCH Superseded Steve Kenton 3 participants 5 messages Jan 17, 2015 – Jan 18, 2015

v2 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 dvd+rw-tools: new package

The dvd+rw-tools are used to master Blu-ray Disc and DVD Disc media, both +RW/+R and -RW/-R. The +RW in the name is a historical artifact. This package contains the widely used growisofs program.

http://fy.chalmers.se/~appro/linux/DVD+RW/tools

Signed-off-by Stephen M. Kenton <[email protected]>
---
V2 - added the licensing information
Build tested with both uClibc and glibc against last nights snapshot

uClibc make savedefconfig
BR2_PACKAGE_DVDRW_TOOLS=y

glibc make savedefconfig
BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
BR2_PACKAGE_DVDRW_TOOLS=y

package/Config.in +1 -0
diff -pruN buildroot.ori/package/Config.in buildroot/package/Config.in
@@ -7,6 +7,7 @@ menu "Audio and video applications"
 	source "package/aumix/Config.in"
 	source "package/bellagio/Config.in"
 	source "package/dvdauthor/Config.in"
+	source "package/dvdrw-tools/Config.in"
 	source "package/espeak/Config.in"
 	source "package/faad2/Config.in"
 	source "package/ffmpeg/Config.in"
package/dvdrw-tools/0001-limits.h.patch +12 -0
diff -pruN buildroot.ori/package/dvdrw-tools/0001-limits.h.patch buildroot/package/dvdrw-tools/0001-limits.h.patch
@@ -0,0 +1,12 @@
+diff -ru dvd+rw-tools-7.1.clean/transport.hxx dvd+rw-tools-7.1.modified/transport.hxx
+--- dvd+rw-tools-7.1.clean/transport.hxx	2008-03-01 04:34:43.000000000 -0600
++++ dvd+rw-tools-7.1.modified/transport.hxx	2014-12-16 16:34:04.208459745 -0600
+@@ -9,6 +9,7 @@
+ #if defined(__unix) || defined(__unix__)
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <limits.h>
+ #include <unistd.h>
+ #include <string.h>
+ #include <sys/types.h>
+
package/dvdrw-tools/Config.in +9 -0
diff -pruN buildroot.ori/package/dvdrw-tools/Config.in buildroot/package/dvdrw-tools/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_DVDRW_TOOLS
+	bool "dvdrw-tools"
+	help
+	  The dvd+rw-tools are used to master Blu-ray Disc
+	  and DVD Disc media, both +RW/+R and -RW/-R. The
+	  +RW in the name is a historical artifact. This
+	  package contains the widely used growisofs program.
+	
+	  http://fy.chalmers.se/~appro/linux/DVD+RW/tools
package/dvdrw-tools/dvdrw-tools.mk +24 -0
diff -pruN buildroot.ori/package/dvdrw-tools/dvdrw-tools.mk buildroot/package/dvdrw-tools/dvdrw-tools.mk
@@ -0,0 +1,24 @@
+#############################################################
+#
+# dvdrw-tools
+#
+#############################################################
+DVDRW_TOOLS_VERSION = 7.1
+DVDRW_TOOLS_SOURCE = dvd+rw-tools-$(DVDRW_TOOLS_VERSION).tar.gz
+DVDRW_TOOLS_SITE = http://fy.chalmers.se/~appro/linux/DVD+RW/tools
+DVDRW_TOOLS_LICENSE = GPLv2
+DVDRW_TOOLS_LICENSE_FILES = LICENSE
+
+define DVDRW_TOOLS_BUILD_CMDS
+	$(MAKE) -C $(@D)
+endef
+
+define DVDRW_TOOLS_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/dvd-ram-control $(TARGET_DIR)/usr/bin/dvd-ram-control
+	$(INSTALL) -m 0755 -D $(@D)/dvd+rw-booktype $(TARGET_DIR)/usr/bin/dvd+rw-booktype
+	$(INSTALL) -m 0755 -D $(@D)/dvd+rw-format $(TARGET_DIR)/usr/bin/dvd+rw-format
+	$(INSTALL) -m 0755 -D $(@D)/dvd+rw-mediainfo $(TARGET_DIR)/usr/bin/dvd+rw-mediainfo
+	$(INSTALL) -m 0755 -D $(@D)/growisofs $(TARGET_DIR)/usr/bin/growisofs
+endef
+
+$(eval $(generic-package))
#1 lore raw

PATCH v2 1/1 dvd+rw-tools: new package

[posted and mailed]

Steve Kenton <[email protected]> wrote in
news:54B9B774.9030204 at ou.edu:

package/dvdrw-tools/dvdrw-tools.mk line 22

Quoted 2 lines
package/dvdrw-tools/dvdrw-tools.mk +2 -0
+     $(INSTALL) -m 0755 -D $(@D)/growisofs $(TARGET_DIR)/usr/bin/growisofs
+endef

Hi,

according to Beyond Linux From Scratch you need libisoburn or a similar package which provides xorrisofs, otherwise "the growisofs command will not function properly"
http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html

Did your package work without xorrisofs during your tests?

Regards, Bernd

#2 lore raw

PATCH v2 1/1 dvd+rw-tools: new package

Quoted 8 lines · Bernd Kuhls

according to Beyond Linux From Scratch you need libisoburn or a similar package which provides xorrisofs, otherwise "the growisofs command will not function properly"
http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html

Did your package work without xorrisofs during your tests?

Regards, Bernd

I was working on xorriso, dvdauthor, dvd+rw-tools and mjpegtools simultaneously for my embedded project. Once they all worked I cleaned them up for submission. GNU Xorriso includes all the libburnia libraries as well as the xorriso burner program. FYI - Xorriso and dvdauthor were just committed. I did not think to check for hidden runtime dependencies when I was working up the submission for those four packages individually. I just worked on getting each of them to build in a clean buildroot snapshot for both uClibc and glibc.

If it was not a feature that I needed for my project right then it probably did not get run time tested. So I can well believe there may be other dependencies that I did not discover. Thanks for the tip, I'll try it out stand-alone and see what I find.

Steve

#3 lore raw

PATCH v2 1/1 dvd+rw-tools: new package

In reply to Bernd Kuhls
Quoted 5 lines

according to Beyond Linux From Scratch you need libisoburn or a similar package which provides xorrisofs, otherwise "the growisofs command will not function properly"
http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html

I look at the LFS information again and it brings up another points. Linux From Scratch patches dvd+rw-tools to replace mkisofs from the cdrtools package with xorrisofs from GNU xorriso.

I have also been experimenting with the cdrtools 3.01 pre-release package. The controversy about whether the CDDL license is GPL compatible is beyond me. Would the buildroot project be likely to accept a cdrtools submission or should I also patch dvd+rw-tools to to use the xorriso equivalents to the cdrtools programs? I missed that and need to do one or the other I guess.

FYI xorriso does not do UDF and cdrtools apparently does.

Steve

#4 lore raw

PATCH v2 1/1 dvd+rw-tools: new package

Steve, All,

On 2015-01-17 22:23 -0600, Steve Kenton spake thusly:

Quoted 9 lines
Quoted 4 lines

according to Beyond Linux From Scratch you need libisoburn or a similar package which provides xorrisofs, otherwise "the growisofs command will not function properly"
http://www.linuxfromscratch.org/blfs/view/svn/multimedia/dvd-rw-tools.html

I look at the LFS information again and it brings up another points. Linux From Scratch patches dvd+rw-tools to replace mkisofs from the cdrtools package with xorrisofs from GNU xorriso.

Quoted 5 lines

I have also been experimenting with the cdrtools 3.01 pre-release package. The controversy about whether the CDDL license is GPL compatible is beyond me. Would the buildroot project be likely to accept a cdrtools submission or should I also patch dvd+rw-tools to to use the xorriso equivalents to the cdrtools programs? I missed that and need to do one or the other I guess.

Well, we do not try to resolve license dependencies and/or incompatibilities. We are not lawyers, so we lack the knowledge to do so.

Instead, we just list the licenses, and leave out to the user (or their legal team) to sort out such incompatibilities, should they believe there are.

So, my suggestion would be to just list the licenses as exhaustively as possible, and be done with that.

So yes, we'd accept such a package. ;-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'