Skip to contentSkip to conversation

staging: iio: ad5933: fix format string warnings

PATCH Applied Asaf Vertz 3 participants 3 messages Jan 20, 2015

Subsystems (4)
lore
Share & tools
lore

Asaf Vertz

author
#0 lore raw

PATCH 1/1 staging: iio: ad5933: fix format string warnings

Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4) requires 'int' but the argument type is 'unsigned int'.

---
 drivers/staging/iio/impedance-analyzer/ad5933.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/impedance-analyzer/ad5933.c +2 -2
index b6bd609..4230a43 100644
@@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
 	mutex_lock(&indio_dev->mlock);
 	switch ((u32) this_attr->address) {
 	case AD5933_OUT_RANGE:
-		len = sprintf(buf, "%d\n",
+		len = sprintf(buf, "%u\n",
 			      st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
 		break;
 	case AD5933_OUT_RANGE_AVAIL:
-		len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
+		len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
 			      st->range_avail[3], st->range_avail[2],
 			      st->range_avail[1]);
 		break;
Signature · 1 line
1.7.0.4
Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Asaf Vertz

Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4) requires 'int' but the argument type is 'unsigned int'.

Quoted 1 line

Thanks.

Quoted 23 lines
---
  drivers/staging/iio/impedance-analyzer/ad5933.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/impedance-analyzer/ad5933.c +2 -2
index b6bd609..4230a43 100644
@@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
  	mutex_lock(&indio_dev->mlock);
  	switch ((u32) this_attr->address) {
  	case AD5933_OUT_RANGE:
-		len = sprintf(buf, "%d\n",
+		len = sprintf(buf, "%u\n",
  			      st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
  		break;
  	case AD5933_OUT_RANGE_AVAIL:
-		len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
+		len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
  			      st->range_avail[3], st->range_avail[2],
  			      st->range_avail[1]);
  		break;
maintainer Applied
#2 lore raw
Quoted 13 lines · Lars-Peter Clausen
Quoted 12 lines · Asaf Vertz

Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/impedance-analyzer/ad5933.c:367]: (warning) %d in format string (no. 4) requires 'int' but the argument type is 'unsigned int'.

Quoted 3 lines
Quoted 1 line

Applied to the togreg branch of iio.git. Initially pushed out as testing. Thanks,

Jonathan

Quoted 27 lines

Thanks.

Quoted 23 lines
---
  drivers/staging/iio/impedance-analyzer/ad5933.c |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/impedance-analyzer/ad5933.c +2 -2
index b6bd609..4230a43 100644
@@ -360,11 +360,11 @@ static ssize_t ad5933_show(struct device *dev,
      mutex_lock(&indio_dev->mlock);
      switch ((u32) this_attr->address) {
      case AD5933_OUT_RANGE:
-        len = sprintf(buf, "%d\n",
+        len = sprintf(buf, "%u\n",
                    st->range_avail[(st->ctrl_hb >> 1) & 0x3]);
          break;
      case AD5933_OUT_RANGE_AVAIL:
-        len = sprintf(buf, "%d %d %d %d\n", st->range_avail[0],
+        len = sprintf(buf, "%u %u %u %u\n", st->range_avail[0],
                    st->range_avail[3], st->range_avail[2],
                    st->range_avail[1]);
          break;