si2168 fix
That patch must go also stable v3.16+ as tagged Cc.
regards
Antti
The following changes since commit 2c0108e1c02f9fc95f465adc4d2ce1ad8688290a:
[media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21
21:09:11 -0200)
are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git si2168_fix
for you to fetch changes up to a85385413c60602b529a1555146c4e81a5935e98:
si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20
+0200)
----------------------------------------------------------------
Jurgen Kramer (1):
si2168: increase timeout to fix firmware loading
drivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
http://palosaari.fi/
Antti Palosaari
Reviewed-byMauro
Did that patch went to stable? I see you have committed original patch from patchwork, but there is no stable tag.
Quoted 20 lines · Antti Palosaari
That patch must go also stable v3.16+ as tagged Cc.
regards
AnttiThe following changes since commit
2c0108e1c02f9fc95f465adc4d2ce1ad8688290a:[media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21
21:09:11 -0200)are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git si2168_fixfor you to fetch changes up to
a85385413c60602b529a1555146c4e81a5935e98:si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20
+0200)
Quoted 7 lines
----------------------------------------------------------------
Jurgen Kramer (1):
si2168: increase timeout to fix firmware loadingdrivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
https://patchwork.linuxtv.org/patch/27382/
commit 551c33e729f654ecfaed00ad399f5d2a631b72cb
Author: Jurgen Kramer <[email protected]> Date: Mon Dec 8 05:30:44 2014 -0300
[media] Si2168: increase timeout to fix firmware loading
Increase si2168 cmd execute timeout to prevent firmware load
failures. Tests
shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'
firmware.
Increase timeout to a safe value of 70ms.
Antti
Signature · 1 line
http://palosaari.fi/
Mauro Carvalho Chehab
Reviewed-by Antti PalosaariEm Fri, 20 Feb 2015 02:47:44 +0200
Antti Palosaari <[email protected]> escreveu:
Quoted 3 lines
Mauro
Did that patch went to stable? I see you have committed original patch from patchwork, but there is no stable tag.
It went upstream, but I'm unsure if it arrived for 3.19 or 3.20.
That's the upstream changeset:
$ git show 551c33e729f6 commit 551c33e729f654ecfaed00ad399f5d2a631b72cb Author: Jurgen Kramer <[email protected]> Date: Mon Dec 8 05:30:44 2014 -0300
[media] Si2168: increase timeout to fix firmware loading
Increase si2168 cmd execute timeout to prevent firmware load failures. Tests shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. Increase timeout to a safe value of 70ms.
Weird, it is missing the Cc tag on its commit message. I double-checked re-applying it on a scratch branch: my scripts are properly recognizing the Cc tag.
I've no idea what happened. Perhaps you've added this patch on some other branch that you asked me to pull?
Anyway, now the proper solution is to send this patch directly to [email protected], C/C the mailing list.
Regards,
Mauro
Quoted 58 lines · Antti Palosaari
Quoted 20 lines
That patch must go also stable v3.16+ as tagged Cc.
regards
AnttiThe following changes since commit
2c0108e1c02f9fc95f465adc4d2ce1ad8688290a:[media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21
21:09:11 -0200)are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git si2168_fixfor you to fetch changes up to
a85385413c60602b529a1555146c4e81a5935e98:si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20
+0200)Quoted 7 lines
----------------------------------------------------------------
Jurgen Kramer (1):
si2168: increase timeout to fix firmware loadingdrivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)https://patchwork.linuxtv.org/patch/27382/
commit
551c33e729f654ecfaed00ad399f5d2a631b72cbAuthor: Jurgen Kramer <[email protected]> Date: Mon Dec 8 05:30:44 2014 -0300[media] Si2168: increase timeout to fix firmware loading
Increase si2168 cmd execute timeout to prevent firmware load
failures. Testsshows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'firmware.
Increase timeout to a safe value of 70ms.Signed-off-by Jurgen Kramer <[email protected]>Reviewed-by Antti Palosaari <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Antti
Quoted 30 lines · Mauro Carvalho Chehab
Em Fri, 20 Feb 2015 02:47:44 +0200
Antti Palosaari <[email protected]> escreveu:Quoted 3 lines
Mauro
Did that patch went to stable? I see you have committed original patch from patchwork, but there is no stable tag.It went upstream, but I'm unsure if it arrived for 3.19 or 3.20.
That's the upstream changeset:
$ git show 551c33e729f6 commit 551c33e729f654ecfaed00ad399f5d2a631b72cb Author: Jurgen Kramer <[email protected]> Date: Mon Dec 8 05:30:44 2014 -0300[media] Si2168: increase timeout to fix firmware loading
Increase si2168 cmd execute timeout to prevent firmware load failures. Tests shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. Increase timeout to a safe value of 70ms.
Signed-off-by Jurgen Kramer <[email protected]>Reviewed-by Antti Palosaari <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Weird, it is missing the Cc tag on its commit message. I double-checked re-applying it on a scratch branch: my scripts are properly recognizing the Cc tag.
Quoted 5 lines
I've no idea what happened. Perhaps you've added this patch on some other branch that you asked me to pull?
Anyway, now the proper solution is to send this patch directly to [email protected], C/C the mailing list.
I added proper stable tag to patchwork and then waited looong time you pick it from patchwork. After a month or so, I picked whole patch from patchwork to my tree, yet again added proper stable tags and made PULL-request. So there is stable tag on both patchwork and PULL-request. You applied patchwork - but without stable tag....
So I am very surprised to see original patch applied to master, but without stable tag.
Si2168: increase timeout to fix firmware loading
https://patchwork.linuxtv.org/patch/27382/
[GIT PULL 3.19] si2168 fix
http://www.spinics.net/lists/linux-media/msg85713.html
Antti
Quoted 62 lines
Regards,
MauroQuoted 58 lines · Antti Palosaari
Quoted 18 lines
That patch must go also stable v3.16+ as tagged Cc.
regards
AnttiThe following changes since commit
2c0108e1c02f9fc95f465adc4d2ce1ad8688290a:[media] omap3isp: Correctly set QUERYCAP capabilities (2015-01-21
21:09:11 -0200)are available in the git repository at:
git://linuxtv.org/anttip/media_tree.git si2168_fixfor you to fetch changes up to
a85385413c60602b529a1555146c4e81a5935e98:si2168: increase timeout to fix firmware loading (2015-01-22 12:06:20Quoted 9 lines
+0200)
----------------------------------------------------------------
Jurgen Kramer (1):
si2168: increase timeout to fix firmware loadingdrivers/media/dvb-frontends/si2168.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)https://patchwork.linuxtv.org/patch/27382/
commit
551c33e729f654ecfaed00ad399f5d2a631b72cbAuthor: Jurgen Kramer <[email protected]> Date: Mon Dec 8 05:30:44 2014 -0300[media] Si2168: increase timeout to fix firmware loading
Increase si2168 cmd execute timeout to prevent firmware load
failures. Testsshows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw'firmware.
Increase timeout to a safe value of 70ms.Signed-off-by Jurgen Kramer <[email protected]>Reviewed-by Antti Palosaari <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Antti
Signature · 1 line
http://palosaari.fi/
Em Fri, 20 Feb 2015 03:44:28 +0200
Antti Palosaari <[email protected]> escreveu:
Quoted 43 lines · Mauro Carvalho Chehab
Quoted 30 lines
Em Fri, 20 Feb 2015 02:47:44 +0200
Antti Palosaari <[email protected]> escreveu:Quoted 3 lines
Mauro
Did that patch went to stable? I see you have committed original patch from patchwork, but there is no stable tag.It went upstream, but I'm unsure if it arrived for 3.19 or 3.20.
That's the upstream changeset:
$ git show 551c33e729f6 commit 551c33e729f654ecfaed00ad399f5d2a631b72cb Author: Jurgen Kramer <[email protected]> Date: Mon Dec 8 05:30:44 2014 -0300[media] Si2168: increase timeout to fix firmware loading
Increase si2168 cmd execute timeout to prevent firmware load failures. Tests shows it takes up to 52ms to load the 'dvb-demod-si2168-a30-01.fw' firmware. Increase timeout to a safe value of 70ms.
Signed-off-by Jurgen Kramer <[email protected]>Reviewed-by Antti Palosaari <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Weird, it is missing the Cc tag on its commit message. I double-checked re-applying it on a scratch branch: my scripts are properly recognizing the Cc tag.
Quoted 5 lines
I've no idea what happened. Perhaps you've added this patch on some other branch that you asked me to pull?
Anyway, now the proper solution is to send this patch directly to [email protected], C/C the mailing list.
I added proper stable tag to patchwork and then waited looong time you pick it from patchwork. After a month or so, I picked whole patch from patchwork to my tree, yet again added proper stable tags and made PULL-request. So there is stable tag on both patchwork and PULL-request. You applied patchwork - but without stable tag....
Quoted 8 lines
So I am very surprised to see original patch applied to master, but without stable tag.
Si2168: increase timeout to fix firmware loading
https://patchwork.linuxtv.org/patch/27382/[GIT PULL 3.19] si2168 fix
http://www.spinics.net/lists/linux-media/msg85713.html
Ah, I know what happened: you replied with "Reviewed-by:" on 2014-12-08, but you sent the pull request only in 2015-01-22.
The "Accepted" state for the #27382 patch indicates that I picked the version that was at patchwork, instead of the one from your pull request, because I saw that you've replied with a reviewed-by tag.
Unfortunately, patchwork doesn't consider "Cc:" as a tag to honor, nor it brings the full history of the replies on its pwclient interface. So, I didn't notice the Cc: on your reply.
Next time, if you intend to send the patch on a separate pull request, please don't reply with a "reviewed-by:" tag, as I my understanding when I see acked-by/reviewed-by from a driver maintainer is that he won't be sending me a pull request about that specific patch. When I have time, I sometimes double check, but, as I was just arriving from vacations in the end of January, I had a very long backlog to handle.
Regards,
Mauro