mmc: dw_mmc: fixed the wrong bit control

PATCH New Jaehoon Chung 4 participants 5 messages Jan 14, 2015 – Feb 23, 2015 MMC, SD and SDIO

lore

Share & tools

lore

Jaehoon Chung

author

2015-01-14 08:37 UTC #0 lore raw

PATCH 1/1 mmc: dw_mmc: fixed the wrong bit control

If mode is not DDR-mode, then it needs to clear it.

Signed-off-by Jaehoon Chung <[email protected]>

---
 drivers/mmc/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/dw_mmc.c +1 -1

index b18c75d..76fa0b0 100644
@@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
 	if (mmc->ddr_mode)
 		regs |= DWMCI_DDR_MODE;
 	else
-		regs &= DWMCI_DDR_MODE;
+		regs &= ~DWMCI_DDR_MODE;
 
 	dwmci_writel(host, DWMCI_UHS_REG, regs);

Signature · 1 line

1.9.1

Jaehoon Chung

2015-01-23 13:43 UTC #1 lore raw

PATCH 1/1 mmc: dw_mmc: fixed the wrong bit control

Could you check this patch?

Best Regards,
Jaehoon Chung

Quoted 21 lines · Jaehoon Chung

If mode is not DDR-mode, then it needs to clear it.

Signed-off-by Jaehoon Chung <[email protected]>

---
 drivers/mmc/dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/dw_mmc.c +1 -1

index b18c75d..76fa0b0 100644
@@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
 	if (mmc->ddr_mode)
 		regs |= DWMCI_DDR_MODE;
 	else
-		regs &= DWMCI_DDR_MODE;
+		regs &= ~DWMCI_DDR_MODE;
 
 	dwmci_writel(host, DWMCI_UHS_REG, regs);

Pantelis Antoniou

2015-01-23 13:44 UTC #2 lore raw

PATCH 1/1 mmc: dw_mmc: fixed the wrong bit control

Hi Jaehoon,

Quoted 6 lines · Jaehoon Chung

Hi
Could you check this patch?

Ugh, sorry missed this; did it end up assigned at patchwork to me?

The patch is obviously correct.

Quoted 3 lines

Best Regards,
Jaehoon Chung

Regards

? Pantelis

Quoted 23 lines · Jaehoon Chung

Quoted 21 lines
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by Jaehoon Chung <[email protected]>
---
drivers/mmc/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/dw_mmc.c +1 -1
index b18c75d..76fa0b0 100644
@@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
 	if (mmc->ddr_mode)
 		regs |= DWMCI_DDR_MODE;
 	else
-		regs &= DWMCI_DDR_MODE;
+		regs &= ~DWMCI_DDR_MODE;
 
 	dwmci_writel(host, DWMCI_UHS_REG, regs);
 

Jaehoon Chung

author

2015-01-23 13:48 UTC #3 lore raw

PATCH 1/1 mmc: dw_mmc: fixed the wrong bit control

Dear Pantelis.

Quoted 10 lines · Pantelis Antoniou

Hi Jaehoon,
Quoted 6 lines · Jaehoon Chung
Hi
Could you check this patch?
Ugh, sorry missed this; did it end up assigned at patchwork to me?

Updated. :)

Best Regards,
Jaehoon Chung

Quoted 36 lines

The patch is obviously correct.
Quoted 3 lines
Best Regards,
Jaehoon Chung
Regards
? Pantelis
Quoted 23 lines · Jaehoon Chung
Quoted 21 lines
If mode is not DDR-mode, then it needs to clear it.
Signed-off-by Jaehoon Chung <[email protected]>
---
drivers/mmc/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/dw_mmc.c +1 -1
index b18c75d..76fa0b0 100644
@@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
 	if (mmc->ddr_mode)
 		regs |= DWMCI_DDR_MODE;
 	else
-		regs &= DWMCI_DDR_MODE;
+		regs &= ~DWMCI_DDR_MODE;
 
 	dwmci_writel(host, DWMCI_UHS_REG, regs);
 

Pantelis Antoniou

Applied

2015-02-23 17:36 UTC #4 lore raw

PATCH 1/1 mmc: dw_mmc: fixed the wrong bit control

In reply to Jaehoon Chung

Hi Jaehoon,

Quoted 25 lines · Jaehoon Chung

If mode is not DDR-mode, then it needs to clear it.
Signed-off-by Jaehoon Chung <[email protected]>
---
drivers/mmc/dw_mmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/dw_mmc.c +1 -1
index b18c75d..76fa0b0 100644
@@ -321,7 +321,7 @@ static void dwmci_set_ios(struct mmc *mmc)
 	if (mmc->ddr_mode)
 		regs |= DWMCI_DDR_MODE;
 	else
-		regs &= DWMCI_DDR_MODE;
+		regs &= ~DWMCI_DDR_MODE;
 
 	dwmci_writel(host, DWMCI_UHS_REG, regs);
 
Signature · 1 line
1.9.1

Applied, thanks

? Pantelis