Skip to contentSkip to conversation

Merging hid-huion into hid-uclogic

DISCUSSION Nikolai Kondrashov 2 participants 3 messages Jan 25, 2015 – Jan 27, 2015 HID

lore
Share & tools
lore
#0 lore raw

Hi Jiri, everyone,

I'd like to have your opinion if it will be fine to merge hid-huion.c into hid-uclogic.c, keeping tablet support intact, of course.

The reason is, Huion tablets actually use UC-Logic hardware and the probing method used in hid-huion.c huion_tablet_enable actually works with (at least) newer UC-Logic tablets, including at least 6 Yiynova tablet models, a newer version of Monoprice MP1060-HA60, and some Ugee models - all of them using UC-Logic VID.

I have all of these working in various branches of digimend-kernel-drivers [1] and waiting to be contributed, but putting them in hid-huion.c would make it support more UC-Logic tablet models than hid-uclogic.c does (even though they reuse their PIDs). And that might be awkward and confusing.

So, would it be a good idea to merge hid-huion.c into hid-uclogic.c and would you accept such change into the kernel?

Thank you.

[1] https://github.com/DIGImend/digimend-kernel-drivers

#1 lore raw
Quoted 2 lines · Nikolai Kondrashov

I'd like to have your opinion if it will be fine to merge hid-huion.c into hid-uclogic.c, keeping tablet support intact, of course.

huion driver module doesn't take any module parameters, so that should be fine (renaming modules that accept parameters is more tricky due to potential userspace configuration breakage).

Signature · 2 lines
Jiri Kosina
SUSE Labs
#2 lore raw
Quoted 8 lines · Jiri Kosina
Quoted 2 lines · Nikolai Kondrashov

I'd like to have your opinion if it will be fine to merge hid-huion.c into hid-uclogic.c, keeping tablet support intact, of course.

huion driver module doesn't take any module parameters, so that should be fine (renaming modules that accept parameters is more tricky due to potential userspace configuration breakage).

Thanks a lot, Jiri. I'll work towards that then.

Nick