STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

PATCH In review Simon Guo 2 participants 3 messages Jan 25, 2015 – Jan 26, 2015 Staging

lore

Share & tools

lore

Simon Guo

author

2015-01-25 09:28 UTC #0 lore raw

PATCH 1/3 STAGING: Fix pcl818.c coding style issue: code indent should use tabs where possible

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- code indent should use tabs where possible

Signed-off-by Simon Guo <[email protected]>

---
 drivers/staging/comedi/drivers/pcl818.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

drivers/staging/comedi/drivers/pcl818.c +13 ~~-13~~

index ba2e137..72a700c 100644
@@ -45,11 +45,11 @@ A word or two about DMA. Driver support DMA operations at two ways:
     [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
     [2] - DMA	(0=disable, 1, 3)
     [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
     [4] - 0,  5=A/D input  -5V.. +5V
-          1, 10=A/D input -10V..+10V
+	  1, 10=A/D input -10V..+10V
     [5] - 0,  5=D/A output 0-5V  (internal reference -5V)
-          1, 10=D/A output 0-10V (internal reference -10V)
+	  1, 10=D/A output 0-10V (internal reference -10V)
 	  2    =D/A output unknown (external reference)
 
    Options for PCL-818, PCL-818H:

@@ -57,28 +57,28 @@ A word or two about DMA. Driver support DMA operations at two ways:
     [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
     [2] - DMA	(0=disable, 1, 3)
     [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
     [4] - 0,  5=D/A output 0-5V  (internal reference -5V)
-          1, 10=D/A output 0-10V (internal reference -10V)
+	  1, 10=D/A output 0-10V (internal reference -10V)
 	  2    =D/A output unknown (external reference)
 
    Options for PCL-818HD, PCL-818HG:
     [0] - IO Base
     [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
     [2] - DMA/FIFO  (-1=use FIFO, 0=disable both FIFO and DMA,
-                      1=use DMA ch 1, 3=use DMA ch 3)
+		      1=use DMA ch 1, 3=use DMA ch 3)
     [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
     [4] - 0,  5=D/A output 0-5V  (internal reference -5V)
-          1, 10=D/A output 0-10V (internal reference -10V)
-   	  2    =D/A output unknown (external reference)
+	  1, 10=D/A output 0-10V (internal reference -10V)
+	  2    =D/A output unknown (external reference)
 
    Options for PCL-718:
     [0] - IO Base
     [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
     [2] - DMA	(0=disable, 1, 3)
     [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
     [4] -     0=A/D Range is +/-10V
 	      1=             +/-5V
 	      2=             +/-2.5V

@@ -87,14 +87,14 @@ A word or two about DMA. Driver support DMA operations at two ways:
 	      5=  	     user defined bipolar
 	      6=	     0-10V
 	      7=	     0-5V
- 	      8=	     0-2V
+	      8=	     0-2V
 	      9=	     0-1V
 	     10=	     user defined unipolar
     [5] - 0,  5=D/A outputs 0-5V  (internal reference -5V)
-          1, 10=D/A outputs 0-10V (internal reference -10V)
+	  1, 10=D/A outputs 0-10V (internal reference -10V)
 	      2=D/A outputs unknown (external reference)
     [6] - 0, 60=max  60kHz A/D sampling
-          1,100=max 100kHz A/D sampling (PCL-718 with Option 001 installed)
+	  1,100=max 100kHz A/D sampling (PCL-718 with Option 001 installed)
 
 */

Signature · 1 line

1.8.1.2

Ian Abbott

Reviewed-by on v1 1/3

2015-01-26 11:31 UTC #1 lore raw

Quoted 70 lines · Simon Guo

Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- code indent should use tabs where possible

Signed-off-by Simon Guo <[email protected]>

---
  drivers/staging/comedi/drivers/pcl818.c | 26 +++++++++++++-------------
  1 file changed, 13 insertions(+), 13 deletions(-)

drivers/staging/comedi/drivers/pcl818.c +11 ~~-11~~

index ba2e137..72a700c 100644
@@ -45,11 +45,11 @@ A word or two about DMA. Driver support DMA operations at two ways:
      [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
      [2] - DMA	(0=disable, 1, 3)
      [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
      [4] - 0,  5=A/D input  -5V.. +5V
-          1, 10=A/D input -10V..+10V
+	  1, 10=A/D input -10V..+10V
      [5] - 0,  5=D/A output 0-5V  (internal reference -5V)
-          1, 10=D/A output 0-10V (internal reference -10V)
+	  1, 10=D/A output 0-10V (internal reference -10V)
  	  2    =D/A output unknown (external reference)
 
     Options for PCL-818, PCL-818H:

@@ -57,28 +57,28 @@ A word or two about DMA. Driver support DMA operations at two ways:
      [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
      [2] - DMA	(0=disable, 1, 3)
      [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
      [4] - 0,  5=D/A output 0-5V  (internal reference -5V)
-          1, 10=D/A output 0-10V (internal reference -10V)
+	  1, 10=D/A output 0-10V (internal reference -10V)
  	  2    =D/A output unknown (external reference)
 
     Options for PCL-818HD, PCL-818HG:
      [0] - IO Base
      [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
      [2] - DMA/FIFO  (-1=use FIFO, 0=disable both FIFO and DMA,
-                      1=use DMA ch 1, 3=use DMA ch 3)
+		      1=use DMA ch 1, 3=use DMA ch 3)
      [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
      [4] - 0,  5=D/A output 0-5V  (internal reference -5V)
-          1, 10=D/A output 0-10V (internal reference -10V)
-   	  2    =D/A output unknown (external reference)
+	  1, 10=D/A output 0-10V (internal reference -10V)
+	  2    =D/A output unknown (external reference)
 
     Options for PCL-718:
      [0] - IO Base
      [1] - IRQ	(0=disable, 2, 3, 4, 5, 6, 7)
      [2] - DMA	(0=disable, 1, 3)
      [3] - 0, 10=10MHz clock for 8254
-              1= 1MHz clock for 8254
+	      1= 1MHz clock for 8254
      [4] -     0=A/D Range is +/-10V
  	      1=             +/-5V
  	      2=             +/-2.5V

@@ -87,14 +87,14 @@ A word or two about DMA. Driver support DMA operations at two ways:
  	      5=  	     user defined bipolar
  	      6=	     0-10V
  	      7=	     0-5V
- 	      8=	     0-2V
+	      8=	     0-2V
  	      9=	     0-1V

drivers/staging/comedi/drivers/pcl818.c A word or two about DMA. Driver support DMA operations at two ways: · line 99

Quoted 10 lines

drivers/staging/comedi/drivers/pcl818.c +2 -2

  	     10=	     user defined unipolar
      [5] - 0,  5=D/A outputs 0-5V  (internal reference -5V)
-          1, 10=D/A outputs 0-10V (internal reference -10V)
+	  1, 10=D/A outputs 0-10V (internal reference -10V)
  	      2=D/A outputs unknown (external reference)
      [6] - 0, 60=max  60kHz A/D sampling
-          1,100=max 100kHz A/D sampling (PCL-718 with Option 001 installed)
+	  1,100=max 100kHz A/D sampling (PCL-718 with Option 001 installed)
 
  */

Okay, but this comment block really needs reformatting to use the usual block comment style, and with spaces to line up the columns instead of tabs so it still looks okay when the " * " is removed from the start of each line of the block comment.

Reviewed-by Ian Abbott <[email protected]>

Signature · 2 lines

-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Simon Guo

author

2015-01-26 12:52 UTC #2 lore raw

Ian,

Quoted 8 lines · Ian Abbott

Okay, but this comment block really needs reformatting to use the usual block comment style, and with spaces to line up the columns instead of tabs so it still looks okay when the " * " is removed from the start of each line of the block comment.
Reviewed-by Ian Abbott <[email protected]>

Thanks for your comments for my patch 1~3. I will rework and resend the 3 patches.

BR,
Simon