GFS2: Eliminate a nonsense goto

PATCH New Bob Peterson 2 participants 2 messages Jan 22, 2015 – Jan 26, 2015 1 message not in the archive GFS2 file system

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Bob Peterson

author

2015-01-22 16:11 UTC #1 lore raw

PATCH 1/1 GFS2: Eliminate a nonsense goto

Hi,

This patch just removes a goto that did nothing.

Regards,

Bob Peterson
Red Hat File Systems

Signed-off-by Bob Peterson <[email protected]>

---

fs/gfs2/inode.c +0 -3

index 9054002..73c72253 100644
@@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
 	}
 
 	error = gfs2_dir_add(&dip->i_inode, name, ip, da);
-	if (error)
-		goto fail_end_trans;
 
-fail_end_trans:
 	gfs2_trans_end(sdp);
 fail_ipreserv:
 	gfs2_inplace_release(dip);

Steven Whitehouse

2015-01-26 21:00 UTC #2 lore raw

PATCH 1/1 GFS2: Eliminate a nonsense goto

Hi,

Now in the -nmw git tree. Thanks,

Steve.

Quoted 27 lines · Bob Peterson

Hi,

This patch just removes a goto that did nothing.

Regards,

Bob Peterson
Red Hat File Systems

Signed-off-by Bob Peterson <[email protected]>

---

fs/gfs2/inode.c +0 -3

index 9054002..73c72253 100644
@@ -543,10 +543,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
  	}
 
  	error = gfs2_dir_add(&dip->i_inode, name, ip, da);
-	if (error)
-		goto fail_end_trans;
 
-fail_end_trans:
  	gfs2_trans_end(sdp);
  fail_ipreserv:
  	gfs2_inplace_release(dip);