Skip to contentSkip to conversation

ARM: dts: rockchip: add cpu and gpu regulators to rk3288-evb-act8846

PATCH New Heiko Stübner 2 participants 4 messages Jan 29, 2015 – Jan 30, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: rockchip: add cpu and gpu regulators to rk3288-evb-act8846

The evaluation board using the act8846 as main pmic uses two additional regulators to provide the cpu and gpu voltage. Add these and also add the link to cpu supply from vdd_cpu.

---
 arch/arm/boot/dts/rk3288-evb-act8846.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
arch/arm/boot/dts/rk3288-evb-act8846.dts +25 -0
index a76dd44..9db02bbe 100644
@@ -17,7 +17,32 @@
 	compatible = "rockchip,rk3288-evb-act8846", "rockchip,rk3288";
 };
 
+&cpu0 {
+	cpu0-supply = <&vdd_cpu>;
+};
+
 &i2c0 {
+	vdd_cpu: syr827 at 40 {
+		compatible = "silergy,syr827";
+		fcs,suspend-voltage-selector = <1>;
+		reg = <0x40>;
+		regulator-name = "vdd_cpu";
+		regulator-min-microvolt = <850000>;
+		regulator-max-microvolt = <1350000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vdd_gpu: syr828 at 41 {
+		compatible = "silergy,syr828";
+		fcs,suspend-voltage-selector = <1>;
+		reg = <0x41>;
+		regulator-name = "vdd_gpu";
+		regulator-min-microvolt = <850000>;
+		regulator-max-microvolt = <1350000>;
+		regulator-always-on;
+	};
+
 	hym8563 at 51 {
 		compatible = "haoyu,hym8563";
 		reg = <0x51>;
Signature · 1 line
2.1.1
#1 lore raw

PATCH 1/2 ARM: dts: rockchip: add cpu and gpu regulators to rk3288-evb-act8846

Quoted 5 lines · Heiko St?bner

The evaluation board using the act8846 as main pmic uses two additional regulators to provide the cpu and gpu voltage. Add these and also add the link to cpu supply from vdd_cpu.

Quoted 42 lines
---
  arch/arm/boot/dts/rk3288-evb-act8846.dts | 25 +++++++++++++++++++++++++
  1 file changed, 25 insertions(+)
arch/arm/boot/dts/rk3288-evb-act8846.dts +25 -0
index a76dd44..9db02bbe 100644
@@ -17,7 +17,32 @@
  	compatible = "rockchip,rk3288-evb-act8846", "rockchip,rk3288";
  };
 
+&cpu0 {
+	cpu0-supply = <&vdd_cpu>;
+};
+
  &i2c0 {
+	vdd_cpu: syr827 at 40 {
+		compatible = "silergy,syr827";
+		fcs,suspend-voltage-selector = <1>;
+		reg = <0x40>;
+		regulator-name = "vdd_cpu";
+		regulator-min-microvolt = <850000>;
+		regulator-max-microvolt = <1350000>;
+		regulator-always-on;
+		regulator-boot-on;
+	};
+
+	vdd_gpu: syr828 at 41 {
+		compatible = "silergy,syr828";
+		fcs,suspend-voltage-selector = <1>;
+		reg = <0x41>;
+		regulator-name = "vdd_gpu";
+		regulator-min-microvolt = <850000>;
+		regulator-max-microvolt = <1350000>;
+		regulator-always-on;
+	};
+
  	hym8563 at 51 {
  		compatible = "haoyu,hym8563";
  		reg = <0x51>;
Signature · 5 lines
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#2 lore raw

PATCH 1/2 ARM: dts: rockchip: add cpu and gpu regulators to rk3288-evb-act8846

In reply to Heiko Stübner

Am Donnerstag, 29. Januar 2015, 23:07:47 schrieb Heiko St?bner:

Quoted 6 lines

The evaluation board using the act8846 as main pmic uses two additional regulators to provide the cpu and gpu voltage. Add these and also add the link to cpu supply from vdd_cpu.

---

added both patches to my dts branch

#3 lore raw

PATCH 2/2 ARM: dts: rockchip: housekeeping off i2c0 on rk3288-evb boards

In reply to Heiko Stübner

Use the same transfer speed on both the rk808 and act8846 variants and remove the status=okay from the rk808 one which is already set in the shared rk3288-evb.dtsi .

---
 arch/arm/boot/dts/rk3288-evb-act8846.dts | 2 ++
 arch/arm/boot/dts/rk3288-evb-rk808.dts   | 1 -
 2 files changed, 2 insertions(+), 1 deletion(-)
arch/arm/boot/dts/rk3288-evb-act8846.dts +2 -0
index 9db02bbe..d7b8bbc 100644
@@ -22,6 +22,8 @@
 };
 
 &i2c0 {
+	clock-frequency = <400000>;
+
 	vdd_cpu: syr827 at 40 {
 		compatible = "silergy,syr827";
 		fcs,suspend-voltage-selector = <1>;
arch/arm/boot/dts/rk3288-evb-rk808.dts +0 -1
index d453ddd..3f7aa9e 100644
@@ -23,7 +23,6 @@
 
 &i2c0 {
 	clock-frequency = <400000>;
-	status = "okay";
 
 	rk808: pmic at 1b {
 		compatible = "rockchip,rk808";
Signature · 1 line
2.1.1