Skip to contentSkip to conversation

video/mmpfb: allow modular build

PATCH New Arnd Bergmann 2 participants 2 messages Jan 28, 2015 – Jan 30, 2015 Framebuffer layer

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 video/mmpfb: allow modular build

The frame buffer core can be a module, which means any fb drivers should be able to build as modules too. This turns mmpfb into a tristate option to allow that and fix a possible randconfig build error.

drivers/built-in.o: In function `modes_setup':
:(.text+0x11b34): undefined reference to fb_videomode_to_modelist' :(.text+0x11b5c): undefined reference to fb_videomode_to_var'

Signed-off-by Arnd Bergmann <[email protected]>
drivers/video/fbdev/mmp/Makefile +3 -1
index a014cb358bf8..924dd0930cc7 100644
@@ -1 +1,3 @@
-obj-y += core.o hw/ panel/ fb/
+obj-$(CONFIG_MMP_DISP) += mmp_disp.o hw/ panel/ fb/
+
+mmp_disp-y		+= core.o
drivers/video/fbdev/mmp/fb/Kconfig +1 -1
index 9b0141f105f5..985e1a7cd254 100644
@@ -1,7 +1,7 @@
 if MMP_DISP
 
 config MMP_FB
-	bool "fb driver for Marvell MMP Display Subsystem"
+	tristate "fb driver for Marvell MMP Display Subsystem"
 	depends on FB
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
#1 lore raw

PATCH 1/1 video/mmpfb: allow modular build

Quoted 26 lines · Arnd Bergmann

The frame buffer core can be a module, which means any fb drivers should be able to build as modules too. This turns mmpfb into a tristate option to allow that and fix a possible randconfig build error.

drivers/built-in.o: In function `modes_setup':
:(.text+0x11b34): undefined reference to fb_videomode_to_modelist' :(.text+0x11b5c): undefined reference to fb_videomode_to_var'

Signed-off-by Arnd Bergmann <[email protected]>
drivers/video/fbdev/mmp/Makefile +3 -1
index a014cb358bf8..924dd0930cc7 100644
@@ -1 +1,3 @@
-obj-y += core.o hw/ panel/ fb/
+obj-$(CONFIG_MMP_DISP) += mmp_disp.o hw/ panel/ fb/
+
+mmp_disp-y		+= core.o
drivers/video/fbdev/mmp/fb/Kconfig +0 -0
index 9b0141f105f5..985e1a7cd254 100644

drivers/video/fbdev/mmp/fb/Kconfig line 7

Quoted 8 lines
drivers/video/fbdev/mmp/fb/Kconfig +1 -1
@@ -1,7 +1,7 @@
 if MMP_DISP
 
 config MMP_FB
-	bool "fb driver for Marvell MMP Display Subsystem"
+	tristate "fb driver for Marvell MMP Display Subsystem"
 	depends on FB
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA

Thanks, queued for 3.20.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150130/1b19b5db/attachment.sig>