Add R8A7791/Henninger board DT support
Subsystems (4)
cover Add R8A7791/Henninger board DT support
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.15-rc2-20140421' tag. Here we add support for the R8A7791- based Henninger board AKA R-Car M2 Low Cost Development Platform (M2-LCDP); this board is very like already supported Koelsch board, although some differences do exist. The board can be booted using the device tree only, with no pre-requisites...
[1/2] ARM: shmobile: Henninger: initial device tree [2/2] ARM: shmobile: Henninger: add Ether DT support
WBR, Sergei
PATCH 1/2 ARM: shmobile: henninger: initial device tree
Add the initial device tree for the R8A7791 SoC based Henninger board. SCIF0 serial port support is included, so that the serial console can work.
--- arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7791-henninger.dts | 50 ++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+)
arch/arm/boot/dts/Makefile +1 -0
@@ -321,6 +321,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_LEGACY) += r7 sh7372-mackerel.dtb dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += emev2-kzm9d.dtb \ r7s72100-genmai-reference.dtb \ + r8a7791-henninger.dtb \ r8a7791-koelsch.dtb \ r8a7790-lager.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \
arch/arm/boot/dts/r8a7791-henninger.dts new file +50 -0
50 lines not on this page · raw message
PATCH 2/2 ARM: shmobile: henninger: add Ether DT support
In reply to Sergei ShtylyovDefine the Henninger board dependent part of the Ether device node. Enable DHCP and NFS root for the kernel booting.
--- arch/arm/boot/dts/r8a7791-henninger.dts | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7791-henninger.dts +27 -1
@@ -21,7 +21,7 @@ }; chosen { - bootargs = "console=ttySC0,38400 ignore_loglevel"; + bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp"; }; memory at 40000000 {
@@ -40,6 +40,16 @@ renesas,groups = "scif0_data_d"; renesas,function = "scif0"; }; + + ether_pins: ether { + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; + renesas,function = "eth"; + }; + + phy1_pins: phy1 { + renesas,groups = "intc_irq0"; + renesas,function = "intc"; + }; }; &scif0 {
@@ -48,3 +58,19 @@ status = "okay"; }; + +ðer { + pinctrl-0 = <ðer_pins &phy1_pins>; + pinctrl-names = "default"; + + phy-handle = <&phy1>; + renesas,ether-link-active-low; + status = "ok"; + + phy1: ethernet-phy at 1 { + reg = <1>; + interrupt-parent = <&irqc0>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + micrel,led-mode = <1>; + }; +};
cover Add R8A7791/Henninger board DT support
In reply to Sergei ShtylyovQuoted 11 lines · Sergei Shtylyov
Hello.
Here's the set of 2 patches against Simon Horman's 'renesas.git' repo,
'renesas-devel-v3.15-rc2-20140421' tag. Here we add support for the R8A7791- based Henninger board AKA R-Car M2 Low Cost Development Platform (M2-LCDP); this board is very like already supported Koelsch board, although some differences do exist. The board can be booted using the device tree only, with no pre-requisites...[1/2] ARM: shmobile: Henninger: initial device tree [2/2] ARM: shmobile: Henninger: add Ether DT support
Thanks, I have queued these up.
N.B: I do not currently have access to a Henninger board.
So unlike other boards for ARM-based Renesas SoCs that are present in mainline I will not be boot-testing patches for this board.
PATCH 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovAdd the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.
arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
arch/arm/boot/dts/Makefile +1 -0
@@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme r8a7791-koelsch.dtb \ r8a7791-porter.dtb \ r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ socfpga_arria10_socdk.dtb \
arch/arm/boot/dts/r8a7794-silk.dts new file +41 -0
41 lines not on this page · raw message
PATCH 1/1 ARM: shmobile: silk: initial device tree
Quoted 45 lines · Sergei Shtylyov
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)Index: renesas/arch/arm/boot/dts/Makefile
===================================================================arch/arm/boot/dts/Makefile +1
-0@@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme r8a7791-koelsch.dtb \ r8a7791-porter.dtb \ r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ socfpga_arria10_socdk.dtb \Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +15
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" +
arch/arm/boot/dts/r8a7794-silk.dts line 25
Quoted 10 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +10
-0+/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794"; + + aliases { + serial0 = &scif2; + }; + + chosen { + bootargs = "console=ttySC0,38400 ignore_loglevel";
Please remove console= for consistency with other boards based on Renesas SoCs.
Quoted 22 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +16
-1+ stdout-path = &scif2; + }; + + memory at 40000000 { + device_type = "memory"; + reg = <0 0x40000000 0 0x40000000>; + }; +}; + +&extal_clk { + clock-frequency = <20000000>; +}; + +&scif2 { + status = "okay"; +}; --To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 ARM: shmobile: silk: initial device tree
Hello.
Quoted 12 lines · Simon Horman
Quoted 12 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)
[...]
Quoted 25 lines
Quoted 25 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +20
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794"; + + aliases {
Quoted 8 lines
arch/arm/boot/dts/r8a7794-silk.dts line 25
Quoted 5 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +5
-0+ serial0 = &scif2; + }; + + chosen { + bootargs = "console=ttySC0,38400 ignore_loglevel";Please remove console= for consistency with other boards based on Renesas SoCs.
I can't, there will be no console at all.
WBR, Sergei
PATCH 1/1 ARM: shmobile: silk: initial device tree
Hi Sergei,
Quoted 52 lines · Sergei Shtylyov
Hello.
Quoted 12 lines · Simon Horman
Quoted 12 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)[...]
Quoted 25 lines
Quoted 25 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +20
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794"; + + aliases {Quoted 8 lines
arch/arm/boot/dts/r8a7794-silk.dts line 25
Quoted 5 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +5
-0+ serial0 = &scif2; + }; + + chosen { + bootargs = "console=ttySC0,38400 ignore_loglevel";Please remove console= for consistency with other boards based on Renesas SoCs.
Quoted 1 line
I can't, there will be no console at all.
Its not clear to me why that should be the case when you also have:
stdout-path = &scif2;
Is this a baud issue? If so is it possible to set uboot to 115200 bps? This would be consistent with the way other boards are handled in mainline.
PATCH 1/1 ARM: shmobile: silk: initial device tree
Quoted 55 lines · Simon Horman
Hi Sergei,
Quoted 52 lines · Sergei Shtylyov
Hello.
Quoted 12 lines · Simon Horman
Quoted 12 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)[...]
Quoted 33 lines
Quoted 20 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +15
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" +arch/arm/boot/dts/r8a7794-silk.dts line 25
Quoted 10 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +10
-0+/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794"; + + aliases { + serial0 = &scif2; + }; + + chosen { + bootargs = "console=ttySC0,38400 ignore_loglevel";Please remove console= for consistency with other boards based on Renesas SoCs.
Quoted 8 lines
Quoted 1 line
I can't, there will be no console at all.
Its not clear to me why that should be the case when you also have:
stdout-path = &scif2;Is this a baud issue? If so is it possible to set uboot to 115200 bps? This would be consistent with the way other boards are handled in mainline.
If it's not possible to update the bootloader, the other option is to use the console parametuers in stdout-path, e.g.
stdout-path = "serial0:38400n8";
That way all the console stuff should get set up as expected without a command line being required. As far as I am aware, an explicit command line should then override this if necessary.
Mark.
PATCH 1/1 ARM: shmobile: silk: initial device tree
In reply to Simon HormanQuoted 48 lines · Simon Horman
Quoted 47 lines
Quoted 12 lines
Quoted 12 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)[...]
Quoted 33 lines
Quoted 20 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +15
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" +arch/arm/boot/dts/r8a7794-silk.dts line 25
Quoted 10 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +10
-0+/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794"; + + aliases { + serial0 = &scif2; + }; + + chosen { + bootargs = "console=ttySC0,38400 ignore_loglevel";Please remove console= for consistency with other boards based on Renesas SoCs.
Quoted 7 lines
Quoted 1 line
I can't, there will be no console at all.
Its not clear to me why that should be the case when you also have:
stdout-path = &scif2;Is this a baud issue?
Don't think so, I would have seen at least some garbage on the console.
There was nothing. I'm still not sure what the problem was...
Quoted 1 line
If so is it possible to set uboot to 115200 bps?
Possible with the new board.
WBR, Sergei
PATCH 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovQuoted 37 lines · Sergei Shtylyov
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)Index: renesas/arch/arm/boot/dts/Makefile
===================================================================arch/arm/boot/dts/Makefile +1
-0@@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme r8a7791-koelsch.dtb \ r8a7791-porter.dtb \ r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ socfpga_arria10_socdk.dtb \Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +7
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + *
arch/arm/boot/dts/r8a7794-silk.dts line 17
Quoted 10 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +10
-0+ * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK";
Shouldn't that have a "Renesas" prefix or something like that?
It's unlikely that there will be another board called "SILK", but it does make it hard for someone to get an idea of what the board is from the model string alone.
Mark.
PATCH 1/1 ARM: shmobile: silk: initial device tree
Hello.
Quoted 4 lines · Mark Rutland
Quoted 4 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>
[...]
Quoted 16 lines
Quoted 16 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +11
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */
Quoted 8 lines
arch/arm/boot/dts/r8a7794-silk.dts line 17
Quoted 6 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +6
-0+ +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK";Shouldn't that have a "Renesas" prefix or something like that?
Historically. no SH-Mobile .dts has used the vendor name in the "model"
prop. I defer the decision to Simon but I think we should be at least consistent.
Quoted 3 lines
It's unlikely that there will be another board called "SILK", but it does make it hard for someone to get an idea of what the board is from the model string alone.
Tend to agree here.
Quoted 1 line
Mark.
WBR, Sergei
PATCH 1/1 ARM: shmobile: silk: initial device tree
Quoted 36 lines · Sergei Shtylyov
Hello.
Quoted 4 lines · Mark Rutland
Quoted 4 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>[...]
Quoted 16 lines
Quoted 16 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +11
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */Quoted 8 lines
arch/arm/boot/dts/r8a7794-silk.dts line 17
Quoted 6 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +6
-0+ +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK";Shouldn't that have a "Renesas" prefix or something like that?
Quoted 3 lines
Historically. no SH-Mobile .dts has used the vendor name in the "model"
prop. I defer the decision to Simon but I think we should be at least consistent.
They are also my thoughts (except the bit about deferring to myself).
If there is a good motivation for a Renesas prefix then that is fine by me. But in that case it seems that it would be appropriate to update the existing renesas boards too.
The only thing that stood out to me about "SILK" was that unlike other renesas boards names in .dtsi files it is all-capitals. Its not a bit deal but as we are on the topic: is that intentional?
Quoted 10 lines
Quoted 3 lines
It's unlikely that there will be another board called "SILK", but it does make it hard for someone to get an idea of what the board is from the model string alone.
Tend to agree here.
Quoted 1 line
Mark.
WBR, Sergei
PATCH 1/1 ARM: shmobile: silk: initial device tree
Quoted 3 lines · Simon Horman
The only thing that stood out to me about "SILK" was that unlike other renesas boards names in .dtsi files it is all-capitals. Its not a bit deal but as we are on the topic: is that intentional?
Seems like we can use some consistency:
$ git grep -w model -- $(git grep -l renesas, -- arch/arm/boot/dts) arch/arm/boot/dts/emev2-kzm9d.dts: model = "EMEV2 KZM9D Board"; arch/arm/boot/dts/r7s72100-genmai.dts: model = "Genmai"; arch/arm/boot/dts/r8a73a4-ape6evm.dts: model = "APE6EVM"; arch/arm/boot/dts/r8a7740-armadillo800eva.dts: model = "armadillo 800 eva"; arch/arm/boot/dts/r8a7778-bockw-reference.dts: model = "bockw"; arch/arm/boot/dts/r8a7778-bockw.dts: model = "bockw"; arch/arm/boot/dts/r8a7779-marzen.dts: model = "marzen"; arch/arm/boot/dts/r8a7790-lager.dts: model = "Lager"; arch/arm/boot/dts/r8a7791-henninger.dts: model = "Henninger"; arch/arm/boot/dts/r8a7791-koelsch.dts: model = "Koelsch"; arch/arm/boot/dts/r8a7794-alt.dts: model = "Alt"; arch/arm/boot/dts/sh73a0-kzm9g.dts: model = "KZM-A9-GT"; $
ePAPR says:
"The recommended format is: ?manufacturer,model?, where manufacturer is a
string describing the name of the manufacturer (such as a stock ticker symbol), and model specifies the model number.
Example:
model = ?fsl,MPC8349EMITX?;"
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 ARM: shmobile: silk: initial device tree
Quoted 22 lines · Geert Uytterhoeven
Quoted 3 lines · Simon Horman
The only thing that stood out to me about "SILK" was that unlike other renesas boards names in .dtsi files it is all-capitals. Its not a bit deal but as we are on the topic: is that intentional?
Seems like we can use some consistency:
$ git grep -w model -- $(git grep -l renesas, -- arch/arm/boot/dts) arch/arm/boot/dts/emev2-kzm9d.dts: model = "EMEV2 KZM9D Board"; arch/arm/boot/dts/r7s72100-genmai.dts: model = "Genmai"; arch/arm/boot/dts/r8a73a4-ape6evm.dts: model = "APE6EVM"; arch/arm/boot/dts/r8a7740-armadillo800eva.dts: model = "armadillo 800 eva"; arch/arm/boot/dts/r8a7778-bockw-reference.dts: model = "bockw"; arch/arm/boot/dts/r8a7778-bockw.dts: model = "bockw"; arch/arm/boot/dts/r8a7779-marzen.dts: model = "marzen"; arch/arm/boot/dts/r8a7790-lager.dts: model = "Lager"; arch/arm/boot/dts/r8a7791-henninger.dts: model = "Henninger"; arch/arm/boot/dts/r8a7791-koelsch.dts: model = "Koelsch"; arch/arm/boot/dts/r8a7794-alt.dts: model = "Alt"; arch/arm/boot/dts/sh73a0-kzm9g.dts: model = "KZM-A9-GT"; $
Quoted 8 lines
ePAPR says:
"The recommended format is: ?manufacturer,model?, where manufacturer is a
string describing the name of the manufacturer (such as a stock ticker symbol), and model specifies the model number.Example:
model = ?fsl,MPC8349EMITX?;"
Agree we could use some consistency but before we start cooking up names do we expect this to have any effect on compatibility for users?
PATCH 1/1 ARM: shmobile: silk: initial device tree
In reply to Simon HormanHello.
Quoted 38 lines · Simon Horman
Quoted 32 lines
Quoted 4 lines
Quoted 4 lines
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>[...]
Quoted 16 lines
Quoted 16 lines
Index:
renesas/arch/arm/boot/dts/r8a7794-silk.dts
===================================================================arch/arm/boot/dts/r8a7794-silk.dts new file +11
-0@@ -0,0 +1,41 @@ +/* + * Device Tree Source for the SILK board + * + * Copyright (C) 2014 Renesas Electronics Corporation + * Copyright (C) 2014-2015 Renesas Solutions Corp. + * Copyright (C) 2014-2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */Quoted 8 lines
arch/arm/boot/dts/r8a7794-silk.dts line 17
Quoted 6 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +6
-0+ +/dts-v1/; +#include "r8a7794.dtsi" + +/ { + model = "SILK";Shouldn't that have a "Renesas" prefix or something like that?
Quoted 3 lines
Historically. no SH-Mobile .dts has used the vendor name in the "model"
prop. I defer the decision to Simon but I think we should be at least consistent.They are also my thoughts (except the bit about deferring to myself).
Quoted 7 lines
If there is a good motivation for a Renesas prefix then that is fine by me. But in that case it seems that it would be appropriate to update the existing renesas boards too.
The only thing that stood out to me about "SILK" was that unlike other renesas boards names in .dtsi files it is all-capitals. Its not a bit deal but as we are on the topic: is that intentional?
Yes, it is all uppercase. See e.g. http://www.elinux.org/R-Car/Boards/SILK.
WBR, Sergei
PATCH 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovHello.
Quoted 18 lines · Sergei Shtylyov
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon Horman's 'renesas.git' repo.arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 41 +++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+)Index: renesas/arch/arm/boot/dts/Makefile
===================================================================
arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme · line 422
Quoted 2 lines
arch/arm/boot/dts/Makefile +0
-0@@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme r8a7791-koelsch.dtb \ r8a7791-porter.dtb \
Oops, the patch was additionally against the Henninger->Porter rename
patch. I will fix that.
arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme · line 425
Quoted 3 lines
arch/arm/boot/dts/Makefile +1
-0r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb
WBR, Sergei
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
In reply to Sergei ShtylyovDefine the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura <[email protected]>.
---
This patch is against 'renesas-devel-20150211-v3.19' tag of Simon Horman's 'renesas.git' repo. It needs the R8A7794 PFC driver patch in order to work.
arch/arm/boot/dts/r8a7794.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm/boot/dts/r8a7794.dtsi +6 -0
@@ -107,6 +107,12 @@ <0 17 IRQ_TYPE_LEVEL_HIGH>; }; + pfc: pin-controller at e6060000 { + compatible = "renesas,pfc-r8a7794"; + reg = <0 0xe6060000 0 0x11c>; + #gpio-range-cells = <3>; + }; + dmac0: dma-controller at e6700000 { compatible = "renesas,rcar-dmac"; reg = <0 0xe6700000 0 0x20000>;
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
Quoted 5 lines · Sergei Shtylyov
Define the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura <[email protected]>.
Signed-off-by Sergei Shtylyov <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
Quoted 9 lines · Geert Uytterhoeven
Quoted 5 lines · Sergei Shtylyov
Define the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura <[email protected]>.
Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, I have queued this up.
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
Quoted 5 lines · Simon Horman
Quoted 4 lines · Geert Uytterhoeven
Quoted 2 lines · Sergei Shtylyov
Define the generic R8A7794 part of the PFC device node.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Based on original patch by Hisashi Nakamura <[email protected]>.
Signed-off-by Sergei Shtylyov <[email protected]>Thanks, I have queued this up.
Sorry, I was a bit hasty here.
Could you repost this once the driver has been accepted?
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
Hello.
Quoted 6 lines · Simon Horman
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Define the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura <[email protected]>.
Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Thanks, I have queued this up.
Sorry, I was a bit hasty here.
Could you repost this once the driver has been accepted?
I don't expect it to change, but OK.
WBR, Sergei
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
Hello.
Quoted 9 lines · Sergei Shtylyov
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 6 lines
Define the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura
<[email protected]>.Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Thanks, I have queued this up.
Sorry, I was a bit hasty here.
Could you repost this once the driver has been accepted?
I don't expect it to change, but OK.
Sent v2 last night but overlooked Geert's ACK to v1. Should I resend?
MBR, Sergei
PATCH 1/1 ARM: shmobile: r8a7794: add PFC DT support
Quoted 15 lines · Sergei Shtylyov
Hello.
Quoted 10 lines · Sergei Shtylyov
Quoted 10 lines
Quoted 10 lines
Quoted 8 lines
Quoted 6 lines
Define the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura
<[email protected]>.Signed-off-by Sergei Shtylyov <[email protected]>Thanks, I have queued this up.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Sorry, I was a bit hasty here.
Could you repost this once the driver has been accepted?
I don't expect it to change, but OK.
Sent v2 last night but overlooked Geert's ACK to v1. Should I resend?
No need, I have queued up v2 with Geert's ACK.
Thanks for bringing the ACK to my attention,
I would surely have missed it otherwise.
PATCH v2 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovAdd the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Based on the original patch by Vladimir Barinov
<[email protected]>.
---
This patch is against the 'renesas-devel-20150211-v3.19' tag of Simon Horman's 'renesas.git' repo. It requires just posted R8A7794 PFC DT patch in order to compile, and R8A7794 PFC driver patch in order for the pins to be configured.
Changes in version 2:
- removed "console=" parameter from the kernel command line;
- added PFC node with SCIF2 pins subnode and referred it from the SCIF2 node;
- rebased the patch
- mentioned the origin of patch in the changelog.
arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 51 +++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+)
arch/arm/boot/dts/Makefile +1 -0
@@ -421,6 +421,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += eme r8a7791-henninger.dtb \ r8a7791-koelsch.dtb \ r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_arria5_socdk.dtb \ socfpga_arria10_socdk.dtb \
arch/arm/boot/dts/r8a7794-silk.dts new file +51 -0
51 lines not on this page · raw message
PATCH 1/1 ARM: shmobile: silk: add Ether DT support
In reply to Sergei ShtylyovDefine the SILK board dependent part of the Ether device node. Enable DHCP and NFS root for the kernel booting.
Based on the original patch by Vladimir Barinov
<[email protected]>.
---
This patch is against the 'renesas-devel-20150211-v3.19' tag of Simon Horman's 'renesas.git' repo. It depends on just posted SILK board initial DT patch in order to apply, on just posted R8A7794 PFC DT patch in order to compile, and on R8A7794 PFC driver patch in order for the pins to be configured.
arch/arm/boot/dts/r8a7794-silk.dts | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-silk.dts +27 -1
@@ -22,7 +22,7 @@ }; chosen { - bootargs = "ignore_loglevel"; + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; stdout-path = &scif2; };
@@ -41,6 +41,16 @@ renesas,groups = "scif2_data"; renesas,function = "scif2"; }; + + ether_pins: ether { + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; + renesas,function = "eth"; + }; + + phy1_pins: phy1 { + renesas,groups = "intc_irq8"; + renesas,function = "intc"; + }; }; &scif2 {
@@ -49,3 +59,19 @@ status = "okay"; }; + +ðer { + pinctrl-0 = <ðer_pins &phy1_pins>; + pinctrl-names = "default"; + + phy-handle = <&phy1>; + renesas,ether-link-active-low; + status = "okay"; + + phy1: ethernet-phy at 1 { + reg = <1>; + interrupt-parent = <&irqc0>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; + micrel,led-mode = <1>; + }; +};
PATCH v2 1/1 ARM: shmobile: r8a7794: add PFC DT support
In reply to Sergei ShtylyovDefine the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura <[email protected]>.
---
This patch is against 'renesas-devel-20150727-v4.2-rc4' tag of Simon Horman's 'renesas.git' repo.
Changes in version 2:
- refreshed the patch.
arch/arm/boot/dts/r8a7794.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)
arch/arm/boot/dts/r8a7794.dtsi +6 -0
@@ -108,6 +108,12 @@ clocks = <&mstp4_clks R8A7794_CLK_IRQC>; }; + pfc: pin-controller at e6060000 { + compatible = "renesas,pfc-r8a7794"; + reg = <0 0xe6060000 0 0x11c>; + #gpio-range-cells = <3>; + }; + dmac0: dma-controller at e6700000 { compatible = "renesas,rcar-dmac"; reg = <0 0xe6700000 0 0x20000>;
PATCH v2 1/1 ARM: shmobile: r8a7794: add PFC DT support
Quoted 5 lines · Sergei Shtylyov
Define the generic R8A7794 part of the PFC device node.
Based on original patch by Hisashi Nakamura <[email protected]>.
Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, I have queued this up.
PATCH v3 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovAdd the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Based on the original patch by Vladimir Barinov
<[email protected]>.
---
This patch is against the 'renesas-devel-20150728-v4.2-rc4' tag of Simon Horman's 'renesas.git' repo. It requires R8A7794 PFC DT patch posted yesterday in order to compile.
Changes in version 3:
- refreshed the patch;
- reformatted the changelog.
Changes in version 2:
- removed "console=" parameter from the kernel command line;
- added PFC node with SCIF2 pins subnode and referred it from the SCIF2 node;
- rebased the patch
- mentioned the origin of patch in the changelog.
arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7794-silk.dts | 51 +++++++++++++++++++++++++++++++++++++ 2 files changed, 52 insertions(+)
arch/arm/boot/dts/Makefile +1 -0
@@ -515,6 +515,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += \ r8a7791-koelsch.dtb \ r8a7793-gose.dtb \ r8a7794-alt.dtb \ + r8a7794-silk.dtb \ sh73a0-kzm9g.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += \ socfpga_arria5_socdk.dtb \
arch/arm/boot/dts/r8a7794-silk.dts new file +51 -0
51 lines not on this page · raw message
PATCH v3 1/1 ARM: shmobile: silk: initial device tree
Quoted 7 lines · Sergei Shtylyov
Add the initial device tree for the R8A7794 SoC based SILK low cost board. SCIF2 serial port support is included, so that the serial console can work.
Based on the original patch by Vladimir Barinov
<[email protected]>.Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, I have queued this up.
PATCH v3 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovHi Sergei,
arch/arm/boot/dts/r8a7794-silk.dts line 18
Quoted 7 lines · Sergei Shtylyov
arch/arm/boot/dts/r8a7794-silk.dts new file +3
-0@@ -0,0 +1,51 @@ +/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794";
WARNING: DT compatible string "renesas,silk" appears un-documented -- check ./Documentation/devicetree/bindings/
Do you plan to update Documentation/devicetree/bindings/arm/shmobile.txt?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH v3 1/1 ARM: shmobile: silk: initial device tree
Hello.
Quoted 4 lines · Geert Uytterhoeven
Quoted 3 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +0
-0@@ -0,0 +1,51 @@
Quoted 8 lines
arch/arm/boot/dts/r8a7794-silk.dts line 18
Quoted 3 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +3
-0+/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794";WARNING: DT compatible string "renesas,silk" appears un-documented -- check
./Documentation/devicetree/bindings/Do you plan to update
Documentation/devicetree/bindings/arm/shmobile.txt?
No, I had no idea I should record the board names somewhere too...
Quoted 5 lines
Thanks!
Gr{oetje,eeting}s,
Geert
MBR, Sergei
PATCH v3 1/1 ARM: shmobile: silk: initial device tree
Hi Sergei,
Quoted 9 lines · Sergei Shtylyov
Quoted 7 lines · Geert Uytterhoeven
Quoted 7 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +3
-0@@ -0,0 +1,51 @@ +/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794";
Quoted 6 lines
Quoted 4 lines
WARNING: DT compatible string "renesas,silk" appears un-documented -- check
./Documentation/devicetree/bindings/Do you plan to update
Documentation/devicetree/bindings/arm/shmobile.txt?No, I had no idea I should record the board names somewhere too...
All "compatible" values should be documented before being used in a .dts(i) file.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH v3 1/1 ARM: shmobile: silk: initial device tree
In reply to Sergei ShtylyovQuoted 12 lines · Sergei Shtylyov
Hello.
Quoted 7 lines · Geert Uytterhoeven
Quoted 7 lines
arch/arm/boot/dts/r8a7794-silk.dts new file +3
-0@@ -0,0 +1,51 @@ +/ { + model = "SILK"; + compatible = "renesas,silk", "renesas,r8a7794";
Quoted 6 lines
Quoted 4 lines
WARNING: DT compatible string "renesas,silk" appears un-documented -- check
./Documentation/devicetree/bindings/Do you plan to update
Documentation/devicetree/bindings/arm/shmobile.txt?No, I had no idea I should record the board names somewhere too...
Sergei, please submit a parch as suggested by Geert.
PATCH RESEND 1/1 ARM: shmobile: silk: add Ether DT support
In reply to Sergei ShtylyovDefine the SILK board dependent part of the Ether device node. Enable DHCP and NFS root for the kernel booting.
Based on the original patch by Vladimir Barinov
<[email protected]>.
---
This patch is against the 'renesas-devel-20150728-v4.2-rc4' tag of Simon Horman's 'renesas.git' repo. It depends on just posted SILK board initial DT patch in order to apply and on R8A7794 PFC DT patch posted yesterday in order to compile.
arch/arm/boot/dts/r8a7794-silk.dts | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-silk.dts +27 -1
@@ -22,7 +22,7 @@ }; chosen { - bootargs = "ignore_loglevel"; + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; stdout-path = &scif2; };
@@ -41,6 +41,16 @@ renesas,groups = "scif2_data"; renesas,function = "scif2"; }; + + ether_pins: ether { + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; + renesas,function = "eth"; + }; + + phy1_pins: phy1 { + renesas,groups = "intc_irq8"; + renesas,function = "intc"; + }; }; &scif2 {
@@ -49,3 +59,19 @@ status = "okay"; }; + +ðer { + pinctrl-0 = <ðer_pins &phy1_pins>; + pinctrl-names = "default"; + + phy-handle = <&phy1>; + renesas,ether-link-active-low; + status = "okay"; + + phy1: ethernet-phy at 1 { + reg = <1>; + interrupt-parent = <&irqc0>; + interrupts = <8 IRQ_TYPE_LEVEL_LOW>; + micrel,led-mode = <1>; + }; +};
PATCH RESEND 1/1 ARM: shmobile: silk: add Ether DT support
Quoted 7 lines · Sergei Shtylyov
Define the SILK board dependent part of the Ether device node. Enable DHCP and NFS root for the kernel booting.
Based on the original patch by Vladimir Barinov
<[email protected]>.Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, I have queued this up.
PATCH 1/1 DT: mmc: sh_mmcif: fix "compatible" property text
In reply to Sergei ShtylyovThe "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string, and doesn't look for at SoC specific strings currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the others as optional.
--- Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2 -2
@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties: -- compatible: must contain one of the following +- compatible: must contain "renesas,sh-mmcif"; may also contain one of + the following: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF - clocks: reference to the functional clock
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
Hello.
Quoted 3 lines · Sergei Shtylyov
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string, and doesn't look for at SoC specific strings
"For" not needed here.
Quoted 5 lines
currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the others as optional.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>
Do I need to repost?
MBR, Sergei
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
In reply to Sergei ShtylyovHi Sergei,
Quoted 8 lines · Sergei Shtylyov
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string, and doesn't look for at SoC specific strings currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the others as optional.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>
Thanks for your efforts trying to improve the DT binding documentation.
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt and the properties used by the MMCIF dev · line 13
Quoted 13 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2
-2@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties: -- compatible: must contain one of the following +- compatible: must contain "renesas,sh-mmcif"; may also contain one of + the following: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF
As you know, each SoC contains a wide range of on-chip devices and the MMCIF device is just one of them. Exactly how to manage the DT bindings must be up to each maintainer and of course this needs to be aligned with the SoC maintainer and SoC vendor with policies used for SoC support and BSPs and whatnot. Changing policy like this for a single device without at least discussing this with the SoC maintainers does not help.
For Renesas hardware we so far use both SoC part number and optionally a generic binding as well. As commonly expected, the DT binding is supposed to describe the hardware and if hardware devices are compatible. Unless we use SoC part number in the compatible string there is a risk that the SoC integrator simply copy-and-pastes generic bindings "because it works" but this will result in DT binding based on software compatibility and not hardware compatibility. Later when the driver support is extended this may result in broken software due to incorrect compatibility information through generic bindings.
If anything is unclear please ask and feel free to discuss this DT topic with Simon, Laurent, Geert and/or me.
Thanks,
/ magnus
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
Hello.
Quoted 17 lines · Magnus Damm
Quoted 8 lines
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string, and doesn't look for at SoC specific strings currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the others as optional.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>Thanks for your efforts trying to improve the DT binding documentation.
Quoted 6 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties:
Quoted 15 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt and the properties used by the MMCIF dev · line 13
Quoted 7 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2
-2-- compatible: must contain one of the following +- compatible: must contain "renesas,sh-mmcif"; may also contain one of + the following: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIFAs you know, each SoC contains a wide range of on-chip devices and the MMCIF device is just one of them. Exactly how to manage the DT bindings must be up to each maintainer and of course this needs to be aligned with the SoC maintainer and SoC vendor with policies used for SoC support and BSPs and whatnot. Changing policy like this for a single device without at least discussing this with the SoC maintainers does not help.
I'm not changing the policy, I'm making the binding actually reflect the
driver reality (and even the example given in the binding).
Quoted 10 lines
For Renesas hardware we so far use both SoC part number and optionally a generic binding as well. As commonly expected, the DT binding is supposed to describe the hardware and if hardware devices are compatible. Unless we use SoC part number in the compatible string there is a risk that the SoC integrator simply copy-and-pastes generic bindings "because it works" but this will result in DT binding based on software compatibility and not hardware compatibility. Later when the driver support is extended this may result in broken software due to incorrect compatibility information through generic bindings.
Quoted 2 lines
If anything is unclear please ask and feel free to discuss this DT topic with Simon, Laurent, Geert and/or me.
I didn't quite understand what you're proposing instead. Making SoC based
strings mandatory? Changing the driver to look at the SoC based strings?
Quoted 3 lines
Thanks,
/ magnus
MBR, Sergei
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
Hi Sergei,
Quoted 47 lines · Sergei Shtylyov
Hello.
Quoted 24 lines · Magnus Damm
Quoted 11 lines
The "compatible" property text contradicts even the example given in the MMCIF
binding document itself; moreover, the Renesas MMCIF driver only matches on
the generic "compatible" string, and doesn't look for at SoC specific strings
currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the
others as optional.Quoted 2 lines
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>Thanks for your efforts trying to improve the DT binding documentation.
Quoted 6 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties:Quoted 16 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt and the properties used by the MMCIF dev · line 13
Quoted 7 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2
-2-- compatible: must contain one of the following +- compatible: must contain "renesas,sh-mmcif"; may also contain one of + the following: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIFAs you know, each SoC contains a wide range of on-chip devices and the MMCIF device is just one of them. Exactly how to manage the DT bindings must be up to each maintainer and of course this needs to be aligned with the SoC maintainer and SoC vendor with policies used for SoC support and BSPs and whatnot. Changing policy like this for a single device without at least discussing this with the SoC maintainers does not help.
Quoted 2 lines
I'm not changing the policy, I'm making the binding actually reflect the
driver reality (and even the example given in the binding).
Adjusting the binding after driver implementation seems a bit reverse to me.
The way I see it, first you make a DT binding describing the hardware. Then as second step, you make sure the device driver support the hardware and the DT binding. As third or second parallel step you integrate via a DT.
If you are concerned about the order of the compatible strings, unless specified by the SoC vendor documentation it is in my opinion up to each driver maintainer and/or developer to judge if the hardware is compatible or not. So the development activity of determining if the devices are compatible shall result in a correct compat string order. I'm not so sure if it is required that this order is supposed to be documented in the DT binding. Being more clear does not hurt though.
Quoted 10 lines
Quoted 9 lines
For Renesas hardware we so far use both SoC part number and optionally a generic binding as well. As commonly expected, the DT binding is supposed to describe the hardware and if hardware devices are compatible. Unless we use SoC part number in the compatible string there is a risk that the SoC integrator simply copy-and-pastes generic bindings "because it works" but this will result in DT binding based on software compatibility and not hardware compatibility. Later when the driver support is extended this may result in broken software due to incorrect compatibility information through generic bindings.
Quoted 5 lines
Quoted 2 lines
If anything is unclear please ask and feel free to discuss this DT topic with Simon, Laurent, Geert and/or me.
I didn't quite understand what you're proposing instead. Making SoC based
strings mandatory? Changing the driver to look at the SoC based strings?
I think Laurent describes it pretty well. I'm not sure why you feel that you need to change the driver though, so I wonder if there is some misunderstanding going on here...
Please understand that all the compat strings included in the DT binding document not necessarily have to be used by the driver. But before merging DT integration code it seems customary that the DT binding needs to be documented.
Thanks,
/ magnus
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
Hello.
Quoted 40 lines · Magnus Damm
Quoted 37 lines
Quoted 21 lines
Quoted 10 lines
The "compatible" property text contradicts even the example given in the MMCIF
binding document itself; moreover, the Renesas MMCIF driver only matches on
the generic "compatible" string, and doesn't look for at SoC specific strings
currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the
others as optional.Quoted 2 lines
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>Thanks for your efforts trying to improve the DT binding documentation.
Quoted 6 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties:Quoted 15 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt and the properties used by the MMCIF dev · line 13
Quoted 7 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2
-2-- compatible: must contain one of the following +- compatible: must contain "renesas,sh-mmcif"; may also contain one of + the following: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIFAs you know, each SoC contains a wide range of on-chip devices and the MMCIF device is just one of them. Exactly how to manage the DT bindings must be up to each maintainer and of course this needs to be aligned with the SoC maintainer and SoC vendor with policies used for SoC support and BSPs and whatnot. Changing policy like this for a single device without at least discussing this with the SoC maintainers does not help.
Quoted 2 lines
I'm not changing the policy, I'm making the binding actually reflect the
driver reality (and even the example given in the binding).
Quoted 6 lines
Adjusting the binding after driver implementation seems a bit reverse to me.
The way I see it, first you make a DT binding describing the hardware. Then as second step, you make sure the device driver support the hardware and the DT binding. As third or second parallel step you integrate via a DT.
Everything was done backwards with this binding: first, the driver
implemented the device tree probing, then the bindings were (incorrectly) documented by Laurent.
Quoted 18 lines
If you are concerned about the order of the compatible strings, unless specified by the SoC vendor documentation it is in my opinion up to each driver maintainer and/or developer to judge if the hardware is compatible or not. So the development activity of determining if the devices are compatible shall result in a correct compat string order. I'm not so sure if it is required that this order is supposed to be documented in the DT binding. Being more clear does not hurt though.
Quoted 9 lines
Quoted 9 lines
For Renesas hardware we so far use both SoC part number and optionally a generic binding as well. As commonly expected, the DT binding is supposed to describe the hardware and if hardware devices are compatible. Unless we use SoC part number in the compatible string there is a risk that the SoC integrator simply copy-and-pastes generic bindings "because it works" but this will result in DT binding based on software compatibility and not hardware compatibility. Later when the driver support is extended this may result in broken software due to incorrect compatibility information through generic bindings.
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
If anything is unclear please ask and feel free to discuss this DT topic with Simon, Laurent, Geert and/or me.
I didn't quite understand what you're proposing instead. Making SoC based
strings mandatory? Changing the driver to look at the SoC based strings?I think Laurent describes it pretty well.
The questions now is why he didn't do exactly this when creating the
binding. :-)
Quoted 3 lines
I'm not sure why you feel
that you need to change the driver though, so I wonder if there is some misunderstanding going on here...
I hadn't felt that I need to change the driver before your comment. :-)
Quoted 2 lines
Please understand that all the compat strings included in the DT binding document not necessarily have to be used by the driver.
I understand.
Quoted 3 lines
But
before merging DT integration code it seems customary that the DT binding needs to be documented.
It was documented plainly incorrect, that's what all the fuzz was about on
my side.
Quoted 3 lines
Thanks,
/ magnus
MBR, Sergei
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
In reply to Magnus DammQuoted 8 lines · Magnus Damm
Quoted 8 lines
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string, and doesn't look for at SoC specific strings currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the others as optional.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>
[...]
Quoted 2 lines
If anything is unclear please ask and feel free to discuss this DT topic with Simon, Laurent, Geert and/or me.
BTW, I have raised this question back in February (!). Not much of a
discussion followed:
http://marc.info/?l=linux-sh&m=142436538404802
Quoted 3 lines
Thanks,
/ magnus
MBR, Sergei
Re: [PATCH] DT: mmc: sh_mmcif: fix "compatible" property text
In reply to Magnus DammQuoted 45 lines · On Friday 31 July 2015 11:23:04 Magnus Damm wrote:
Quoted 8 lines · Sergei Shtylyov
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string, and doesn't look for at SoC specific strings currently at all. Thus describe "renesas,sh-mmcif" string as mandatory and the others as optional.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>Thanks for your efforts trying to improve the DT binding documentation.
Quoted 4 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0@@ -6,11 +6,11 @@ and the properties used by the MMCIF devDocumentation/devicetree/bindings/mmc/renesas,mmcif.txt and the properties used by the MMCIF dev · line 14
Quoted 10 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2
-2Required properties: -- compatible: must contain one of the following +- compatible: must contain "renesas,sh-mmcif"; may also contain one of + the following: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIFAs you know, each SoC contains a wide range of on-chip devices and the MMCIF device is just one of them. Exactly how to manage the DT bindings must be up to each maintainer and of course this needs to be aligned with the SoC maintainer and SoC vendor with policies used for SoC support and BSPs and whatnot. Changing policy like this for a single device without at least discussing this with the SoC maintainers does not help.
For Renesas hardware we so far use both SoC part number and optionally a generic binding as well. As commonly expected, the DT binding is supposed to describe the hardware and if hardware devices are compatible. Unless we use SoC part number in the compatible string there is a risk that the SoC integrator simply copy-and-pastes generic bindings "because it works" but this will result in DT binding based on software compatibility and not hardware compatibility. Later when the driver support is extended this may result in broken software due to incorrect compatibility information through generic bindings.
Quoted 2 lines
If anything is unclear please ask and feel free to discuss this DT topic with Simon, Laurent, Geert and/or me.
To clarify this, the current DT compatible strings policy for Renesas SoCs is to use a mandatory SoC-based string followed by a optional generic strings. Optional here refers to the fact that individual DT bindings can decide whether to use a generic string or not, based on hardware information. An IP core that has a different, incompatible implementation for each SoC it is present in can't make use of a generic compatible string. If a particular binding defines generic compatible strings those should be made mandatory by that binding.
In the MMCIF case, I would propose wording it as
- compatible: must contain one of the following
- "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
- "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
- "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
followed by "renesas,sh-mmcif".
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 DT: mmc: sh_mmcif: document R8A779[34] support
In reply to Sergei ShtylyovRenesas R8A7793 and R8A7793 SoC also have the MMCIF controller...
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch plus the patch I posted earlier today...
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2 -0
@@ -11,6 +11,8 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs + - "renesas,mmcif-r8a7793" for the MMCIF found in r8a7793 SoCs + - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs - clocks: reference to the functional clock
PATCH v2 1/1 DT: mmc: sh_mmcif: fix "compatible" property text
In reply to Sergei ShtylyovThe "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches.
Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the generic string a fallback.
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1 -1
@@ -10,7 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF + followed by "renesas,sh-mmcif". - clocks: reference to the functional clock
Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text
Hi Sergei,
Quoted 7 lines · Sergei Shtylyov
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>
I don't believe this file is the appropriate place to describe best-practice for the ordering of compatible strings which must surely be documented elsewhere.
Quoted 29 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches.Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the generic string a fallback.Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Index:
mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1
-2@@ -10,7 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF + followed by "renesas,sh-mmcif". - clocks: reference to the functional clock --To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text
Quoted 11 lines · Simon Horman
Quoted 7 lines
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>I don't believe this file is the appropriate place to describe best-practice for the ordering of compatible strings which must surely be documented elsewhere.
Where? I have no idea what you mean...
And let me reiterate: this text is *wrong* and needs to be fixed anyway.
Quoted 21 lines
Quoted 21 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches.Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the generic string a fallback.Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Index:
mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1
-1@@ -10,7 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF + followed by "renesas,sh-mmcif".
Quoted 1 line
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt Required properties: · line 15
Quoted 1 line
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0- clocks: reference to the functional clock
MBR, Sergei
Re: [PATCH v2] DT: mmc: sh_mmcif: fix "compatible" property text
Quoted 10 lines · Sergei Shtylyov
Quoted 7 lines · Simon Horman
Quoted 7 lines
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 6 lines
Quoted 3 lines
I don't believe this file is the appropriate place to describe best-practice for the ordering of compatible strings which must surely be documented elsewhere.
Where? I have no idea what you mean...
And let me reiterate: this text is *wrong* and needs to be fixed anyway.
The document lists the acceptable compat strings for the driver. Some are currently implemented by the driver. Some are not. This provides a mechanism for enhancing the driver while maintaining compatibility with existing DT blobs.
The document does not describe the way to order the compat strings, which I believe is a more generic issue as many drivers have more and less specific compat strings to describe hardware which is compatible with each other. To some extent I believe it is up to the user, that is the person writing DT files, to understand what the hardware they are dealing with is compatible with. And to some extent I believe the ordering is a best-practice that ought to be described in a high-level document if it is not already.
Your proposed update assumes that all past and future hardware handled by current and future versions of the driver will be compatible with "renesas,sh-mmcif". How can you possibly know that is true?
Quoted 25 lines
Quoted 21 lines
Quoted 21 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' and 'next' branches.Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the generic string a fallback.Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Index:
mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1
-1@@ -10,7 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF + followed by "renesas,sh-mmcif".Quoted 1 line
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt Required properties: · line 15
Quoted 1 line
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0- clocks: reference to the functional clockMBR, Sergei
PATCH v2 1/1 DT: mmc: sh_mmcif: document R8A779[34] support
In reply to Sergei ShtylyovRenesas R8A7794 SoC also has the MMCIF controller...
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch plus the patch I posted earlier today...
Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
- fixed typo in the changelog.
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1 -0
@@ -10,6 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs + - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs followed by "renesas,sh-mmcif". - clocks: reference to the functional clock
Re: [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support
Quoted 3 lines · Sergei Shtylyov
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>
This new compat string looks good to me.
Quoted 7 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch plus the patch I posted earlier today...Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
Perhaps it would be best to co-ordinate the R8A7793 and R8A7794 changes to avoid tedious conflicts.
Quoted 23 lines
- fixed typo in the changelog.
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 1 + 1 file changed, 1 insertion(+)Index:
mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1
-1@@ -10,6 +10,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs + - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs followed by "renesas,sh-mmcif". - clocks: reference to the functional clock --To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support
Hello.
Quoted 7 lines · Simon Horman
Quoted 3 lines
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>This new compat string looks good to me.
Acked-by Simon Horman <[email protected]>
Thank you. I've messed up the subject, so need to re-post.
Quoted 9 lines
Quoted 6 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch plus the patch I posted earlier today...Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;Perhaps it would be best to co-ordinate the R8A7793 and R8A7794 changes to avoid tedious conflicts.
I thought about taking out Ulrich's binding patch and re-posting it along
with this one but finally decided not to ruin his series. Do you mean that I should have posted his patch along with mine?
MBR, Sergei
Re: [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support
[CC: Ulrich, Geert]
Quoted 21 lines · Sergei Shtylyov
Hello.
Quoted 7 lines · Simon Horman
Quoted 3 lines
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>This new compat string looks good to me.
Acked-by Simon Horman <[email protected]>Thank you. I've messed up the subject, so need to re-post.
Quoted 6 lines
Quoted 6 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branch plus the patch I posted earlier today...Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
Quoted 6 lines
Quoted 2 lines
Perhaps it would be best to co-ordinate the R8A7793 and R8A7794 changes to avoid tedious conflicts.
I thought about taking out Ulrich's binding patch and re-posting it along with this one but finally decided not to ruin his series. Do you mean that I should have posted his patch along with mine?
I mean we sould talk about this to come up with a plan that makes things easy for the maintainer to pick up the compat strings for the R8A7793 and R8A7794.
Re: [PATCH v2] DT: mmc: sh_mmcif: document R8A779[34] support
In reply to Sergei ShtylyovQuoted 3 lines · Sergei Shtylyov
I thought about taking out Ulrich's binding patch and re-posting it along
with this one but finally decided not to ruin his series. Do you mean that I should have posted his patch along with mine?
I wouldn't mind that; anything that gets stuff picked up is a win.
CU
Uli
PATCH 1/1 ARM: shmobile: porter: initial device tree
In reply to Sergei ShtylyovAdd the initial device tree for the R8A7791 SoC based Porter low cost board (which is a slightly modified version of the Henninger board).
SCIF0 serial port support is included, so that the serial console can work.
---
This patch is against the 'renesas-devel-20150928-v4.3-rc3' tag of Simon Horman's 'renesas.git' repo.
arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7791-porter.dts | 54 +++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+)
arch/arm/boot/dts/Makefile +1 -0
@@ -532,6 +532,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += \ r8a7790-lager.dtb \ r8a7791-henninger.dtb \ r8a7791-koelsch.dtb \ + r8a7791-porter.dtb \ r8a7793-gose.dtb \ r8a7794-alt.dtb \ r8a7794-silk.dtb \
arch/arm/boot/dts/r8a7791-porter.dts new file +54 -0
54 lines not on this page · raw message
PATCH 1/1 ARM: shmobile: porter: initial device tree
Hi Sergei,
Quoted 2 lines · Sergei Shtylyov
Add the initial device tree for the R8A7791 SoC based Porter low cost board (which is a slightly modified version of the Henninger board).
Can you please tell us more about the differences? It will help us reviewing future DTS updates.
Quoted 1 line
Signed-off-by Sergei Shtylyov <[email protected]>
If you update Documentation/devicetree/bindings/arm/shmobile.txt, you can add my
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH 1/1 ARM: shmobile: porter: initial device tree
Hello.
Quoted 5 lines · Geert Uytterhoeven
Quoted 2 lines
Add the initial device tree for the R8A7791 SoC based Porter low cost board (which is a slightly modified version of the Henninger board).
Can you please tell us more about the differences? It will help us reviewing future DTS updates.
Sorry, I don't have such list handy. I'll be going thru the Henninger
patches one by one and look if they'd need any changes for Porter...
Quoted 3 lines
Quoted 1 line
Signed-off-by Sergei Shtylyov <[email protected]>If you update
Documentation/devicetree/bindings/arm/shmobile.txt, you can
Sorry, forgot about this one for the moment, will do.
Quoted 2 lines
add my
Thank you!
Quoted 3 lines
Gr{oetje,eeting}s,
Geert
MBR, Sergei
PATCH 1/1 ARM: shmobile: porter: initial device tree
In reply to Sergei ShtylyovHello.
Quoted 10 lines · Sergei Shtylyov
Add the initial device tree for the R8A7791 SoC based Porter low cost board (which is a slightly modified version of the Henninger board).
SCIF0 serial port support is included, so that the serial console can work.
Signed-off-by Sergei Shtylyov <[email protected]>---
This patch is against the 'renesas-devel-20150928-v4.3-rc3' tag of Simon Horman's 'renesas.git' repo.
Forgot to mention I had to disable USB-DMAC.
Quoted 18 lines
Index:
renesas/arch/arm/boot/dts/r8a7791-porter.dts
===================================================================arch/arm/boot/dts/r8a7791-porter.dts new file +13
-0@@ -0,0 +1,54 @@ +/* + * Device Tree Source for the Porter board + * + * Copyright (C) 2015 Cogent Embedded, Inc. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +#include "r8a7791.dtsi" +
arch/arm/boot/dts/r8a7791-porter.dts line 23
Quoted 10 lines
arch/arm/boot/dts/r8a7791-porter.dts new file +10
-0+/ { + model = "Porter"; + compatible = "renesas,porter", "renesas,r8a7791"; + + aliases { + serial0 = &scif0; + }; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";
Oops, scratch that. I thought I removed console= but I forgot to refresh
the patch. :-/
MBR, Sergei
PATCH v2 1/2 ARM: shmobile: add Porter board DT bindings
In reply to Sergei ShtylyovAdd Porter device tree bindings documentation, listing it as a supported board.
This allows to use checkpatch to validate DTSes referring to the Porter board.
---
This patch is against the 'renesas-devel-20150930-v4.3-rc3' tag of Simon Horman's 'renesas.git' repo.
Changes in version 2:
- new patch.
Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/arm/shmobile.txt +2 -0
@@ -55,5 +55,7 @@ Boards: compatible = "renesas,lager", "renesas,r8a7790" - Marzen compatible = "renesas,marzen", "renesas,r8a7779" + - Porter (M2-LCDP) + compatible = "renesas,porter", "renesas,r8a7791" - Silk compatible = "renesas,silk", "renesas,r8a7794";
PATCH v2 1/2 ARM: shmobile: add Porter board DT bindings
Quoted 5 lines · Sergei Shtylyov
Add Porter device tree bindings documentation, listing it as a supported board.
This allows to use checkpatch to validate DTSes referring to the Porter board.
Signed-off-by Sergei Shtylyov <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
PATCH v2 1/2 ARM: shmobile: add Porter board DT bindings
In reply to Sergei ShtylyovQuoted 5 lines · Sergei Shtylyov
Add Porter device tree bindings documentation, listing it as a supported board.
This allows to use checkpatch to validate DTSes referring to the Porter board.
Signed-off-by Sergei Shtylyov <[email protected]>
Thanks Sergei,
I have queued this and the following patch up for v4.4.
PATCH v2 2/2 ARM: shmobile: porter: initial device tree
In reply to Sergei ShtylyovAdd the initial device tree for the R8A7791 SoC based Porter low cost board (which is a slightly modified version of the Henninger board).
SCIF0 serial port support is included, so that the serial console can work.
---
This patch is against the 'renesas-devel-20150930-v4.3-rc3' tag of Simon Horman's 'renesas.git' repo.
Changes in version 2:
- removed the 'console=' kernel parameter from the "bootargs" prop;
- removed trailing space in the change log;
- added Geert's ACK.
arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a7791-porter.dts | 54 +++++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+)
arch/arm/boot/dts/Makefile +1 -0
@@ -532,6 +532,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += \ r8a7790-lager.dtb \ r8a7791-henninger.dtb \ r8a7791-koelsch.dtb \ + r8a7791-porter.dtb \ r8a7793-gose.dtb \ r8a7794-alt.dtb \ r8a7794-silk.dtb \
arch/arm/boot/dts/r8a7791-porter.dts new file +54 -0
54 lines not on this page · raw message
PATCH 1/1 ARM: shmobile: fix SILK board name
In reply to Sergei ShtylyovUnfortunately, the SILK board bindings were not quite correct, as the board name should be all caps. Fix that, adding the board model # in parens and removing stray semicolon.
--- Documentation/devicetree/bindings/arm/shmobile.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/arm/shmobile.txt +2 -2
@@ -57,5 +57,5 @@ Boards: compatible = "renesas,marzen", "renesas,r8a7779" - Porter (M2-LCDP) compatible = "renesas,porter", "renesas,r8a7791" - - Silk - compatible = "renesas,silk", "renesas,r8a7794"; + - SILK (RTP0RC7794LCB00011S) + compatible = "renesas,silk", "renesas,r8a7794"
PATCH 1/1 ARM: shmobile: fix SILK board name
Quoted 5 lines · Sergei Shtylyov
Unfortunately, the SILK board bindings were not quite correct, as the board name should be all caps. Fix that, adding the board model # in parens and removing stray semicolon.
Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, I have queued this up.
PATCH 1/1 ARM: shmobile: porter: add Ether DT support
In reply to Sergei ShtylyovDefine the Porter board dependent part of the Ether device node. Enable DHCP and NFS root for the kernel booting.
This patch is analogous to the commit 26b0d2cf73cb (ARM: shmobile: henninger:
add Ether DT support) as there are no differences between those boards in this respect.
---
This patch is against the 'renesas-devel-20151005-v4.3-rc4' tag of Simon Horman's 'renesas.git' repo.
arch/arm/boot/dts/r8a7791-porter.dts | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-)
arch/arm/boot/dts/r8a7791-porter.dts +27 -1
@@ -20,7 +20,7 @@ }; chosen { - bootargs = "ignore_loglevel"; + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp"; stdout-path = &scif0; };
@@ -44,6 +44,16 @@ renesas,groups = "scif0_data_d"; renesas,function = "scif0"; }; + + ether_pins: ether { + renesas,groups = "eth_link", "eth_mdio", "eth_rmii"; + renesas,function = "eth"; + }; + + phy1_pins: phy1 { + renesas,groups = "intc_irq0"; + renesas,function = "intc"; + }; }; &scif0 {
@@ -52,3 +62,19 @@ status = "okay"; }; + +ðer { + pinctrl-0 = <ðer_pins &phy1_pins>; + pinctrl-names = "default"; + + phy-handle = <&phy1>; + renesas,ether-link-active-low; + status = "ok"; + + phy1: ethernet-phy at 1 { + reg = <1>; + interrupt-parent = <&irqc0>; + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; + micrel,led-mode = <1>; + }; +};
PATCH 1/1 ARM: shmobile: porter: add Ether DT support
Quoted 10 lines · Sergei Shtylyov
Define the Porter board dependent part of the Ether device node. Enable DHCP and NFS root for the kernel booting.
This patch is analogous to the commit
26b0d2cf73cb(ARM: shmobile: henninger:
add Ether DT support) as there are no differences between those boards in this respect.Signed-off-by Sergei Shtylyov <[email protected]>---
Thanks, I have queued this up.
PATCH v3 1/1 DT: mmc: sh_mmcif: fix "compatible" property text
In reply to Sergei ShtylyovThe "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' or 'next' branches.
Changes in version 3:
- reworded the "compatible" property description to look like the majority of the Renesas bindings.
Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the generic string a fallback.
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2 -2
@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties: -- compatible: must contain one of the following +- compatible: should be "renesas,mmcif-<soctype>", "renesas,sh-mmcif" as a + fallback. Examples with <soctype> are: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF - clocks: reference to the functional clock
Re: [PATCH v3] DT: mmc: sh_mmcif: fix "compatible" property text
Quoted 7 lines · Sergei Shtylyov
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")Signed-off-by Sergei Shtylyov <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
A message that is not in the archive (sent off-list or not yet received): 2188985.g7lrY44qCa-gHKXc3Y1Z8zGSmamagVegGFoWSdPRAKMAL8bYrjMMd8@public.gmane.org
Ulf Hansson
AppliedRe: [PATCH v3] DT: mmc: sh_mmcif: fix "compatible" property text
Quoted 7 lines · Sergei Shtylyov
The "compatible" property text contradicts even the example given in the MMCIF binding document itself; moreover, the Renesas MMCIF driver only matches on the generic "compatible" string and doesn't look for the SoC specific strings at all. Thus describe "renesas,sh-mmcif" as a fallback value.
Fixes b4c27763d749 ("mmc: sh_mmcif: Document DT bindings")
Thanks, applied for next.
Kind regards
Uffe
Quoted 24 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'fixes' or 'next' branches.Changes in version 3:
- reworded the "compatible" property description to look like the majority of the Renesas bindings.Changes in version 2:
- kept the SoC specific "compatible" property values mandatory and made the generic string a fallback.Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)Index:
mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +0
-0@@ -6,11 +6,11 @@ and the properties used by the MMCIF dev Required properties:
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt and the properties used by the MMCIF dev · line 16
Quoted 10 lines
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +2
-2-- compatible: must contain one of the following +- compatible: should be "renesas,mmcif-<soctype>", "renesas,sh-mmcif" as a + fallback. Examples with <soctype> are: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs - - "renesas,sh-mmcif" for the generic MMCIF - clocks: reference to the functional clock
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH v3 1/1 DT: mmc: sh_mmcif: document R8A779[34] support
In reply to Sergei ShtylyovRenesas R8A7794 SoC also has the MMCIF controller...
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branches plus the patch I posted earlier today...
Changes in version 3:
- resolved reject.
Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
- fixed typo in the changelog.
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1 -0
@@ -11,6 +11,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs + - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs - clocks: reference to the functional clock
Re: [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support
Quoted 3 lines · Sergei Shtylyov
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Ulf Hansson
AppliedRe: [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support
In reply to Sergei ShtylyovQuoted 3 lines · Sergei Shtylyov
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>
Thanks, applied for next.
Kind regards
Uffe
Quoted 28 lines
---
The patch is against Ulf Hansson's 'mmc.git' repo's 'next' branches plus the patch I posted earlier today...Changes in version 3:
- resolved reject.Changes in version 2:
- deferred R8A7793 support to the patch posted earlier by Ulrich Hecht;
- fixed typo in the changelog.Documentation/devicetree/bindings/mmc/renesas,mmcif.txt | 1 + 1 file changed, 1 insertion(+)Index:
mmc/Documentation/devicetree/bindings/mmc/renesas,mmcif.txt
===================================================================Documentation/devicetree/bindings/mmc/renesas,mmcif.txt +1
-0@@ -11,6 +11,7 @@ Required properties: - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs + - "renesas,mmcif-r8a7794" for the MMCIF found in r8a7794 SoCs - clocks: reference to the functional clock
Re: [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support
Hello.
Quoted 5 lines · Ulf Hansson
Quoted 3 lines
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>Thanks, applied for next.
Oops, just noticed the subject was stale. I wasn't adding R8A7793 support
in that version. Is it possible to fix?
Quoted 2 lines
Kind regards
Uffe
[...]
MBR, Sergei
A message that is not in the archive (sent off-list or not yet received): 5626A1CF.9050309-M4DtvfQ/[email protected]
Re: [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support
Quoted 6 lines · Sergei Shtylyov
Hello.
Quoted 2 lines · Ulf Hansson
Quoted 2 lines
Renesas R8A7794 SoC also has the MMCIF controller...
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Thanks, applied for next.
Oops, just noticed the subject was stale. I wasn't adding R8A7793 support
in that version. Is it possible to fix?
I have updated the subject, no worries!
Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support
Hello.
Quoted 5 lines · Ulf Hansson
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Thanks, applied for next.
Oops, just noticed the subject was stale. I wasn't adding R8A7793 support
in that version. Is it possible to fix?I have updated the subject, no worries!
Perfect! Thanks a lot. :-)
Quoted 2 lines
Kind regards
Uffe
MBR, Sergei
Re: [PATCH v3] DT: mmc: sh_mmcif: document R8A779[34] support
In reply to Sergei ShtylyovHi Sergei,
Quoted 9 lines · Sergei Shtylyov
Quoted 5 lines · Ulf Hansson
Quoted 3 lines
Renesas R8A7794 SoC also has the MMCIF controller...
Signed-off-by Sergei Shtylyov <[email protected]>Thanks, applied for next.
Oops, just noticed the subject was stale. I wasn't adding R8A7793 support
in that version. Is it possible to fix?
Hah, and that made me mark Ulrich's patch for r8a7793 as obsolete in patchwork :-(
Picked up and sent out.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds