Skip to contentSkip to conversation

tzset.3: ffix

PATCH In review J William Piggott 2 participants 4 messages Feb 1, 2015 – Feb 3, 2015 3 messages not in the archive Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tzset.3: ffix

Fix tzset.3 regression, dst is optional.

$ date
Sun Feb  1 15:14:33 EST 2015
$ TZ=NZST-12 date
Mon Feb  2 08:14:38 NZST 2015
$ TZ=EST5 date
Sun Feb  1 15:15:02 EST 2015
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man3/tzset.3 +1 -1
index 1253241..7a4dd6a 100644
@@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
 timezone to be used:
 .sp
 .RS
-.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
+.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
 .RE
 .sp
 There are no spaces in the specification.

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi William,

Quoted 20 lines · J William Piggott

Fix tzset.3 regression, dst is optional.

$ date
Sun Feb  1 15:14:33 EST 2015
$ TZ=NZST-12 date
Mon Feb  2 08:14:38 NZST 2015
$ TZ=EST5 date
Sun Feb  1 15:15:02 EST 2015
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man3/tzset.3 +0 -0
index 1253241..7a4dd6a 100644

man3/tzset.3 The first format is a string of characters that directly represent the · line 101

Quoted 8 lines
man3/tzset.3 +1 -1
@@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
 timezone to be used:
 .sp
 .RS
-.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
+.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
 .RE
 .sp
 There are no spaces in the specification.

Thanks, I've applied this, and then also made some more changes to bring make that line a bit more consistent with formatting norm in man pages.

Cheers,

Michael

Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): CAKgNAkjSUeKOXUHG5AU8ipVVxiATaJAb2WFnqgz-Y0KVNgL5pw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw

Hello Michael,

Quoted 27 lines · Michael Kerrisk (man-pages)

Hi William,

Quoted 24 lines · J William Piggott

Fix tzset.3 regression, dst is optional.

$ date
Sun Feb  1 15:14:33 EST 2015
$ TZ=NZST-12 date
Mon Feb  2 08:14:38 NZST 2015
$ TZ=EST5 date
Sun Feb  1 15:15:02 EST 2015
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man3/tzset.3 +0 -1
index 1253241..7a4dd6a 100644
@@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
 timezone to be used:
 .sp
 .RS
-.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
Quoted 8 lines

man3/tzset.3 The first format is a string of characters that directly represent the · line 101

Quoted 4 lines
man3/tzset.3 +1 -0
+.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
 .RE
 .sp
 There are no spaces in the specification.

Thanks, I've applied this, and then also made some more changes to bring make that line a bit more consistent with formatting norm in man pages.

My thinking regarding the format, was that because so much of the string is optional, contrasting the compulsory part makes it easier to parse. Did you look at how it rendered before changing it? It also highlights that portion as unique, as it is illustrated with a space that does not exist when put into use; that is not true for the rest of the string. I think it is good to have it standout. I would have made it bold, but that is for commands and might have been confusing.

Well, it is better now either-way compared to the whole thing being italic as it was before.

Have a great day everyone.

Quoted 5 lines

Cheers,

Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw

Hi Willliam,

Quoted 47 lines · J William Piggott

Hello Michael,

Quoted 27 lines · Michael Kerrisk (man-pages)

Hi William,

Quoted 24 lines · J William Piggott

Fix tzset.3 regression, dst is optional.

$ date
Sun Feb  1 15:14:33 EST 2015
$ TZ=NZST-12 date
Mon Feb  2 08:14:38 NZST 2015
$ TZ=EST5 date
Sun Feb  1 15:15:02 EST 2015
---
 man3/tzset.3 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
man3/tzset.3 +0 -1
index 1253241..7a4dd6a 100644
@@ -95,7 +95,7 @@ The first format is a string of characters that directly represent the
 timezone to be used:
 .sp
 .RS
-.RI "std offset " dst [ offset ][, start [ /time ], end [ /time ]]
Quoted 8 lines

man3/tzset.3 The first format is a string of characters that directly represent the · line 101

Quoted 4 lines
man3/tzset.3 +1 -0
+.RI "std offset[" dst [ offset ][, start [ /time ], end [ /time ]]]
 .RE
 .sp
 There are no spaces in the specification.

Thanks, I've applied this, and then also made some more changes to bring make that line a bit more consistent with formatting norm in man pages.

My thinking regarding the format, was that because so much of the string is optional, contrasting the compulsory part makes it easier to parse. Did you look at how it rendered before changing it? It also highlights that portion as unique, as it is illustrated with a space that does not exist when put into use; that is not true for the rest of the string. I think it is good to have it standout. I would have made it bold, but that is for commands and might have been confusing.

Quoted 2 lines

Well, it is better now either-way compared to the whole thing being italic as it was before.

I made the format this way mainly for overall consistency. The '[]' should be enough for folk to work out what's optional.

Thanks,

Michael

Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html