x86/devicetree: Fix build for amd64
PATCH 1/1 x86/devicetree: Fix build for amd64
apic_force_enable is not defined for amd64.
Without this patch:
LD init/built-in.oarch/x86/built-in.o: In function `dtb_lapic_setup':kernel/devicetree.c:155:
undefined reference to `apic_force_enable' Makefile:923: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1
--- arch/x86/kernel/devicetree.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kernel/devicetree.c +2 -0
@@ -152,7 +152,9 @@ static void __init dtb_lapic_setup(void)/* Did the boot loader setup the local APIC ? */ if (!cpu_has_apic) { +#ifndef CONFIG_X86_64 if (apic_force_enable(r.start)) +#endif return ; } smp_found_config =1 ;
Signature · 1 line
2.1.4
Hi Ricardo,
How about defining a version of apic_force_enable()
for X86_64 in apic.h which just return failure? Regards!
Gerry
Quoted 31 lines · Ricardo Ribalda Delgado
apic_force_enableis not defined for amd64.Without this patch:
LD
init/built-in.oarch/x86/built-in.o: In function `dtb_lapic_setup':kernel/devicetree.c:155:
undefined reference to `apic_force_enable' Makefile:923: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1Signed-off-by Ricardo Ribalda Delgado <[email protected]>--- arch/x86/kernel/devicetree.c | 2 ++ 1 file changed, 2 insertions(+)arch/x86/kernel/devicetree.c +2
-0@@ -152,7 +152,9 @@ static void __init dtb_lapic_setup(void)/* Did the boot loader setup the local APIC ? */ if (!cpu_has_apic) { +#ifndef CONFIG_X86_64 if (apic_force_enable(r.start)) +#endif return ; } smp_found_config =1 ;
Hello,
That is also an option, but I thought this was cleaner. If you prefer it that way I can prepare a patch.
Regards
Quoted 38 lines · Jiang Liu
Hi Ricardo,
How about defining a version ofapic_force_enable()
forX86_64inapic.hwhich just return failure? Regards!
GerryQuoted 31 lines · Ricardo Ribalda Delgado
apic_force_enableis not defined for amd64.Without this patch:
LD
init/built-in.oarch/x86/built-in.o: In function `dtb_lapic_setup':kernel/devicetree.c:155:
undefined reference to `apic_force_enable' Makefile:923: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1Signed-off-by Ricardo Ribalda Delgado <[email protected]>--- arch/x86/kernel/devicetree.c | 2 ++ 1 file changed, 2 insertions(+)arch/x86/kernel/devicetree.c +2
-0@@ -152,7 +152,9 @@ static void __init dtb_lapic_setup(void)/* Did the boot loader setup the local APIC ? */ if (!cpu_has_apic) { +#ifndef CONFIG_X86_64 if (apic_force_enable(r.start)) +#endif return ; } smp_found_config =1 ;
Signature · 1 line
Ricardo Ribalda