Skip to contentSkip to conversation

layer conf: update to include meta-networking

PATCH In review Armin Kuster 2 participants 5 messages Feb 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 layer conf: update to include meta-networking

suricata needs a package in meta-networking

---
 conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
conf/layer.conf +1 -1
index c5a717b..650e6ed 100644
@@ -9,4 +9,4 @@ BBFILE_COLLECTIONS += "security"
 BBFILE_PATTERN_security = "^${LAYERDIR}/"
 BBFILE_PRIORITY_security = "6"
 
-LAYERDEPENDS_security = "openembedded-layer perl-layer"
+LAYERDEPENDS_security = "openembedded-layer perl-layer networking-layer"
Signature · 1 line
1.9.1
#1 lore raw
Quoted 12 lines · On Monday 02 February 2015 07:35:51 Armin Kuster wrote:

suricata needs a package in meta-networking

---
 conf/layer.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
conf/layer.conf +0 -0
index c5a717b..650e6ed 100644

conf/layer.conf BBFILE_COLLECTIONS += "security" · line 12

Quoted 5 lines
conf/layer.conf +1 -1
@@ -9,4 +9,4 @@ BBFILE_COLLECTIONS += "security"
 BBFILE_PATTERN_security = "^${LAYERDIR}/"
 BBFILE_PRIORITY_security = "6"
 
-LAYERDEPENDS_security = "openembedded-layer perl-layer"
+LAYERDEPENDS_security = "openembedded-layer perl-layer networking-layer"

Can you please also update the OE layer index?

http://layers.openembedded.org/layerindex/branch/master/layer/meta-security/

I added meta-perl and meta-oe this morning based on the meta-security README - the latter isn't represented in your LAYERDEPENDS value though, so all three places ought to be made consistent with whatever the actual set of requirements is.

(If people are starting to use LAYERDEPENDS a bit more it might make sense for us to add some code to the layer index update script to try to update its dependency list based upon LAYERDEPENDS and BBFILE_COLLECTIONS; up to now it hasn't seen a huge amount of use hence I hadn't done that.)

Thanks,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#2 lore raw

Paul,

Is the idea to include all layers required including the cascaded ones?

i.e: meta-networking requires mete-python, should I include that one too?

Quoted 16 lines · Paul Eggleton
Quoted 15 lines · On Monday 02 February 2015 07:35:51 Armin Kuster wrote:

suricata needs a package in meta-networking

---
  conf/layer.conf | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
conf/layer.conf +0 -0
index c5a717b..650e6ed 100644
@@ -9,4 +9,4 @@ BBFILE_COLLECTIONS += "security"
  BBFILE_PATTERN_security = "^${LAYERDIR}/"
  BBFILE_PRIORITY_security = "6"
 
Quoted 4 lines

conf/layer.conf BBFILE_COLLECTIONS += "security" · line 12

Quoted 2 lines
conf/layer.conf +1 -1
-LAYERDEPENDS_security = "openembedded-layer perl-layer"
+LAYERDEPENDS_security = "openembedded-layer perl-layer networking-layer"

Can you please also update the OE layer index?

Do I do that manually or is it picked up from the README?

- armin

Quoted 16 lines

http://layers.openembedded.org/layerindex/branch/master/layer/meta-security/

I added meta-perl and meta-oe this morning based on the meta-security README - the latter isn't represented in your LAYERDEPENDS value though, so all three places ought to be made consistent with whatever the actual set of requirements is.

(If people are starting to use LAYERDEPENDS a bit more it might make sense for us to add some code to the layer index update script to try to update its dependency list based upon LAYERDEPENDS and BBFILE_COLLECTIONS; up to now it hasn't seen a huge amount of use hence I hadn't done that.)

Thanks,
Paul

#3 lore raw
Quoted 4 lines · On Monday 02 February 2015 10:24:21 akuster808 wrote:
Quoted 1 line · Paul Eggleton

Can you please also update the OE layer index?

Do I do that manually or is it picked up from the README?

No, it needs to be done manually, I don't have anything to parse a README and extract dependencies at the moment.

Quoted 8 lines
Quoted 8 lines

http://layers.openembedded.org/layerindex/branch/master/layer/meta-securit
y/

I added meta-perl and meta-oe this morning based on the meta-security README - the latter isn't represented in your LAYERDEPENDS value though, so all three places ought to be made consistent with whatever the actual set of requirements is.

Quoted 8 lines
Quoted 4 lines

(If people are starting to use LAYERDEPENDS a bit more it might make sense for us to add some code to the layer index update script to try to update its dependency list based upon LAYERDEPENDS and BBFILE_COLLECTIONS; up to now it hasn't seen a huge amount of use hence I hadn't done that.)

Is the idea to include all layers required including the cascaded ones?

i.e: meta-networking requires mete-python, should I include that one too?

No, no need to do that - just the direct dependencies is enough.

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
author
#4 lore raw

layer index updated.

I will update README next.

thanks,
Armin

Quoted 31 lines · Paul Eggleton
Quoted 4 lines · On Monday 02 February 2015 10:24:21 akuster808 wrote:
Quoted 1 line · Paul Eggleton

Can you please also update the OE layer index?

Do I do that manually or is it picked up from the README?

No, it needs to be done manually, I don't have anything to parse a README and extract dependencies at the moment.

Quoted 8 lines
Quoted 8 lines

http://layers.openembedded.org/layerindex/branch/master/layer/meta-securit
y/

I added meta-perl and meta-oe this morning based on the meta-security README - the latter isn't represented in your LAYERDEPENDS value though, so all three places ought to be made consistent with whatever the actual set of requirements is.

Quoted 8 lines
Quoted 4 lines

(If people are starting to use LAYERDEPENDS a bit more it might make sense for us to add some code to the layer index update script to try to update its dependency list based upon LAYERDEPENDS and BBFILE_COLLECTIONS; up to now it hasn't seen a huge amount of use hence I hadn't done that.)

Is the idea to include all layers required including the cascaded ones?

i.e: meta-networking requires mete-python, should I include that one too?

No, no need to do that - just the direct dependencies is enough.

Cheers,
Paul