ARM: shmobile: alt dts: Drop console= bootargs parameter

PATCH New Simon Horman 3 participants 7 messages Nov 4, 2014 – Feb 4, 2015

Subsystems (2)

Device tree bindings SuperH

lore

Share & tools

lore

Simon Horman

author

2014-11-04 04:23 UTC #0 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.

This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.

Cc Ulrich Hecht <[email protected]>

Cc Geert Uytterhoeven <[email protected]>

Cc devicetree at vger.kernel.org

Signed-off-by Simon Horman <[email protected]>

---
 arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/r8a7794-alt.dts +1 -1

index 8aec512..f2cf757 100644
@@ -20,7 +20,7 @@
 	};
 
 	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
 		stdout-path = &scif2;
 	};

Signature · 1 line

2.1.1

Simon Horman

2014-11-05 05:54 UTC #1 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

Quoted 11 lines · Simon Horman

Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.
This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.
Cc Ulrich Hecht <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc devicetree at vger.kernel.org
Signed-off-by Simon Horman <[email protected]>

I have queued this up.

Quoted 20 lines

---
 arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/r8a7794-alt.dts +1 -1

index 8aec512..f2cf757 100644
@@ -20,7 +20,7 @@
 	};
 
 	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
 		stdout-path = &scif2;
 	};

Signature · 1 line

2.1.1

Sergei Shtylyov

2015-01-30 21:49 UTC #2 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

In reply to Simon Horman

Hello.

Quoted 6 lines · Simon Horman

Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.
This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.

I'd say it's not very practical to change the console's baud rate from
U-Boot's default (AFAIR changing baud rate in U-Boot didn't work)...

Quoted 13 lines

Cc Ulrich Hecht <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc devicetree at vger.kernel.org
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-alt.dts +0 -0
index 8aec512..f2cf757 100644

arch/arm/boot/dts/r8a7794-alt.dts line 23

Quoted 5 lines

arch/arm/boot/dts/r8a7794-alt.dts +1 -1

@@ -20,7 +20,7 @@
  	};
 
  	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";

Hm, does this even work as intended? I've tried to boot another R8A7794
based board and I couldn't get any output with alike command line. Booting with 'earlyprintk=serial' has shown that tty0 was enabled as a console which is not what we wanted.

WBR, Sergei

Simon Horman

2015-01-31 04:17 UTC #3 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

Hi Sergei,

Quoted 7 lines · Sergei Shtylyov

Hello.
Quoted 2 lines · Simon Horman
Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.

Quoted 6 lines

Quoted 3 lines
This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.
I'd say it's not very practical to change the console's baud rate from
U-Boot's default

It is consistent with the handling of all other boards with renesas SoCs that are present in mainline.

Quoted 1 line

(AFAIR changing baud rate in U-Boot didn't work)...

Perhaps that relates to the version of built of uboot. On the board I have access to I see:

ver=U-Boot 2013.01.01-g5df9446 (Oct 01 2014 - 14:59:23)

And the following setting altered the baud rate of u-boot (IIRC).

baudrate=115200

Quoted 15 lines

Quoted 15 lines
Cc Ulrich Hecht <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc devicetree at vger.kernel.org
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-alt.dts +0 -0
index 8aec512..f2cf757 100644
@@ -20,7 +20,7 @@
 	};
 

Quoted 8 lines

arch/arm/boot/dts/r8a7794-alt.dts line 23
Quoted 3 lines
arch/arm/boot/dts/r8a7794-alt.dts +1 -1
 	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
Hm, does this even work as intended? I've tried to boot another R8A7794
based board and I couldn't get any output with alike command line. Booting with 'earlyprintk=serial' has shown that tty0 was enabled as a console which is not what we wanted.

If you are backporting this change then I believe it has some dependencies that I can follow up on if it is useful to you.

If you are using mainline (e.g. next or renesas-next) then yes, it works. I have tested it numerous times since the patch was merged.

Sergei Shtylyov

2015-02-02 22:10 UTC #4 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

Hello.

Quoted 7 lines · Simon Horman

Quoted 6 lines
Quoted 6 lines
Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.
This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.

Quoted 5 lines

Quoted 2 lines
I'd say it's not very practical to change the console's baud rate from
U-Boot's default
It is consistent with the handling of all other boards with renesas SoCs that are present in mainline.

Well, not quite: Henninger/Porter is still using 38400.

Quoted 1 line

Quoted 1 line
(AFAIR changing baud rate in U-Boot didn't work)...

That was a recollection from the other board though, I haven't yet tried
to do it on the SILK board (and I'm unable to currently as the power supply seems dead).

Quoted 4 lines

Perhaps that relates to the version of built of uboot. On the board I have access to I see:
ver=U-Boot 2013.01.01-g5df9446 (Oct 01 2014 - 14:59:23)

U-Boot 2013.01.01 (Oct 17 2014 - 20:59:18)

Quoted 3 lines

And the following setting altered the baud rate of u-boot (IIRC).
baudrate=115200

I was going to try that but the board just didn't power up.

Quoted 24 lines

Quoted 15 lines
Quoted 15 lines
Cc Ulrich Hecht <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc devicetree at vger.kernel.org
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-alt.dts +0 -0
index 8aec512..f2cf757 100644
@@ -20,7 +20,7 @@
  	};
 
Quoted 8 lines
arch/arm/boot/dts/r8a7794-alt.dts line 23
Quoted 3 lines
arch/arm/boot/dts/r8a7794-alt.dts +1 -1
  	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
Hm, does this even work as intended? I've tried to boot another R8A7794
based board and I couldn't get any output with alike command line. Booting with 'earlyprintk=serial' has shown that tty0 was enabled as a console which is not what we wanted.

Quoted 2 lines

If you are backporting this change then I believe it has some dependencies that I can follow up on if it is useful to you.

Contrariwise, I'm forward-porting.

Quoted 2 lines

If you are using mainline (e.g. next or renesas-next) then yes, it works. I have tested it numerous times since the patch was merged.

I'm traditionally using the 'renesas-devel-*' tags.

WBR, Sergei

Simon Horman

2015-02-03 00:41 UTC #5 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

Quoted 14 lines · Sergei Shtylyov

Hello.
Quoted 9 lines · Simon Horman
Quoted 9 lines
Quoted 6 lines
Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.
This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.
I'd say it's not very practical to change the console's baud rate from
U-Boot's default

Quoted 6 lines

Quoted 2 lines
It is consistent with the handling of all other boards with renesas SoCs that are present in mainline.
Well, not quite: Henninger/Porter is still using 38400.
From my point of view that is an oversight which I would have

resolved had I ever obtained access to the hardware.

Quoted 6 lines

Quoted 1 line
Quoted 1 line
(AFAIR changing baud rate in U-Boot didn't work)...
That was a recollection from the other board though, I haven't yet tried
to do it on the SILK board (and I'm unable to currently as the power supply seems dead).

Quoted 6 lines

Quoted 4 lines
Perhaps that relates to the version of built of uboot. On the board I have access to I see:
ver=U-Boot 2013.01.01-g5df9446 (Oct 01 2014 - 14:59:23)
U-Boot 2013.01.01 (Oct 17 2014 - 20:59:18)

It looks like my version has some extra patches (the g5df9446 bit). But I could be reading things wrong.

Quoted 33 lines

Quoted 3 lines
And the following setting altered the baud rate of u-boot (IIRC).
baudrate=115200
I was going to try that but the board just didn't power up.
Quoted 24 lines
Quoted 15 lines
Quoted 15 lines
Cc Ulrich Hecht <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc devicetree at vger.kernel.org
Signed-off-by Simon Horman <[email protected]>
---
 arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-alt.dts +0 -0
index 8aec512..f2cf757 100644
@@ -20,7 +20,7 @@
 	};
 
Quoted 8 lines
arch/arm/boot/dts/r8a7794-alt.dts line 23
Quoted 3 lines
arch/arm/boot/dts/r8a7794-alt.dts +1 -1
 	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
Hm, does this even work as intended? I've tried to boot another R8A7794
based board and I couldn't get any output with alike command line. Booting with 'earlyprintk=serial' has shown that tty0 was enabled as a console which is not what we wanted.
Quoted 2 lines
If you are backporting this change then I believe it has some dependencies that I can follow up on if it is useful to you.

Quoted 6 lines

Contrariwise, I'm forward-porting.
Quoted 2 lines
If you are using mainline (e.g. next or renesas-next) then yes, it works. I have tested it numerous times since the patch was merged.
I'm traditionally using the 'renesas-devel-*' tags.

If you are using 'renesas-devel-*' tags (and forward porting) then you should be in good shape. But if you would like me to verify a particular tag I'm happy to do so. It is not unheard of for different instances of the same board behave in different ways.

Sergei Shtylyov

2015-02-04 22:43 UTC #6 lore raw

PATCH 1/1 ARM: shmobile: alt dts: Drop console= bootargs parameter

Hello.

Quoted 10 lines · Simon Horman

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 6 lines
Alt is booted from DT, so chosen/stdout-path is
always used, and we can drop the "console=" parameter from chosen/bootargs.
This change has a side-effect of changing the console speed from 38400 to 115200. This is intentional as 115200 is consistently used on all other shmobile boards.
I'd say it's not very practical to change the console's baud rate from
U-Boot's default

Quoted 7 lines

Quoted 4 lines
Quoted 2 lines
It is consistent with the handling of all other boards with renesas SoCs that are present in mainline.
Well, not quite: Henninger/Porter is still using 38400.
From my point of view that is an oversight which I would have
resolved had I ever obtained access to the hardware.

I'll look into that when I have time.

Quoted 9 lines

Quoted 8 lines
Quoted 1 line
Quoted 1 line
(AFAIR changing baud rate in U-Boot didn't work)...
That was a recollection from the other board though, I haven't yet tried
to do it on the SILK board (and I'm unable to currently as the power supply seems dead).
Quoted 2 lines
Perhaps that relates to the version of built of uboot. On the board I have access to I see:

Quoted 12 lines

Quoted 3 lines
Quoted 1 line
ver=U-Boot 2013.01.01-g5df9446 (Oct 01 2014 - 14:59:23)
U-Boot 2013.01.01 (Oct 17 2014 - 20:59:18)
It looks like my version has some extra patches (the g5df9446 bit). But I could be reading things wrong.
Quoted 5 lines
Quoted 3 lines
And the following setting altered the baud rate of u-boot (IIRC).
baudrate=115200
I was going to try that but the board just didn't power up.

I have switched to another board now (with newer U-Boot flashed),
and I was able to change the baud rate in U-Boot. However, SPL and U-Boot still start at 38400 and now I'm having garbage instead of the version and hardware info. :-(

Quoted 15 lines

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Cc Ulrich Hecht <[email protected]>
Cc Geert Uytterhoeven <[email protected]>
Cc devicetree at vger.kernel.org
Signed-off-by Simon Horman <[email protected]>
---
  arch/arm/boot/dts/r8a7794-alt.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/r8a7794-alt.dts +0 -0
index 8aec512..f2cf757 100644
@@ -20,7 +20,7 @@
  	};
 

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
arch/arm/boot/dts/r8a7794-alt.dts line 23
Quoted 3 lines
arch/arm/boot/dts/r8a7794-alt.dts +1 -1
  	chosen {
-		bootargs = "console=ttySC0,38400 ignore_loglevel rw root=/dev/nfs ip=dhcp";
+		bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
Hm, does this even work as intended? I've tried to boot another R8A7794
based board and I couldn't get any output with alike command line. Booting with 'earlyprintk=serial' has shown that tty0 was enabled as a console which is not what we wanted.

The kernel console started working automagically for me at 115200 on the
new board.

Quoted 8 lines

Quoted 7 lines
Quoted 2 lines
If you are backporting this change then I believe it has some dependencies that I can follow up on if it is useful to you.
Contrariwise, I'm forward-porting.
Quoted 2 lines
If you are using mainline (e.g. next or renesas-next) then yes, it works. I have tested it numerous times since the patch was merged.

Quoted 6 lines

Quoted 1 line
I'm traditionally using the 'renesas-devel-*' tags.
If you are using 'renesas-devel-*' tags (and forward porting) then you should be in good shape. But if you would like me to verify a particular tag I'm happy to do so. It is not unheard of for different instances of the same board behave in different ways.

Thank you, looks like there's no need now.

WBR, Sergei