Documentation: HAL IPC uses 4 octects for socket channel

PATCH Applied Thomas Zimmermann 2 participants 3 messages Feb 3, 2015 Bluetooth drivers

Share & tools

Thomas Zimmermann

author

2015-02-03 08:47 UTC #0 lore raw

PATCH 1/1 Documentation: HAL IPC uses 4 octects for socket channel

The documentations says that the HAL IPC uses 2 octets for socket channels, while |struct hal_cmd_socket_{listen,connect}| contain 4 octets. This patch fixes the documentation accordingly.

Quoted 1 line

From 53c14fc8c07bf4196b61b3b7809dbe02313c49a7 Mon Sep 17 00:00:00 2001

From: Thomas Zimmermann <[email protected]>
Date: Tue, 3 Feb 2015 09:37:47 +0100
Subject: [PATCH] Documentation: HAL IPC uses 4 octects for socket channel

The documentations says that the HAL IPC uses 2 octets for socket channels, while |struct hal_cmd_socket_{listen,connect}| contain 4 octets. This patch fixes the documentation accordingly.

Signed-off-by Thomas Zimmermann <[email protected]>

---
 android/hal-ipc-api.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

android/hal-ipc-api.txt +2 -2

index f15c12e..515cf4e 100644
@@ -456,7 +456,7 @@ Commands and responses:
 		Command parameters: Socket type (1 octet)
 		                    Service name (256 octets)
 		                    Service UUID (16 octets)
-		                    Channel (2 octets)
+		                    Channel (4 octets)
 		                    Socket flags (1 octet)
 		Response parameters: File descriptor (inline)

@@ -474,7 +474,7 @@ Commands and responses:
 		Command parameters: Remote address (6 octets)
 		                    Socket type (1 octet)
 		                    Service UUID (16 octets)
-		                    Channel (2 octets)
+		                    Channel (4 octets)
 		                    Socket flags (1 octet)
 		Response parameters: File descriptor (inline)

Signature · 1 line

1.7.10.4

Szymon Janc

Applied

2015-02-03 11:35 UTC #1 lore raw

Hi Thomas,

Quoted 3 lines · On Tuesday 03 of February 2015 09:47:59 Thomas Zimmermann wrote:

The documentations says that the HAL IPC uses 2 octets for socket channels, while |struct hal_cmd_socket_{listen,connect}| contain 4 octets. This patch fixes the documentation accordingly.

I've applied the patch, thanks.

Some notes though:
- I've fixed commit message prefix (we try to keep those consistent for easier history view)
- I've removed SoB line - we don't use it in userspace code
- for any future submissions please send patch inline (ie with git send-email) instead of attaching it

Signature · 2 lines

Best regards, 
Szymon Janc

Thomas Zimmermann

author

2015-02-03 11:45 UTC #2 lore raw

Am 03.02.2015 um 12:35 schrieb Szymon Janc:

Quoted 6 lines

Hi Thomas,
Quoted 3 lines · On Tuesday 03 of February 2015 09:47:59 Thomas Zimmermann wrote:
The documentations says that the HAL IPC uses 2 octets for socket channels, while |struct hal_cmd_socket_{listen,connect}| contain 4 octets. This patch fixes the documentation accordingly.

Quoted 8 lines

I've applied the patch, thanks.
Some notes though:
- I've fixed commit message prefix (we try to keep those consistent for easier history view)
- I've removed SoB line - we don't use it in userspace code
- for any future submissions please send patch inline (ie with git send-email) instead of attaching it

Thanks a lot and sorry about the issues. It's my first patch here, I'll try to do better.

Best regards
Thomas