char:ipmi: Free ipmi_recv_msg messages from the linked list,recv_msgs for the function,ipmi_release in the file,ipmi_devintf.c
A message that is not in the archive (sent off-list or not yet received): [email protected]
I've been debating what to do with this, but the patch makes a good change, so
I'll go ahead with it. I am going to remove the unnecessary braces.
In the future, you really need to be able to test the changes you make. So you really
need to work in an area that you can test in. If you are really interested in learning,
you have a ways to go, I think, and the kernel may not be the best place to do that
learning.
-corey
Quoted 35 lines · Nicholas Krause
This adds a loop through the elements in the linked list,
recv_msgsusinglist_for_entry_safein order to free messages in this list. In addition we are using the safe version of this marco in order to prevent use after bugs related to deleting the element we are on currently by holding a pointer to the next element after the current one we are on and freeing with the function,ipmi_free_recv_msginternally in this loop.Signed-off-by Nicholas Krause <[email protected]>--- drivers/char/ipmi/ipmi_devintf.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/char/ipmi/ipmi_devintf.c +6
-1@@ -157,12 +157,17 @@ static int ipmi_release(struct inode *inode, struct file *file) {struct ipmi_file_private *priv = file->private_data;int rv; +struct ipmi_recv_msg *msg, *next; rv =ipmi_destroy_user (priv->user);if (rv)return rv; -/* FIXME - free the messages in the list. */ +list_for_each_entry_safe (msg, next, &priv->recv_msgs, link) { +ipmi_free_recv_msg (msg); + } + +kfree (priv);return 0 ;