Skip to contentSkip to conversation

x86/Kconfig: avoid issuing pointless turned off entries to .config

PATCH New Jan Beulich 2 participants 2 messages Feb 5, 2015 – Feb 19, 2015 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/Kconfig: avoid issuing pointless turned off entries to .config

Settings without prompts shouldn't normally have defaults other than Y, as otherwise they (a) needlessly enlarge the resulting .config and (b) if they ever get a prompt added later, the tracked setting of off will prevent the devloper from then being prompted for his/her choice when doing an incremental update of the configuration (make oldconfig).

---
 arch/x86/Kconfig |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/Kconfig +4 -6
@@ -232,12 +232,10 @@ config ARCH_WANT_GENERAL_HUGETLB
 	def_bool y
 
 config ZONE_DMA32
-	bool
-	default X86_64
+	def_bool y if X86_64
 
 config AUDIT_ARCH
-	bool
-	default X86_64
+	def_bool y if X86_64
 
 config ARCH_SUPPORTS_OPTIMIZED_INLINING
 	def_bool y
@@ -1110,10 +1108,10 @@ config MICROCODE_OLD_INTERFACE
 	depends on MICROCODE
 
 config MICROCODE_INTEL_EARLY
-	def_bool n
+	bool
 
 config MICROCODE_AMD_EARLY
-	def_bool n
+	bool
 
 config MICROCODE_EARLY
 	bool "Early load microcode"
#1 lore raw

[tip:x86/build] x86/Kconfig: Avoid issuing pointless turned off entries to .config

x86/Kconfig: Avoid issuing pointless turned off entries to .config
Commit-ID:  e0fd24a3b4ad7b4084b41944835952eedec53f98
Gitweb:     http://git.kernel.org/tip/e0fd24a3b4ad7b4084b41944835952eedec53f98
Author:     Jan Beulich <[email protected]>
AuthorDate: Thu, 5 Feb 2015 15:39:34 +0000
Committer:  Ingo Molnar <[email protected]>
CommitDate: Wed, 18 Feb 2015 22:08:46 +0100

x86/Kconfig: Avoid issuing pointless turned off entries to .config

Settings without prompts shouldn't normally have defaults other than Y, as otherwise they (a) needlessly enlarge the resulting .config and (b) if they ever get a prompt added later, the tracked setting of off will prevent the devloper from then being prompted for his/her choice when doing an incremental update of the configuration (make oldconfig).

---
 arch/x86/Kconfig | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
arch/x86/Kconfig +4 -6
index 5e28e2b..463d883 100644
@@ -233,12 +233,10 @@ config ARCH_WANT_GENERAL_HUGETLB
 	def_bool y
 
 config ZONE_DMA32
-	bool
-	default X86_64
+	def_bool y if X86_64
 
 config AUDIT_ARCH
-	bool
-	default X86_64
+	def_bool y if X86_64
 
 config ARCH_SUPPORTS_OPTIMIZED_INLINING
 	def_bool y
@@ -1115,10 +1113,10 @@ config MICROCODE_OLD_INTERFACE
 	depends on MICROCODE
 
 config MICROCODE_INTEL_EARLY
-	def_bool n
+	bool
 
 config MICROCODE_AMD_EARLY
-	def_bool n
+	bool
 
 config MICROCODE_EARLY
 	bool "Early load microcode"