mmc: dw_mmc: exynos: Add HS400 support
Subsystems (4)
Alim Akhtar
reviewerv5 cover mmc: dw_mmc: exynos: Add HS400 support
This adds HS400 mode support for exynos dw_mmc host controller.
Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. Tested HS200 mode with this series applied, HS200 still works.
Appreciate testing on other exynos5/7 platform which supports emmc5.0
Changes in V5:
* Enable HS400 on Exynos5800-peach-pi boards
* Addressed other review comments from Jaehoon Chung
Changes in V4:
* drop the idea of changing existing binding for ciu_div as per [1]
* addressed comments from Jaehoon Chung [2]
[1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html
[2] http://www.spinics.net/lists/devicetree/msg64373.html
Changes in V3:
rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static)
Seungwon Jeon (2):
mmc: dw_mmc: exynos: Support eMMC's HS400 mode
ARM: dts: Add HS400 support for exynos5420 and exynos5800
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 9 files changed, 213 insertions(+), 38 deletions(-)
Signature · 1 line
1.7.9.5
Alim Akhtar
reviewerPATCH v5 1/2 mmc: dw_mmc: exynos: Support eMMC's HS400 mode
From: Seungwon Jeon <[email protected]>
Implements HS400 mode support for exynos host driver. This also include some updates as new mode is added.
--- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 5 files changed, 195 insertions(+), 34 deletions(-)
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +7 -0
@@ -36,6 +36,8 @@ Required Properties: in transmit mode and CIU clock phase shift value in receive mode for double data rate mode operation. Refer notes below for the order of the cells and the valid values. +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase + shift value for hs400 mode operation. Notes for the sdr-timing and ddr-timing values:
@@ -50,6 +52,9 @@ Required Properties: - if CIU clock divider value is 0 (that is divide by 1), both tx and rx phase shift clocks should be 0. +* samsung,read-strobe-delay: RCLK (Data strobe) delay to control HS400 mode + (Latency value for delay line in Read path) + Required properties for a slot (Deprecated - Recommend to use one slot per host): * gpios: specifies a list of gpios used for command, clock and data bus. The
@@ -82,5 +87,7 @@ Example: samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>; samsung,dw-mshc-ddr-timing = <1 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; bus-width = <8>; };
drivers/mmc/host/dw_mmc-exynos.c +153 -32
277 lines not on this page · raw message
drivers/mmc/host/dw_mmc-exynos.h +18 -1
@@ -12,20 +12,36 @@#ifndef _DW_MMC_EXYNOS_H_#define _DW_MMC_EXYNOS_H_ -/* Extended Register's Offset */ #define SDMMC_CLKSEL 0x09C#define SDMMC_CLKSEL64 0x0A8 +/* Extended Register's Offset */ +#define SDMMC_HS400_DQS_EN 0x180 +#define SDMMC_HS400_ASYNC_FIFO_CTRL 0x184 +#define SDMMC_HS400_DLINE_CTRL 0x188 +/* CLKSEL register defines */ #define SDMMC_CLKSEL_CCLK_SAMPLE (x) (((x) & 7) << 0)#define SDMMC_CLKSEL_CCLK_DRIVE (x) (((x) & 7) << 16)#define SDMMC_CLKSEL_CCLK_DIVIDER (x) (((x) & 7) << 24)#define SDMMC_CLKSEL_GET_DRV_WD3 (x) (((x) >> 16) & 0x7) +#define SDMMC_CLKSEL_GET_DIV (x) (((x) >> 24) & 0x7) +#define SDMMC_CLKSEL_UP_SAMPLE (x, y) (((x) & ~SDMMC_CLKSEL_CCLK_SAMPLE(7)) |\ + SDMMC_CLKSEL_CCLK_SAMPLE(y))#define SDMMC_CLKSEL_TIMING (x, y, z) (SDMMC_CLKSEL_CCLK_SAMPLE(x) | \ SDMMC_CLKSEL_CCLK_DRIVE(y) | \ SDMMC_CLKSEL_CCLK_DIVIDER(z)) +#define SDMMC_CLKSEL_TIMING_MASK SDMMC_CLKSEL_TIMING(0x7, 0x7, 0x7)#define SDMMC_CLKSEL_WAKEUP_INT BIT(11) +/* RCLK_EN register defines */ +#define DATA_STROBE_EN BIT(0) +#define AXI_NON_BLOCKING_WR BIT(7) + +/* DLINE_CTRL register defines */ +#define DQS_CTRL_RD_DELAY (x, y) (((x) & ~0x3FF) | ((y) & 0x3FF)) +#define DQS_CTRL_GET_RD_DELAY (x) ((x) & 0x3FF) +/* Protector Register */ #define SDMMC_EMMCP_BASE 0x1000#define SDMMC_MPSECURITY (SDMMC_EMMCP_BASE + 0x0010)
@@ -49,6 +65,7 @@/* Fixed clock divider */ #define EXYNOS4210_FIXED_CIU_CLK_DIV 2#define EXYNOS4412_FIXED_CIU_CLK_DIV 4 +#define HS400_FIXED_CIU_CLK_DIV 1/* Minimal required clock frequency for cclkin, unit: HZ */ #define EXYNOS_CCLKIN_MIN 50000000
drivers/mmc/host/dw_mmc.c +15 -1
@@ -1084,7 +1084,8 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) regs =mci_readl (slot->host,UHS_REG );/* DDR mode set */ -if (ios->timing ==MMC_TIMING_MMC_DDR52 ) +if (ios->timing ==MMC_TIMING_MMC_DDR52 || + ios->timing ==MMC_TIMING_MMC_HS400 ) regs |= ((0x1 << slot->id) <<16 );else regs &= ~((0x1 << slot->id) <<16 );
@@ -1323,6 +1324,18 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode)return err; } +int dw_mci_prepare_hs400_tuning (struct mmc_host *mmc,struct mmc_ios *ios) +{ +struct dw_mci_slot *slot =mmc_priv (mmc); +struct dw_mci *host = slot->host; +const struct dw_mci_drv_data *drv_data = host->drv_data; + +if (drv_data && drv_data->prepare_hs400_tuning) +return drv_data->prepare_hs400_tuning (host, ios); + +return 0 ; +} +static const struct mmc_host_ops dw_mci_ops = { .request = dw_mci_request, .pre_req = dw_mci_pre_req,
@@ -1335,6 +1348,7 @@ static const struct mmc_host_ops dw_mci_ops = { .card_busy = dw_mci_card_busy, .start_signal_voltage_switch = dw_mci_switch_voltage, .init_card = dw_mci_init_card, + .prepare_hs400_tuning = dw_mci_prepare_hs400_tuning, };static void dw_mci_request_end (struct dw_mci *host,struct mmc_request *mrq)
drivers/mmc/host/dw_mmc.h +2 -0
@@ -271,5 +271,7 @@ struct dw_mci_drv_data {void (*set_ios)(struct dw_mci *host,struct mmc_ios *ios);int (*parse_dt)(struct dw_mci *host);int (*execute_tuning)(struct dw_mci_slot *slot); +int (*prepare_hs400_tuning)(struct dw_mci *host, + struct mmc_ios *ios); };#endif /* _DW_MMC_H_ */
Signature · 1 line
1.7.9.5
Jaehoon Chung
maintainerPATCH v5 1/2 mmc: dw_mmc: exynos: Support eMMC's HS400 mode
Hi, Alim.
I will include this patch into my tree, and i will request pull to Ulf.
Thanks!
Best Regards,
Jaehoon Chung
Quoted 444 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
Implements HS400 mode support for exynos host driver. This also include some updates as new mode is added.
Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 5 files changed, 195 insertions(+), 34 deletions(-)Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +7
-0@@ -36,6 +36,8 @@ Required Properties: in transmit mode and CIU clock phase shift value in receive mode for double data rate mode operation. Refer notes below for the order of the cells and the valid values. +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase + shift value for hs400 mode operation. Notes for the sdr-timing and ddr-timing values:@@ -50,6 +52,9 @@ Required Properties: - if CIU clock divider value is 0 (that is divide by 1), both tx and rx phase shift clocks should be 0. +* samsung,read-strobe-delay: RCLK (Data strobe) delay to control HS400 mode + (Latency value for delay line in Read path) + Required properties for a slot (Deprecated - Recommend to use one slot per host): * gpios: specifies a list of gpios used for command, clock and data bus. The@@ -82,5 +87,7 @@ Example: samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>; samsung,dw-mshc-ddr-timing = <1 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; bus-width = <8>; };drivers/mmc/host/dw_mmc-exynos.c +153
-32@@ -40,7 +40,12 @@ struct dw_mci_exynos_priv_data {u8 ciu_div;u32 sdr_timing;u32 ddr_timing; +u32 hs400_timing; +u32 tuned_sample;u32 cur_speed; +u32 dqs_delay; +u32 saved_dqs_en; +u32 saved_strobe_ctrl; }; static struct dw_mci_exynos_compatible {@@ -71,6 +76,21 @@ static struct dw_mci_exynos_compatible { }, }; +static inline u8 dw_mci_exynos_get_ciu_div (struct dw_mci *host) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; + +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS4412 ) +return EXYNOS4412_FIXED_CIU_CLK_DIV ; +else if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS4210 ) +return EXYNOS4210_FIXED_CIU_CLK_DIV ; +else if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) +return SDMMC_CLKSEL_GET_DIV (mci_readl (host,CLKSEL64 )) +1 ; +else +return SDMMC_CLKSEL_GET_DIV (mci_readl (host,CLKSEL )) +1 ; +} +static int dw_mci_exynos_priv_init (struct dw_mci *host) {struct dw_mci_exynos_priv_data *priv = host->priv;@@ -85,6 +105,16 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host) SDMMC_MPSCTRL_NON_SECURE_WRITE_BIT); } +if (priv->ctrl_type >=DW_MCI_TYPE_EXYNOS5420 ) { + priv->saved_strobe_ctrl =mci_readl (host,HS400_DLINE_CTRL ); + priv->saved_dqs_en =mci_readl (host,HS400_DQS_EN ); + priv->saved_dqs_en |=AXI_NON_BLOCKING_WR ; +mci_writel (host,HS400_DQS_EN , priv->saved_dqs_en); +if (!priv->dqs_delay) + priv->dqs_delay = +DQS_CTRL_GET_RD_DELAY (priv->saved_strobe_ctrl); + } +return 0 ; }@@ -97,6 +127,26 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host)return 0 ; } +static void dw_mci_exynos_set_clksel_timing (struct dw_mci *host,u32 timing) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; +u32 clksel; + +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) + clksel =mci_readl (host,CLKSEL64 ); +else + clksel =mci_readl (host,CLKSEL ); + + clksel = (clksel & ~SDMMC_CLKSEL_TIMING_MASK ) | timing; + +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) +mci_writel (host,CLKSEL64 , clksel); +else +mci_writel (host,CLKSEL , clksel); +} +#ifdef CONFIG_PM_SLEEP static int dw_mci_exynos_suspend (struct device *dev) {@@ -172,30 +222,38 @@ static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) } } -static void dw_mci_exynos_set_ios (struct dw_mci *host,struct mmc_ios *ios) +static void dw_mci_exynos_config_hs400 (struct dw_mci *host,u32 timing) {struct dw_mci_exynos_priv_data *priv = host->priv; -unsigned int wanted = ios->clock; -unsigned long actual; -u8 div = priv->ciu_div +1 ; +u32 dqs, strobe; -if (ios->timing ==MMC_TIMING_MMC_DDR52 ) { -if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || - priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) -mci_writel (host,CLKSEL64 , priv->ddr_timing); -else -mci_writel (host,CLKSEL , priv->ddr_timing); -/* Should be double rate for DDR mode */ -if (ios->bus_width ==MMC_BUS_WIDTH_8 ) - wanted <<=1 ; +/* +* Not supported to configure register +* related to HS400 +*/ +if (priv->ctrl_type <DW_MCI_TYPE_EXYNOS5420 ) +return ; + + dqs = priv->saved_dqs_en; + strobe = priv->saved_strobe_ctrl; + +if (timing ==MMC_TIMING_MMC_HS400 ) { + dqs |=DATA_STROBE_EN ; + strobe =DQS_CTRL_RD_DELAY (strobe, priv->dqs_delay); }else { -if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || - priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) -mci_writel (host,CLKSEL64 , priv->sdr_timing); -else -mci_writel (host,CLKSEL , priv->sdr_timing); + dqs &= ~DATA_STROBE_EN ; } +mci_writel (host,HS400_DQS_EN , dqs); +mci_writel (host,HS400_DLINE_CTRL , strobe); +} + +static void dw_mci_exynos_adjust_clock (struct dw_mci *host,unsigned int wanted) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; +unsigned long actual; +u8 div; +int ret;/* * Don't care if wanted clock is zero or * ciu clock is unavailable @@ -207,17 +265,52 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios)if (wanted <EXYNOS_CCLKIN_MIN ) wanted =EXYNOS_CCLKIN_MIN ; -if (wanted != priv->cur_speed) { -int ret =clk_set_rate (host->ciu_clk, wanted * div); -if (ret) -dev_warn (host->dev, -"failed to set clk-rate %u error: %d\n" , - wanted * div, ret); - actual =clk_get_rate (host->ciu_clk); - host->bus_hz = actual / div; - priv->cur_speed = wanted; - host->current_speed =0 ; +if (wanted == priv->cur_speed) +return ; + + div =dw_mci_exynos_get_ciu_div (host); + ret =clk_set_rate (host->ciu_clk, wanted * div); +if (ret) +dev_warn (host->dev, +"failed to set clk-rate %u error: %d\n" , + wanted * div, ret); + actual =clk_get_rate (host->ciu_clk); + host->bus_hz = actual / div; + priv->cur_speed = wanted; + host->current_speed =0 ; +} + +static void dw_mci_exynos_set_ios (struct dw_mci *host,struct mmc_ios *ios) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; +unsigned int wanted = ios->clock; +u32 timing = ios->timing, clksel; + +switch (timing) { +case MMC_TIMING_MMC_HS400 : +/* Update tuned sample timing */ + clksel =SDMMC_CLKSEL_UP_SAMPLE ( + priv->hs400_timing, priv->tuned_sample); + wanted <<=1 ; +break ; +case MMC_TIMING_MMC_DDR52 : + clksel = priv->ddr_timing; +/* Should be double rate for DDR mode */ +if (ios->bus_width ==MMC_BUS_WIDTH_8 ) + wanted <<=1 ; +break ; +default : + clksel = priv->sdr_timing; } + +/* Set clock timing for the requested speed mode*/ +dw_mci_exynos_set_clksel_timing (host, clksel); + +/* Configure setting for HS400 */ +dw_mci_exynos_config_hs400 (host, timing); + +/* Configure clock rate */ +dw_mci_exynos_adjust_clock (host, wanted); }static int dw_mci_exynos_parse_dt (struct dw_mci *host)@@ -260,6 +353,16 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)return ret; priv->ddr_timing =SDMMC_CLKSEL_TIMING (timing[0 ], timing[1 ], div); + + ret =of_property_read_u32_array (np, +"samsung,dw-mshc-hs400-timing" , timing,2 ); +if (!ret &&of_property_read_u32 (np, +"samsung,read-strobe-delay" , &priv->dqs_delay)) +dev_dbg (host->dev, +"read-strobe-delay is not found, assuming usage of default value\n" ); + + priv->hs400_timing =SDMMC_CLKSEL_TIMING (timing[0 ], timing[1 ], +HS400_FIXED_CIU_CLK_DIV ); host->priv = priv;return 0 ; }@@ -285,7 +388,7 @@ static inline void dw_mci_exynos_set_clksmpl(struct dw_mci *host, u8 sample) clksel =mci_readl (host,CLKSEL64 ); else clksel =mci_readl (host,CLKSEL ); - clksel = (clksel & ~0x7 ) |SDMMC_CLKSEL_CCLK_SAMPLE (sample); + clksel =SDMMC_CLKSEL_UP_SAMPLE (clksel, sample);if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU )mci_writel (host,CLKSEL64 , clksel);@@ -304,13 +407,16 @@ static inline u8 dw_mci_exynos_move_next_clksmpl(struct dw_mci *host) clksel =mci_readl (host,CLKSEL64 ); else clksel =mci_readl (host,CLKSEL ); + sample = (clksel +1 ) &0x7 ; - clksel = (clksel & ~0x7 ) | sample; + clksel =SDMMC_CLKSEL_UP_SAMPLE (clksel, sample); +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU )mci_writel (host,CLKSEL64 , clksel);else mci_writel (host,CLKSEL , clksel); +return sample; }@@ -343,6 +449,7 @@ out:static int dw_mci_exynos_execute_tuning (struct dw_mci_slot *slot) {struct dw_mci *host = slot->host; +struct dw_mci_exynos_priv_data *priv = host->priv;struct mmc_host *mmc = slot->mmc;u8 start_smpl, smpl, candiates =0 ;s8 found =-1 ;@@ -360,14 +467,27 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) }while (start_smpl != smpl); found =dw_mci_exynos_get_best_clksmpl (candiates); -if (found >=0 ) +if (found >=0 ) {dw_mci_exynos_set_clksmpl (host, found); -else + priv->tuned_sample = found; + }else { ret = -EIO ; + }return ret; } +int dw_mci_exynos_prepare_hs400_tuning (struct dw_mci *host, +struct mmc_ios *ios) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; + +dw_mci_exynos_set_clksel_timing (host, priv->hs400_timing); +dw_mci_exynos_adjust_clock (host, (ios->clock) <<1 ); + +return 0 ; +} +/* Common capabilities of Exynos4/Exynos5 SoC */ static unsigned long exynos_dwmmc_caps[4 ] = {MMC_CAP_1_8V_DDR |MMC_CAP_8_BIT_DATA |MMC_CAP_CMD23 ,@@ -384,6 +504,7 @@ static const struct dw_mci_drv_data exynos_drv_data = { .set_ios = dw_mci_exynos_set_ios, .parse_dt = dw_mci_exynos_parse_dt, .execute_tuning = dw_mci_exynos_execute_tuning, + .prepare_hs400_tuning = dw_mci_exynos_prepare_hs400_tuning, };static const struct of_device_id dw_mci_exynos_match[] = {drivers/mmc/host/dw_mmc-exynos.h +18
-1@@ -12,20 +12,36 @@#ifndef _DW_MMC_EXYNOS_H_#define _DW_MMC_EXYNOS_H_ -/* Extended Register's Offset */ #define SDMMC_CLKSEL 0x09C#define SDMMC_CLKSEL64 0x0A8 +/* Extended Register's Offset */ +#define SDMMC_HS400_DQS_EN 0x180 +#define SDMMC_HS400_ASYNC_FIFO_CTRL 0x184 +#define SDMMC_HS400_DLINE_CTRL 0x188 +/* CLKSEL register defines */ #define SDMMC_CLKSEL_CCLK_SAMPLE (x) (((x) & 7) << 0)#define SDMMC_CLKSEL_CCLK_DRIVE (x) (((x) & 7) << 16)#define SDMMC_CLKSEL_CCLK_DIVIDER (x) (((x) & 7) << 24)#define SDMMC_CLKSEL_GET_DRV_WD3 (x) (((x) >> 16) & 0x7) +#define SDMMC_CLKSEL_GET_DIV (x) (((x) >> 24) & 0x7) +#define SDMMC_CLKSEL_UP_SAMPLE (x, y) (((x) & ~SDMMC_CLKSEL_CCLK_SAMPLE(7)) |\ + SDMMC_CLKSEL_CCLK_SAMPLE(y))#define SDMMC_CLKSEL_TIMING (x, y, z) (SDMMC_CLKSEL_CCLK_SAMPLE(x) | \ SDMMC_CLKSEL_CCLK_DRIVE(y) | \ SDMMC_CLKSEL_CCLK_DIVIDER(z)) +#define SDMMC_CLKSEL_TIMING_MASK SDMMC_CLKSEL_TIMING(0x7, 0x7, 0x7)#define SDMMC_CLKSEL_WAKEUP_INT BIT(11) +/* RCLK_EN register defines */ +#define DATA_STROBE_EN BIT(0) +#define AXI_NON_BLOCKING_WR BIT(7) + +/* DLINE_CTRL register defines */ +#define DQS_CTRL_RD_DELAY (x, y) (((x) & ~0x3FF) | ((y) & 0x3FF)) +#define DQS_CTRL_GET_RD_DELAY (x) ((x) & 0x3FF) +/* Protector Register */ #define SDMMC_EMMCP_BASE 0x1000#define SDMMC_MPSECURITY (SDMMC_EMMCP_BASE + 0x0010)@@ -49,6 +65,7 @@/* Fixed clock divider */ #define EXYNOS4210_FIXED_CIU_CLK_DIV 2#define EXYNOS4412_FIXED_CIU_CLK_DIV 4 +#define HS400_FIXED_CIU_CLK_DIV 1/* Minimal required clock frequency for cclkin, unit: HZ */ #define EXYNOS_CCLKIN_MIN 50000000drivers/mmc/host/dw_mmc.c +15
-1@@ -1084,7 +1084,8 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) regs =mci_readl (slot->host,UHS_REG );/* DDR mode set */ -if (ios->timing ==MMC_TIMING_MMC_DDR52 ) +if (ios->timing ==MMC_TIMING_MMC_DDR52 || + ios->timing ==MMC_TIMING_MMC_HS400 ) regs |= ((0x1 << slot->id) <<16 );else regs &= ~((0x1 << slot->id) <<16 );@@ -1323,6 +1324,18 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode)return err; } +int dw_mci_prepare_hs400_tuning (struct mmc_host *mmc,struct mmc_ios *ios) +{ +struct dw_mci_slot *slot =mmc_priv (mmc); +struct dw_mci *host = slot->host; +const struct dw_mci_drv_data *drv_data = host->drv_data; + +if (drv_data && drv_data->prepare_hs400_tuning) +return drv_data->prepare_hs400_tuning (host, ios); + +return 0 ; +} +static const struct mmc_host_ops dw_mci_ops = { .request = dw_mci_request, .pre_req = dw_mci_pre_req,@@ -1335,6 +1348,7 @@ static const struct mmc_host_ops dw_mci_ops = { .card_busy = dw_mci_card_busy, .start_signal_voltage_switch = dw_mci_switch_voltage, .init_card = dw_mci_init_card, + .prepare_hs400_tuning = dw_mci_prepare_hs400_tuning, };static void dw_mci_request_end (struct dw_mci *host,struct mmc_request *mrq)drivers/mmc/host/dw_mmc.h +2
-0@@ -271,5 +271,7 @@ struct dw_mci_drv_data {void (*set_ios)(struct dw_mci *host,struct mmc_ios *ios);int (*parse_dt)(struct dw_mci *host);int (*execute_tuning)(struct dw_mci_slot *slot); +int (*prepare_hs400_tuning)(struct dw_mci *host, + struct mmc_ios *ios); };#endif /* _DW_MMC_H_ */
PATCH v5 1/2 mmc: dw_mmc: exynos: Support eMMC's HS400 mode
Thanks Jaehoon,
Quoted 7 lines · Jaehoon Chung
Hi, Alim.
Tested-by Jaehoon Chung <[email protected]>Acked-by Jaehoon Chung <[email protected]>I will include this patch into my tree, and i will request pull to Ulf.
If any rebase is required, I won't be able to do so until march 9th, hope you can take care of such changes.
Quoted 451 lines
Thanks!
Best Regards,
Jaehoon ChungQuoted 444 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
Implements HS400 mode support for exynos host driver. This also include some updates as new mode is added.
Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 5 files changed, 195 insertions(+), 34 deletions(-)Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +7
-0@@ -36,6 +36,8 @@ Required Properties: in transmit mode and CIU clock phase shift value in receive mode for double data rate mode operation. Refer notes below for the order of the cells and the valid values. +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase + shift value for hs400 mode operation. Notes for the sdr-timing and ddr-timing values:@@ -50,6 +52,9 @@ Required Properties: - if CIU clock divider value is 0 (that is divide by 1), both tx and rx phase shift clocks should be 0. +* samsung,read-strobe-delay: RCLK (Data strobe) delay to control HS400 mode + (Latency value for delay line in Read path) + Required properties for a slot (Deprecated - Recommend to use one slot per host): * gpios: specifies a list of gpios used for command, clock and data bus. The@@ -82,5 +87,7 @@ Example: samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <2 3>; samsung,dw-mshc-ddr-timing = <1 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; bus-width = <8>; };drivers/mmc/host/dw_mmc-exynos.c +153
-32@@ -40,7 +40,12 @@ struct dw_mci_exynos_priv_data {u8 ciu_div;u32 sdr_timing;u32 ddr_timing; +u32 hs400_timing; +u32 tuned_sample;u32 cur_speed; +u32 dqs_delay; +u32 saved_dqs_en; +u32 saved_strobe_ctrl; }; static struct dw_mci_exynos_compatible {@@ -71,6 +76,21 @@ static struct dw_mci_exynos_compatible { }, }; +static inline u8 dw_mci_exynos_get_ciu_div (struct dw_mci *host) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; + +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS4412 ) +return EXYNOS4412_FIXED_CIU_CLK_DIV ; +else if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS4210 ) +return EXYNOS4210_FIXED_CIU_CLK_DIV ; +else if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) +return SDMMC_CLKSEL_GET_DIV (mci_readl (host,CLKSEL64 )) +1 ; +else +return SDMMC_CLKSEL_GET_DIV (mci_readl (host,CLKSEL )) +1 ; +} +static int dw_mci_exynos_priv_init (struct dw_mci *host) {struct dw_mci_exynos_priv_data *priv = host->priv;@@ -85,6 +105,16 @@ static int dw_mci_exynos_priv_init(struct dw_mci *host) SDMMC_MPSCTRL_NON_SECURE_WRITE_BIT); } +if (priv->ctrl_type >=DW_MCI_TYPE_EXYNOS5420 ) { + priv->saved_strobe_ctrl =mci_readl (host,HS400_DLINE_CTRL ); + priv->saved_dqs_en =mci_readl (host,HS400_DQS_EN ); + priv->saved_dqs_en |=AXI_NON_BLOCKING_WR ; +mci_writel (host,HS400_DQS_EN , priv->saved_dqs_en); +if (!priv->dqs_delay) + priv->dqs_delay = +DQS_CTRL_GET_RD_DELAY (priv->saved_strobe_ctrl); + } +return 0 ; }@@ -97,6 +127,26 @@ static int dw_mci_exynos_setup_clock(struct dw_mci *host)return 0 ; } +static void dw_mci_exynos_set_clksel_timing (struct dw_mci *host,u32 timing) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; +u32 clksel; + +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) + clksel =mci_readl (host,CLKSEL64 ); +else + clksel =mci_readl (host,CLKSEL ); + + clksel = (clksel & ~SDMMC_CLKSEL_TIMING_MASK ) | timing; + +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || + priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) +mci_writel (host,CLKSEL64 , clksel); +else +mci_writel (host,CLKSEL , clksel); +} +#ifdef CONFIG_PM_SLEEP static int dw_mci_exynos_suspend (struct device *dev) {@@ -172,30 +222,38 @@ static void dw_mci_exynos_prepare_command(struct dw_mci *host, u32 *cmdr) } } -static void dw_mci_exynos_set_ios (struct dw_mci *host,struct mmc_ios *ios) +static void dw_mci_exynos_config_hs400 (struct dw_mci *host,u32 timing) {struct dw_mci_exynos_priv_data *priv = host->priv; -unsigned int wanted = ios->clock; -unsigned long actual; -u8 div = priv->ciu_div +1 ; +u32 dqs, strobe; -if (ios->timing ==MMC_TIMING_MMC_DDR52 ) { -if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || - priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) -mci_writel (host,CLKSEL64 , priv->ddr_timing); -else -mci_writel (host,CLKSEL , priv->ddr_timing); -/* Should be double rate for DDR mode */ -if (ios->bus_width ==MMC_BUS_WIDTH_8 ) - wanted <<=1 ; +/* +* Not supported to configure register +* related to HS400 +*/ +if (priv->ctrl_type <DW_MCI_TYPE_EXYNOS5420 ) +return ; + + dqs = priv->saved_dqs_en; + strobe = priv->saved_strobe_ctrl; + +if (timing ==MMC_TIMING_MMC_HS400 ) { + dqs |=DATA_STROBE_EN ; + strobe =DQS_CTRL_RD_DELAY (strobe, priv->dqs_delay); }else { -if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || - priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU ) -mci_writel (host,CLKSEL64 , priv->sdr_timing); -else -mci_writel (host,CLKSEL , priv->sdr_timing); + dqs &= ~DATA_STROBE_EN ; } +mci_writel (host,HS400_DQS_EN , dqs); +mci_writel (host,HS400_DLINE_CTRL , strobe); +} + +static void dw_mci_exynos_adjust_clock (struct dw_mci *host,unsigned int wanted) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; +unsigned long actual; +u8 div; +int ret;/* * Don't care if wanted clock is zero or * ciu clock is unavailable @@ -207,17 +265,52 @@ static void dw_mci_exynos_set_ios(struct dw_mci *host, struct mmc_ios *ios)if (wanted <EXYNOS_CCLKIN_MIN ) wanted =EXYNOS_CCLKIN_MIN ; -if (wanted != priv->cur_speed) { -int ret =clk_set_rate (host->ciu_clk, wanted * div); -if (ret) -dev_warn (host->dev, -"failed to set clk-rate %u error: %d\n" , - wanted * div, ret); - actual =clk_get_rate (host->ciu_clk); - host->bus_hz = actual / div; - priv->cur_speed = wanted; - host->current_speed =0 ; +if (wanted == priv->cur_speed) +return ; + + div =dw_mci_exynos_get_ciu_div (host); + ret =clk_set_rate (host->ciu_clk, wanted * div); +if (ret) +dev_warn (host->dev, +"failed to set clk-rate %u error: %d\n" , + wanted * div, ret); + actual =clk_get_rate (host->ciu_clk); + host->bus_hz = actual / div; + priv->cur_speed = wanted; + host->current_speed =0 ; +} + +static void dw_mci_exynos_set_ios (struct dw_mci *host,struct mmc_ios *ios) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; +unsigned int wanted = ios->clock; +u32 timing = ios->timing, clksel; + +switch (timing) { +case MMC_TIMING_MMC_HS400 : +/* Update tuned sample timing */ + clksel =SDMMC_CLKSEL_UP_SAMPLE ( + priv->hs400_timing, priv->tuned_sample); + wanted <<=1 ; +break ; +case MMC_TIMING_MMC_DDR52 : + clksel = priv->ddr_timing; +/* Should be double rate for DDR mode */ +if (ios->bus_width ==MMC_BUS_WIDTH_8 ) + wanted <<=1 ; +break ; +default : + clksel = priv->sdr_timing; } + +/* Set clock timing for the requested speed mode*/ +dw_mci_exynos_set_clksel_timing (host, clksel); + +/* Configure setting for HS400 */ +dw_mci_exynos_config_hs400 (host, timing); + +/* Configure clock rate */ +dw_mci_exynos_adjust_clock (host, wanted); }static int dw_mci_exynos_parse_dt (struct dw_mci *host)@@ -260,6 +353,16 @@ static int dw_mci_exynos_parse_dt(struct dw_mci *host)return ret; priv->ddr_timing =SDMMC_CLKSEL_TIMING (timing[0 ], timing[1 ], div); + + ret =of_property_read_u32_array (np, +"samsung,dw-mshc-hs400-timing" , timing,2 ); +if (!ret &&of_property_read_u32 (np, +"samsung,read-strobe-delay" , &priv->dqs_delay)) +dev_dbg (host->dev, +"read-strobe-delay is not found, assuming usage of default value\n" ); + + priv->hs400_timing =SDMMC_CLKSEL_TIMING (timing[0 ], timing[1 ], +HS400_FIXED_CIU_CLK_DIV ); host->priv = priv;return 0 ; }@@ -285,7 +388,7 @@ static inline void dw_mci_exynos_set_clksmpl(struct dw_mci *host, u8 sample) clksel =mci_readl (host,CLKSEL64 ); else clksel =mci_readl (host,CLKSEL ); - clksel = (clksel & ~0x7 ) |SDMMC_CLKSEL_CCLK_SAMPLE (sample); + clksel =SDMMC_CLKSEL_UP_SAMPLE (clksel, sample);if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU )mci_writel (host,CLKSEL64 , clksel);@@ -304,13 +407,16 @@ static inline u8 dw_mci_exynos_move_next_clksmpl(struct dw_mci *host) clksel =mci_readl (host,CLKSEL64 ); else clksel =mci_readl (host,CLKSEL ); + sample = (clksel +1 ) &0x7 ; - clksel = (clksel & ~0x7 ) | sample; + clksel =SDMMC_CLKSEL_UP_SAMPLE (clksel, sample); +if (priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7 || priv->ctrl_type ==DW_MCI_TYPE_EXYNOS7_SMU )mci_writel (host,CLKSEL64 , clksel);else mci_writel (host,CLKSEL , clksel); +return sample; }@@ -343,6 +449,7 @@ out:static int dw_mci_exynos_execute_tuning (struct dw_mci_slot *slot) {struct dw_mci *host = slot->host; +struct dw_mci_exynos_priv_data *priv = host->priv;struct mmc_host *mmc = slot->mmc;u8 start_smpl, smpl, candiates =0 ;s8 found =-1 ;@@ -360,14 +467,27 @@ static int dw_mci_exynos_execute_tuning(struct dw_mci_slot *slot) }while (start_smpl != smpl); found =dw_mci_exynos_get_best_clksmpl (candiates); -if (found >=0 ) +if (found >=0 ) {dw_mci_exynos_set_clksmpl (host, found); -else + priv->tuned_sample = found; + }else { ret = -EIO ; + }return ret; } +int dw_mci_exynos_prepare_hs400_tuning (struct dw_mci *host, +struct mmc_ios *ios) +{ +struct dw_mci_exynos_priv_data *priv = host->priv; + +dw_mci_exynos_set_clksel_timing (host, priv->hs400_timing); +dw_mci_exynos_adjust_clock (host, (ios->clock) <<1 ); + +return 0 ; +} +/* Common capabilities of Exynos4/Exynos5 SoC */ static unsigned long exynos_dwmmc_caps[4 ] = {MMC_CAP_1_8V_DDR |MMC_CAP_8_BIT_DATA |MMC_CAP_CMD23 ,@@ -384,6 +504,7 @@ static const struct dw_mci_drv_data exynos_drv_data = { .set_ios = dw_mci_exynos_set_ios, .parse_dt = dw_mci_exynos_parse_dt, .execute_tuning = dw_mci_exynos_execute_tuning, + .prepare_hs400_tuning = dw_mci_exynos_prepare_hs400_tuning, };static const struct of_device_id dw_mci_exynos_match[] = {drivers/mmc/host/dw_mmc-exynos.h +18
-1@@ -12,20 +12,36 @@#ifndef _DW_MMC_EXYNOS_H_#define _DW_MMC_EXYNOS_H_ -/* Extended Register's Offset */ #define SDMMC_CLKSEL 0x09C#define SDMMC_CLKSEL64 0x0A8 +/* Extended Register's Offset */ +#define SDMMC_HS400_DQS_EN 0x180 +#define SDMMC_HS400_ASYNC_FIFO_CTRL 0x184 +#define SDMMC_HS400_DLINE_CTRL 0x188 +/* CLKSEL register defines */ #define SDMMC_CLKSEL_CCLK_SAMPLE (x) (((x) & 7) << 0)#define SDMMC_CLKSEL_CCLK_DRIVE (x) (((x) & 7) << 16)#define SDMMC_CLKSEL_CCLK_DIVIDER (x) (((x) & 7) << 24)#define SDMMC_CLKSEL_GET_DRV_WD3 (x) (((x) >> 16) & 0x7) +#define SDMMC_CLKSEL_GET_DIV (x) (((x) >> 24) & 0x7) +#define SDMMC_CLKSEL_UP_SAMPLE (x, y) (((x) & ~SDMMC_CLKSEL_CCLK_SAMPLE(7)) |\ + SDMMC_CLKSEL_CCLK_SAMPLE(y))#define SDMMC_CLKSEL_TIMING (x, y, z) (SDMMC_CLKSEL_CCLK_SAMPLE(x) | \ SDMMC_CLKSEL_CCLK_DRIVE(y) | \ SDMMC_CLKSEL_CCLK_DIVIDER(z)) +#define SDMMC_CLKSEL_TIMING_MASK SDMMC_CLKSEL_TIMING(0x7, 0x7, 0x7)#define SDMMC_CLKSEL_WAKEUP_INT BIT(11) +/* RCLK_EN register defines */ +#define DATA_STROBE_EN BIT(0) +#define AXI_NON_BLOCKING_WR BIT(7) + +/* DLINE_CTRL register defines */ +#define DQS_CTRL_RD_DELAY (x, y) (((x) & ~0x3FF) | ((y) & 0x3FF)) +#define DQS_CTRL_GET_RD_DELAY (x) ((x) & 0x3FF) +/* Protector Register */ #define SDMMC_EMMCP_BASE 0x1000#define SDMMC_MPSECURITY (SDMMC_EMMCP_BASE + 0x0010)@@ -49,6 +65,7 @@/* Fixed clock divider */ #define EXYNOS4210_FIXED_CIU_CLK_DIV 2#define EXYNOS4412_FIXED_CIU_CLK_DIV 4 +#define HS400_FIXED_CIU_CLK_DIV 1/* Minimal required clock frequency for cclkin, unit: HZ */ #define EXYNOS_CCLKIN_MIN 50000000drivers/mmc/host/dw_mmc.c +15
-1@@ -1084,7 +1084,8 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) regs =mci_readl (slot->host,UHS_REG );/* DDR mode set */ -if (ios->timing ==MMC_TIMING_MMC_DDR52 ) +if (ios->timing ==MMC_TIMING_MMC_DDR52 || + ios->timing ==MMC_TIMING_MMC_HS400 ) regs |= ((0x1 << slot->id) <<16 );else regs &= ~((0x1 << slot->id) <<16 );@@ -1323,6 +1324,18 @@ static int dw_mci_execute_tuning(struct mmc_host *mmc, u32 opcode)return err; } +int dw_mci_prepare_hs400_tuning (struct mmc_host *mmc,struct mmc_ios *ios) +{ +struct dw_mci_slot *slot =mmc_priv (mmc); +struct dw_mci *host = slot->host; +const struct dw_mci_drv_data *drv_data = host->drv_data; + +if (drv_data && drv_data->prepare_hs400_tuning) +return drv_data->prepare_hs400_tuning (host, ios); + +return 0 ; +} +static const struct mmc_host_ops dw_mci_ops = { .request = dw_mci_request, .pre_req = dw_mci_pre_req,@@ -1335,6 +1348,7 @@ static const struct mmc_host_ops dw_mci_ops = { .card_busy = dw_mci_card_busy, .start_signal_voltage_switch = dw_mci_switch_voltage, .init_card = dw_mci_init_card, + .prepare_hs400_tuning = dw_mci_prepare_hs400_tuning, };static void dw_mci_request_end (struct dw_mci *host,struct mmc_request *mrq)drivers/mmc/host/dw_mmc.h +2
-0@@ -271,5 +271,7 @@ struct dw_mci_drv_data {void (*set_ios)(struct dw_mci *host,struct mmc_ios *ios);int (*parse_dt)(struct dw_mci *host);int (*execute_tuning)(struct dw_mci_slot *slot); +int (*prepare_hs400_tuning)(struct dw_mci *host, + struct mmc_ios *ios); };#endif /* _DW_MMC_H_ */
Signature · 2 lines
Regards, Alim
PATCH v5 1/2 mmc: dw_mmc: exynos: Support eMMC's HS400 mode
In reply to Alim AkhtarQuoted 21 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
Implements HS400 mode support for exynos host driver. This also include some updates as new mode is added.
Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 5 files changed, 195 insertions(+), 34 deletions(-)Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +0
-0
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt Required Properties: · line 40
Quoted 5 lines
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +2
-0@@ -36,6 +36,8 @@ Required Properties: in transmit mode and CIU clock phase shift value in receive mode for double data rate mode operation. Refer notes below for the order of the cells and the valid values. +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase + shift value for hs400 mode operation.
What are the units?
Rob
Jaehoon Chung
maintainerPATCH v5 1/2 mmc: dw_mmc: exynos: Support eMMC's HS400 mode
Dear, Rob.
Quoted 17 lines · Rob Herring
Quoted 16 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
Implements HS400 mode support for exynos host driver. This also include some updates as new mode is added.
Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 5 files changed, 195 insertions(+), 34 deletions(-)
Quoted 12 lines
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt Required Properties: · line 40
Quoted 10 lines
Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt +2
-0@@ -36,6 +36,8 @@ Required Properties: in transmit mode and CIU clock phase shift value in receive mode for double data rate mode operation. Refer notes below for the order of the cells and the valid values. +* samsung,dw-mshc-hs400-timing: Specifies the value of CIU TX and RX clock phase + shift value for hs400 mode operation.What are the units?
Do you means what is "sumsung,dw-mshci-hs400-timing" unit?
It's timing value for eMMC/SD/SDIO clock phase.(It's exynos specific value.) Using timing value can shift the H/W clock phase.
If invalid timing value is set, eMMC/SD/SDIO can produce the CRC error.
Do you think it can't include into device-tree?
I want to know your thinking. let me know, plz.
Best Regards,
Jaehoon Chung
Quoted 3 lines
Rob
Alim Akhtar
reviewerPATCH v5 2/2 ARM: dts: Add HS400 support for exynos5420 and exynos5800
In reply to Alim AkhtarFrom: Seungwon Jeon <[email protected]>
HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards.
This also adds RCLK GPIO line, this gpio should be in pull-down state.
This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller.
--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- 4 files changed, 18 insertions(+), 4 deletions(-)
arch/arm/boot/dts/exynos5420-peach-pit.dts +3 -1
@@ -569,8 +569,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };
arch/arm/boot/dts/exynos5420-pinctrl.dtsi +7 -0
@@ -201,6 +201,13 @@ samsung,pin-drv = <3>; }; + sd0_rclk: sd0-rclk { + samsung,pins = "gpc0-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <3>; + }; + sd1_cmd: sd1-cmd { samsung,pins = "gpc1-1"; samsung,pin-function = <2>;
arch/arm/boot/dts/exynos5420-smdk5420.dts +3 -1
@@ -80,8 +80,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; };
arch/arm/boot/dts/exynos5800-peach-pi.dts +5 -2
@@ -550,15 +550,18 @@ num-slots = <1>; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = <200>; - clock-frequency = <400000000>; + clock-frequency = <800000000>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };
Signature · 1 line
1.7.9.5
Jaehoon Chung
maintainerPATCH v5 2/2 ARM: dts: Add HS400 support for exynos5420 and exynos5800
Hi, Alim.
Best Regards,
Jaehoon Chung
Quoted 95 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards.
This also adds RCLK GPIO line, this gpio should be in pull-down state.
This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller.Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- 4 files changed, 18 insertions(+), 4 deletions(-)arch/arm/boot/dts/exynos5420-peach-pit.dts +3
-1@@ -569,8 +569,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };arch/arm/boot/dts/exynos5420-pinctrl.dtsi +7
-0@@ -201,6 +201,13 @@ samsung,pin-drv = <3>; }; + sd0_rclk: sd0-rclk { + samsung,pins = "gpc0-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <3>; + }; + sd1_cmd: sd1-cmd { samsung,pins = "gpc1-1"; samsung,pin-function = <2>;arch/arm/boot/dts/exynos5420-smdk5420.dts +3
-1@@ -80,8 +80,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; };arch/arm/boot/dts/exynos5800-peach-pi.dts +5
-2@@ -550,15 +550,18 @@ num-slots = <1>; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = <200>; - clock-frequency = <400000000>; + clock-frequency = <800000000>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };
PATCH v5 2/2 ARM: dts: Add HS400 support for exynos5420 and exynos5800
Ping?
Quoted 104 lines · Jaehoon Chung
Hi, Alim.
Acked-by Jaehoon Chung <[email protected]>Best Regards,
Jaehoon ChungQuoted 95 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards.
This also adds RCLK GPIO line, this gpio should be in pull-down state.
This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller.Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- 4 files changed, 18 insertions(+), 4 deletions(-)arch/arm/boot/dts/exynos5420-peach-pit.dts +3
-1@@ -569,8 +569,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };arch/arm/boot/dts/exynos5420-pinctrl.dtsi +7
-0@@ -201,6 +201,13 @@ samsung,pin-drv = <3>; }; + sd0_rclk: sd0-rclk { + samsung,pins = "gpc0-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <3>; + }; + sd1_cmd: sd1-cmd { samsung,pins = "gpc1-1"; samsung,pin-function = <2>;arch/arm/boot/dts/exynos5420-smdk5420.dts +3
-1@@ -80,8 +80,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; };arch/arm/boot/dts/exynos5800-peach-pi.dts +5
-2@@ -550,15 +550,18 @@ num-slots = <1>; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = <200>; - clock-frequency = <400000000>; + clock-frequency = <800000000>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };
Signature · 2 lines
Regards, Alim
PATCH v5 2/2 ARM: dts: Add HS400 support for exynos5420 and exynos5800
Quoted 3 lines · Alim Akhtar
Ping?
Alim,
Can you please re-send it based on latest my tree? It would be helpful for me ;)
Thanks,
Kukjin
Quoted 103 lines · Jaehoon Chung
Quoted 27 lines
Hi, Alim.
Acked-by Jaehoon Chung <[email protected]>Best Regards,
Jaehoon ChungQuoted 19 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards.
This also adds RCLK GPIO line, this gpio should be in pull-down state.
This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller.Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- 4 files changed, 18 insertions(+), 4 deletions(-)Quoted 1 line
arch/arm/boot/dts/exynos5420-peach-
Quoted 1 line
arch/arm/boot/dts/exynos5420-peach- renamed from arch/arm/boot/dts/exynos5420-peach-pit.dts +0
-0
pit.dtsQuoted 73 lines
Quoted 73 lines
index 9a050e1..f7a44a4 100644
arch/arm/boot/dts/exynos5420-peach-pit.dts +3
-1@@ -569,8 +569,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };arch/arm/boot/dts/exynos5420-pinctrl.dtsi +7
-0@@ -201,6 +201,13 @@ samsung,pin-drv = <3>; }; + sd0_rclk: sd0-rclk { + samsung,pins = "gpc0-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <3>; + }; + sd1_cmd: sd1-cmd { samsung,pins = "gpc1-1"; samsung,pin-function = <2>;arch/arm/boot/dts/exynos5420-smdk5420.dts +3
-1@@ -80,8 +80,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; };arch/arm/boot/dts/exynos5800-peach-pi.dts +5
-2@@ -550,15 +550,18 @@ num-slots = <1>; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = <200>; - clock-frequency = <400000000>; + clock-frequency = <800000000>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };
PATCH v5 2/2 ARM: dts: Add HS400 support for exynos5420 and exynos5800
Thanks Kukjin for looking into this.
I will rebase on top of your for-next and send again.
Quoted 116 lines · Kukjin Kim
Quoted 3 lines · Alim Akhtar
Ping?
Alim,
Can you please re-send it based on latest my tree? It would be helpful for me ;)
Thanks,
KukjinQuoted 103 lines · Jaehoon Chung
Quoted 27 lines
Hi, Alim.
Acked-by Jaehoon Chung <[email protected]>Best Regards,
Jaehoon ChungQuoted 19 lines · Alim Akhtar
From: Seungwon Jeon <[email protected]>
HS400 timing values are added for SMDK5420, exynos5420-peach-pit and exynos5800-peach-pi boards.
This also adds RCLK GPIO line, this gpio should be in pull-down state.
This also enables HS400 on peach-pi and this updates the clock frequency to 800MHz to be set as input clock to controller.Signed-off-by Seungwon Jeon <[email protected]>Signed-off-by Alim Akhtar <[email protected]>[Alim: addressed review comments]--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +++- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++ arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +++- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +++++-- 4 files changed, 18 insertions(+), 4 deletions(-)Quoted 1 line
arch/arm/boot/dts/exynos5420-peach-
Quoted 1 line
arch/arm/boot/dts/exynos5420-peach- renamed from arch/arm/boot/dts/exynos5420-peach-pit.dts +0
-0
pit.dtsQuoted 73 lines
Quoted 73 lines
index 9a050e1..f7a44a4 100644
arch/arm/boot/dts/exynos5420-peach-pit.dts +3
-1@@ -569,8 +569,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };arch/arm/boot/dts/exynos5420-pinctrl.dtsi +7
-0@@ -201,6 +201,13 @@ samsung,pin-drv = <3>; }; + sd0_rclk: sd0-rclk { + samsung,pins = "gpc0-7"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <3>; + }; + sd1_cmd: sd1-cmd { samsung,pins = "gpc1-1"; samsung,pin-function = <2>;arch/arm/boot/dts/exynos5420-smdk5420.dts +3
-1@@ -80,8 +80,10 @@ samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; cap-mmc-highspeed; };arch/arm/boot/dts/exynos5800-peach-pi.dts +5
-2@@ -550,15 +550,18 @@ num-slots = <1>; broken-cd; mmc-hs200-1_8v; + mmc-hs400-1_8v; cap-mmc-highspeed; non-removable; card-detect-delay = <200>; - clock-frequency = <400000000>; + clock-frequency = <800000000>; samsung,dw-mshc-ciu-div = <3>; samsung,dw-mshc-sdr-timing = <0 4>; samsung,dw-mshc-ddr-timing = <0 2>; + samsung,dw-mshc-hs400-timing = <0 2>; + samsung,read-strobe-delay = <90>; pinctrl-names = "default"; - pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>; + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8 &sd0_rclk>; bus-width = <8>; };
Signature · 2 lines
Regards, Alim
Jaehoon Chung
maintainerv5 cover mmc: dw_mmc: exynos: Add HS400 support
In reply to Alim AkhtarHi, Alim.
On my board, this patch isn't working fine.
So when i complete to test on my board(exynos5), i will reply with comments. Sorry for late testing.
Best Regards,
Jaehoon Chung
Quoted 36 lines · Alim Akhtar
This adds HS400 mode support for exynos
dw_mmchost controller.Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. Tested HS200 mode with this series applied, HS200 still works.
Appreciate testing on other exynos5/7 platform which supports emmc5.0
Changes in V5:
* Enable HS400 on Exynos5800-peach-pi boards
* Addressed other review comments from Jaehoon ChungChanges in V4:
* drop the idea of changing existing binding forciu_divas per [1]
* addressed comments from Jaehoon Chung [2][1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html
[2] http://www.spinics.net/lists/devicetree/msg64373.htmlChanges in V3:
rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static)Seungwon Jeon (2):
mmc:dw_mmc: exynos: Support eMMC's HS400 mode
ARM: dts: Add HS400 support for exynos5420 and exynos5800.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 9 files changed, 213 insertions(+), 38 deletions(-)
v5 cover mmc: dw_mmc: exynos: Add HS400 support
Hi Jaehoon,
Quoted 5 lines · Jaehoon Chung
Hi, Alim.
On my board, this patch isn't working fine.
So when i complete to test on my board(exynos5), i will reply with comments. Sorry for late testing.
I tested this series on linux-next, on Exynos5800-peach-pi board, and HS400 seems to be working fine.
I can see the card getting detected as HS400, and then i ran iozone as well. The iozone numbers are also as required.
On peach-pit board too, the HS200 mode seems to be working good.
What are the observations you saw on your board ?
Quoted 46 lines
Best Regards,
Jaehoon ChungQuoted 25 lines · Alim Akhtar
This adds HS400 mode support for exynos
dw_mmchost controller.Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. Tested HS200 mode with this series applied, HS200 still works.
Appreciate testing on other exynos5/7 platform which supports emmc5.0
Changes in V5:
* Enable HS400 on Exynos5800-peach-pi boards
* Addressed other review comments from Jaehoon ChungChanges in V4:
* drop the idea of changing existing binding forciu_divas per [1]
* addressed comments from Jaehoon Chung [2][1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html
[2] http://www.spinics.net/lists/devicetree/msg64373.htmlChanges in V3:
rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static)Seungwon Jeon (2):
mmc:dw_mmc: exynos: Support eMMC's HS400 mode
ARM: dts: Add HS400 support for exynos5420 and exynos5800Quoted 11 lines
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 9 files changed, 213 insertions(+), 38 deletions(-)--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 4 lines
Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India
Jaehoon Chung
maintainerv5 cover mmc: dw_mmc: exynos: Add HS400 support
Hi, Vivek.
Quoted 10 lines · Vivek Gautam
Hi Jaehoon,
Quoted 5 lines · Jaehoon Chung
Hi, Alim.
On my board, this patch isn't working fine.
So when i complete to test on my board(exynos5), i will reply with comments. Sorry for late testing.
Quoted 8 lines
I tested this series on linux-next, on Exynos5800-peach-pi board, and HS400 seems to be working fine.
I can see the card getting detected as HS400, and then i ran iozone as well. The iozone numbers are also as required.On peach-pit board too, the HS200 mode seems to be working good.
What are the observations you saw on your board ?
Thanks for testing on your board. I have exynos5422 and exynos5433.(One is eMMC5.0, other is eMMC5.1) I want to see that it's working fine on my board.
I should miss something..so i will check more detail after complete my other job, or on this weekend. (It failed for hs400 tuning sequence..I needs to check that it has the board dependency)
Best Regards,
Jaehoon Chung
Quoted 50 lines
Quoted 47 lines
Best Regards,
Jaehoon ChungQuoted 25 lines · Alim Akhtar
This adds HS400 mode support for exynos
dw_mmchost controller.Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. Tested HS200 mode with this series applied, HS200 still works.
Appreciate testing on other exynos5/7 platform which supports emmc5.0
Changes in V5:
* Enable HS400 on Exynos5800-peach-pi boards
* Addressed other review comments from Jaehoon ChungChanges in V4:
* drop the idea of changing existing binding forciu_divas per [1]
* addressed comments from Jaehoon Chung [2][1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html
[2] http://www.spinics.net/lists/devicetree/msg64373.htmlChanges in V3:
rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static)Seungwon Jeon (2):
mmc:dw_mmc: exynos: Support eMMC's HS400 mode
ARM: dts: Add HS400 support for exynos5420 and exynos5800Quoted 11 lines
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 9 files changed, 213 insertions(+), 38 deletions(-)--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
v5 cover mmc: dw_mmc: exynos: Add HS400 support
Hi,
Quoted 18 lines · Jaehoon Chung
Hi, Vivek.
Quoted 15 lines · Vivek Gautam
Hi Jaehoon,
Quoted 5 lines · Jaehoon Chung
Hi, Alim.
On my board, this patch isn't working fine.
So when i complete to test on my board(exynos5), i will reply with comments. Sorry for late testing.I tested this series on linux-next, on Exynos5800-peach-pi board, and HS400 seems to be working fine.
I can see the card getting detected as HS400, and then i ran iozone as well. The iozone numbers are also as required.
Quoted 8 lines
Quoted 3 lines
On peach-pit board too, the HS200 mode seems to be working good.
What are the observations you saw on your board ?
Thanks for testing on your board. I have exynos5422 and exynos5433.(One is eMMC5.0, other is eMMC5.1) I want to see that it's working fine on my board.
I should miss something..so i will check more detail after complete my other job, or on this weekend. (It failed for hs400 tuning sequence..I needs to check that it has the board dependency)
Ok
Thanks for testing it on your side.
Quoted 55 lines
Best Regards,
Jaehoon ChungQuoted 50 lines
Quoted 47 lines
Best Regards,
Jaehoon ChungQuoted 25 lines · Alim Akhtar
This adds HS400 mode support for exynos
dw_mmchost controller.Currently tested on Exynos5800-peach-pi and Exyons7 platform for HS400 mode. Tested HS200 mode with this series applied, HS200 still works.
Appreciate testing on other exynos5/7 platform which supports emmc5.0
Changes in V5:
* Enable HS400 on Exynos5800-peach-pi boards
* Addressed other review comments from Jaehoon ChungChanges in V4:
* drop the idea of changing existing binding forciu_divas per [1]
* addressed comments from Jaehoon Chung [2][1] http://www.spinics.net/lists/linux-samsung-soc/msg40923.html
[2] http://www.spinics.net/lists/devicetree/msg64373.htmlChanges in V3:
rebased on ulf's next (commit: 607b448 mmc: core: Make tuning block patterns static)Seungwon Jeon (2):
mmc:dw_mmc: exynos: Support eMMC's HS400 mode
ARM: dts: Add HS400 support for exynos5420 and exynos5800Quoted 11 lines
.../devicetree/bindings/mmc/exynos-dw-mshc.txt | 7 + arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 + arch/arm/boot/dts/exynos5420-smdk5420.dts | 4 +- arch/arm/boot/dts/exynos5800-peach-pi.dts | 7 +- drivers/mmc/host/dw_mmc-exynos.c | 185 ++++++++++++++++---- drivers/mmc/host/dw_mmc-exynos.h | 19 +- drivers/mmc/host/dw_mmc.c | 16 +- drivers/mmc/host/dw_mmc.h | 2 + 9 files changed, 213 insertions(+), 38 deletions(-)--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 4 lines
Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India