prevent the read ahead of /proc/slabinfo in ss take 2
Subsystems (2)
PATCH 1/1 prevent the read ahead of /proc/slabinfo in ss take 2
ss reads ahead of /proc/slabinfo whatever slabstat will be used or not in future.
this will cause huge system delay when the kernel hires SLAB allocator(SLUB allocator is ok). when program reads /proc/slabinfo, it will call s_show() in SLAB allocator level, and s_show() calls spin_lock_irq(&l3->list_lock) then iterate on whole three lists. if one slab has about 900 million objects (for example dentry), it will cause more than 1000ms delay.
so this patch prevents the read ahead of /proc/slabinfo, ss runs with most parameters not using slabstat at all. and this patch also change slabstat and slabstat_valid to static.
--- misc/ss.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
misc/ss.c +8 -3
@@ -616,7 +616,8 @@ struct slabstatint skbs; }; -struct slabstat slabstat; +static struct slabstat slabstat; +static int slabstat_valid =0 ;static const char *slabstat_ids[] = {
@@ -2230,6 +2231,9 @@ static int tcp_show(struct filter *f, int socktype)* it is able to give us some memory for snapshot. */ if (1 ) { +if (!slabstat_valid) +get_slabstat (&slabstat); +int guess = slabstat.socks+slabstat.tcp_syns;if (f->states&(1 <<SS_TIME_WAIT )) guess += slabstat.tcp_tws;
@@ -3196,6 +3200,9 @@ static int print_summary(void)if (get_snmp_int ("Tcp:" ,"CurrEstab" , &sn.tcp_estab) <0 )perror ("ss: get_snmpstat" ); +if (!slabstat_valid) +get_slabstat (&slabstat); +printf ("Total: %d (kernel %d)\n" , s.socks, slabstat.socks); printf("TCP: %d (estab %d, closed %d, orphaned %d, synrecv %d, timewait %d/%d), ports %d\n",
@@ -3543,8 +3550,6 @@ int main(int argc, char *argv[]) argc -= optind; argv += optind; -get_slabstat (&slabstat); -if (do_summary) {print_summary ();if (do_default && argc ==0 )
Signature · 1 line
2.0.5
Quoted 6 lines · Bryton Lee
ss reads ahead of
/proc/slabinfowhatever slabstat will be used or not in future.
this will cause huge system delay when the kernel hires SLAB allocator(SLUB allocator is ok). when program reads/proc/slabinfo, it will calls_show()in SLAB allocator level, ands_show()callsspin_lock_irq(&l3->list_lock)then iterate on whole three lists. if one slab has about 900 million objects (for example dentry), it will cause more than 1000ms delay.
Please keep lengths < 70 chars in changelog.
Quoted 13 lines
so this patch prevents the read ahead of
/proc/slabinfo, ss runs with most parameters not using slabstat at all. and this patch also change slabstat andslabstat_validto static.Signed-off-by Bryton Lee <[email protected]>--- misc/ss.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)misc/ss.c +0
-0
misc/ss.c struct slabstat · line 620
Quoted 6 lines
misc/ss.c +2
-1@@ -616,7 +616,8 @@ struct slabstatint skbs; }; -struct slabstat slabstat; +static struct slabstat slabstat; +static int slabstat_valid =0 ;
David pointed that you never set this variable to 1 or any value...
Why is this variable needed, if its content is known/constant ?
I presume you wanted to set it in get_slabstat(), right ?
Quoted 32 lines
misc/ss.c +6
-2static const char *slabstat_ids[] = {@@ -2230,6 +2231,9 @@ static int tcp_show(struct filter *f, int socktype)* it is able to give us some memory for snapshot. */ if (1 ) { +if (!slabstat_valid) +get_slabstat (&slabstat); +int guess = slabstat.socks+slabstat.tcp_syns;if (f->states&(1 <<SS_TIME_WAIT )) guess += slabstat.tcp_tws;@@ -3196,6 +3200,9 @@ static int print_summary(void)if (get_snmp_int ("Tcp:" ,"CurrEstab" , &sn.tcp_estab) <0 )perror ("ss: get_snmpstat" ); +if (!slabstat_valid) +get_slabstat (&slabstat); +printf ("Total: %d (kernel %d)\n" , s.socks, slabstat.socks); printf("TCP: %d (estab %d, closed %d, orphaned %d, synrecv %d, timewait %d/%d), ports %d\n",@@ -3543,8 +3550,6 @@ int main(int argc, char *argv[]) argc -= optind; argv += optind; -get_slabstat (&slabstat); -if (do_summary) {print_summary ();if (do_default && argc ==0 )
Quoted 32 lines · Eric Dumazet
Quoted 6 lines · Bryton Lee
ss reads ahead of
/proc/slabinfowhatever slabstat will be used or not in future.
this will cause huge system delay when the kernel hires SLAB allocator(SLUB allocator is ok). when program reads/proc/slabinfo, it will calls_show()in SLAB allocator level, ands_show()callsspin_lock_irq(&l3->list_lock)then iterate on whole three lists. if one slab has about 900 million objects (for example dentry), it will cause more than 1000ms delay.Please keep lengths < 70 chars in changelog.
Quoted 13 lines
so this patch prevents the read ahead of
/proc/slabinfo, ss runs with most parameters not using slabstat at all. and this patch also change slabstat andslabstat_validto static.Signed-off-by Bryton Lee <[email protected]>--- misc/ss.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)misc/ss.c +0
-0misc/ss.c struct slabstat · line 620
Quoted 6 lines
misc/ss.c +2
-1@@ -616,7 +616,8 @@ struct slabstatint skbs; }; -struct slabstat slabstat; +static struct slabstat slabstat; +static int slabstat_valid =0 ;David pointed that you never set this variable to 1 or any value...
Quoted 4 lines
Why is this variable needed, if its content is known/constant ?
I presume you wanted to set it in
get_slabstat(), right ?
Yes, you are right. I missed it when I merged code from my local version to upstream, big thanks to you! I will commit it soon.
Quoted 35 lines
Quoted 33 lines
misc/ss.c +6
-2static const char *slabstat_ids[] = {@@ -2230,6 +2231,9 @@ static int tcp_show(struct filter *f, int socktype)* it is able to give us some memory for snapshot. */ if (1 ) { +if (!slabstat_valid) +get_slabstat (&slabstat); +int guess = slabstat.socks+slabstat.tcp_syns;if (f->states&(1 <<SS_TIME_WAIT )) guess += slabstat.tcp_tws;@@ -3196,6 +3200,9 @@ static int print_summary(void)if (get_snmp_int ("Tcp:" ,"CurrEstab" , &sn.tcp_estab) <0 )perror ("ss: get_snmpstat" ); +if (!slabstat_valid) +get_slabstat (&slabstat); +printf ("Total: %d (kernel %d)\n" , s.socks, slabstat.socks); printf("TCP: %d (estab %d, closed %d, orphaned %d, synrecv %d, timewait %d/%d), ports %d\n",@@ -3543,8 +3550,6 @@ int main(int argc, char *argv[]) argc -= optind; argv += optind; -get_slabstat (&slabstat); -if (do_summary) {print_summary ();if (do_default && argc ==0 )
Signature · 3 lines
Best Regards Bryton.Lee
Hello.
Quoted 19 lines · Bryton Lee
ss reads ahead of
/proc/slabinfowhatever slabstat will be used or not in future.
this will cause huge system delay when the kernel hires SLAB allocator(SLUB allocator is ok). when program reads/proc/slabinfo, it will calls_show()in SLAB allocator level, ands_show()callsspin_lock_irq(&l3->list_lock)then iterate on whole three lists. if one slab has about 900 million objects (for example dentry), it will cause more than 1000ms delay.so this patch prevents the read ahead of
/proc/slabinfo, ss runs with most parameters not using slabstat at all. and this patch also change slabstat andslabstat_validto static.Signed-off-by Bryton Lee <[email protected]>--- misc/ss.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)misc/ss.c +0
-0
misc/ss.c struct slabstat · line 620
Quoted 6 lines
misc/ss.c +2
-1@@ -616,7 +616,8 @@ struct slabstatint skbs; }; -struct slabstat slabstat; +static struct slabstat slabstat; +static int slabstat_valid =0 ;
No need to initialize to 0.
[...]
WBR, Sergei