Skip to contentSkip to conversation

reiser4progs: node41 layout support

PATCH In review Edward Shishkin 3 participants 6 messages Feb 10, 2015 – Feb 18, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 reiser4progs: node41 layout support

Support of node41 layout (the same as node40, but
with 32-bit checksum).

---
 configure.in                       |    1 
 include/reiser4/format.h           |    2 
 include/reiser4/plugin.h           |    9 
 libreiser4/factory.c               |    2 
 libreiser4/filesystem.c            |   11 -
 libreiser4/format.c                |   11 +
 libreiser4/profile.c               |    4 
 libreiser4/tree.c                  |   28 ++
 plugin/Makefile.am                 |    2 
 plugin/format/format40/format40.c  |    9 
 plugin/format/format40/format40.h  |   18 +
 plugin/node/Makefile.am            |    2 
 plugin/node/node40/node40.c        |  118 ++++++-----
 plugin/node/node40/node40.h        |   51 ++++-
 plugin/node/node40/node40_repair.c |  372 +++++++++++++++++++++++++------------
 plugin/node/node40/node40_repair.h |   39 +++
 plugin/node/node41/Makefile.am     |   22 ++
 plugin/node/node41/node41.c        |  150 ++++++++++++++
 plugin/node/node41/node41.h        |   47 ++++
 plugin/node/node41/node41_repair.c |  153 +++++++++++++++
 plugin/node/node41/node41_repair.h |   39 +++
 21 files changed, 902 insertions(+), 188 deletions(-)
configure.in +1 -0
@@ -582,6 +582,7 @@ AC_OUTPUT([
     	plugin/oid/oid40/Makefile
     	plugin/node/Makefile
     	plugin/node/node40/Makefile
+	plugin/node/node41/Makefile
    	plugin/key/Makefile
     	plugin/key/key_common/Makefile
     	plugin/key/key_short/Makefile
include/reiser4/plugin.h +6 -3
@@ -174,6 +174,7 @@ extern const char *reiser4_slink_name[];
 /* Known node plugin ids. */
 enum reiser4_node_plug_id {
 	NODE_REISER40_ID        = 0x0,
+	NODE_REISER41_ID        = 0x1,
 	NODE_LAST_ID
 };
 
@@ -954,7 +955,8 @@ typedef struct format_hint {
 	uint32_t blksize;
 	rid_t policy;
 	rid_t key;
-	
+	rid_t node;
+
 	/* For repair purposes. Set plugin types that are overridden 
 	   in the profile here, they must be set in the format plugin
 	   check_struct. If bit is not set, plugins given with the above 
@@ -1478,11 +1480,12 @@ struct reiser4_format_plug {
 	void (*set_policy) (reiser4_format_ent_t *, rid_t);
 	void (*set_height) (reiser4_format_ent_t *, uint16_t);
 
-	/* Return plugin ids for journal, block allocator, and oid allocator
-	   components. */
+	/* Return plugin ids for journal, block allocator, oid allocator
+	   and node components. */
 	rid_t (*journal_pid) (reiser4_format_ent_t *);
 	rid_t (*alloc_pid) (reiser4_format_ent_t *);
 	rid_t (*oid_pid) (reiser4_format_ent_t *);
+	rid_t (*node_pid) (reiser4_format_ent_t *);
 
 	/* Format enumerator function. */
 	errno_t (*layout) (reiser4_format_ent_t *, region_func_t, void *);
plugin/Makefile.am +2 -0
@@ -14,6 +14,7 @@ libreiser4_plugin_la_LIBADD       = form
                                     alloc/alloc40/liballoc40-static.la \
                                     oid/oid40/liboid40-static.la \
                                     node/node40/libnode40-static.la \
+                                    node/node41/libnode41-static.la \
                                     key/key_common/libkey_common-static.la \
                                     key/key_short/libkey_short-static.la \
                                     key/key_large/libkey_large-static.la \
@@ -57,6 +58,7 @@ if ENABLE_MINIMAL
 libreiser4_plugin_minimal_la_LIBADD = format/format40/libformat40-minimal.la \
                                     oid/oid40/liboid40-minimal.la \
                                     node/node40/libnode40-minimal.la \
+                                    node/node41/libnode41-minimal.la \
                                     key/key_common/libkey_common-minimal.la \
                                     key/key_short/libkey_short-minimal.la \
                                     key/key_large/libkey_large-minimal.la \
plugin/node/Makefile.am +1 -1
@@ -1 +1 @@
-SUBDIRS = node40
+SUBDIRS = node40 node41
plugin/node/node41/Makefile.am new file +22 -0
@@ -0,0 +1,22 @@
+includedir		    = -I$(top_srcdir)/include
+
+node41_sources              = node41.c node41_repair.c node41.h node41_repair.h
+
+STATIC_LIBS		    = libnode41-static.la
+libnode41_static_la_SOURCES = $(node41_sources)
+libnode41_static_la_CFLAGS  = @GENERIC_CFLAGS@
+
+if ENABLE_MINIMAL
+MINIMAL_LIBS                  = libnode41-minimal.la
+else
+MINIMAL_LIBS                  =
+endif
+
+noinst_LTLIBRARIES   	    = $(STATIC_LIBS) $(MINIMAL_LIBS)
+
+if ENABLE_MINIMAL
+libnode41_minimal_la_SOURCES  = $(node41_sources)
+libnode41_minimal_la_CFLAGS   = @MINIMAL_CFLAGS@
+endif
+
+INCLUDES = $(includedir)
plugin/node/node41/node41.c new file +150 -0

150 lines not on this page · raw message

plugin/node/node41/node41.h new file +47 -0

47 lines not on this page · raw message

libreiser4/factory.c +2 -0
@@ -239,6 +239,8 @@ errno_t reiser4_factory_init(void) {
 	
 	__load_plug(node40);
 	__init_plug(node40);
+
+	__load_plug(node41);
 	
 	__load_plug(dir40);
 	__load_plug(reg40);
libreiser4/profile.c +2 -2
@@ -123,8 +123,8 @@ reiser4_profile_t defprof = {
 		[PROF_NODE] = {
 #ifndef ENABLE_MINIMAL
 			.name  = "node",
-			.desc  = "",
-			.hidden = 1,
+			.desc  = "Node plugin",
+			.hidden = 0,
 			.max = NODE_LAST_ID,
 #endif
 			.id = {NODE_REISER40_ID, 0, NODE_PLUG_TYPE},
plugin/node/node41/node41_repair.c new file +153 -0

153 lines not on this page · raw message

plugin/node/node41/node41_repair.h new file +39 -0
@@ -0,0 +1,39 @@
+/* Copyright (C) 2001-2005 by Hans Reiser, licensing governed by
+   reiser4progs/COPYING.
+
+   node41_repair.h -- reiser4 node plugin repair functions. */
+
+#ifndef NODE41_REPAIR_H
+#define NODE41_REPAIR_H
+
+#include <aal/libaal.h>
+#include <reiser4/plugin.h>
+
+extern errno_t node41_insert_raw(reiser4_node_t *entity, pos_t *pos,
+				 trans_hint_t *hint);
+
+extern errno_t node41_check_struct(reiser4_node_t *entity,
+				   uint8_t mode);
+
+extern errno_t node41_pack(reiser4_node_t *entity,
+			   aal_stream_t *stream);
+
+extern reiser4_node_t *node41_unpack(aal_block_t *block,
+				    reiser4_key_plug_t *kplug,
+				    aal_stream_t *stream);
+
+extern void node41_print(reiser4_node_t *entity, aal_stream_t *stream,
+			 uint32_t start, uint32_t count, uint16_t options);
+
+#endif
+
+/*
+   Local variables:
+   c-indentation-style: "K&R"
+   mode-name: "LC"
+   c-basic-offset: 8
+   tab-width: 8
+   fill-column: 80
+   scroll-step: 1
+   End:
+*/
plugin/node/node40/node40.h +49 -2

65 lines not on this page · raw message

plugin/node/node40/node40.c +69 -49

249 lines not on this page · raw message

plugin/node/node40/node40_repair.c +255 -117

547 lines not on this page · raw message

plugin/node/node40/node40_repair.h +36 -3
@@ -11,18 +11,51 @@
 
 extern errno_t node40_insert_raw(reiser4_node_t *entity, pos_t *pos,
 				 trans_hint_t *hint);
-
 extern errno_t node40_check_struct(reiser4_node_t *entity,
 				   uint8_t mode);
-
+extern void node40_header_pack(reiser4_node_t *entity, aal_stream_t *stream);
+extern int32_t node40_items_pack(reiser4_node_t *entity, aal_stream_t *stream);
+extern errno_t node40_pack_common(reiser4_node_t *entity, aal_stream_t *stream,
+				  void (*pack_header_fn)(reiser4_node_t *,
+							 aal_stream_t *),
+				  int32_t (*pack_items_fn)(reiser4_node_t *,
+							   aal_stream_t *));
 extern errno_t node40_pack(reiser4_node_t *entity,
 			   aal_stream_t *stream);
-
+extern int32_t node40_header_unpack(reiser4_node_t *entity,
+				    aal_stream_t *stream);
+extern int32_t node40_items_unpack(reiser4_node_t *entity,
+				   aal_stream_t *stream);
+extern reiser4_node_t *
+node40_unpack_common(aal_block_t *block,
+		     reiser4_key_plug_t *kplug,
+		     aal_stream_t *stream,
+		     reiser4_node_plug_t *nplug,
+		     const uint32_t magic,
+		     reiser4_node_t* (*prepare_fn)(aal_block_t *,
+						  reiser4_key_plug_t *),
+		     int32_t (*unpack_header_fn)(reiser4_node_t *,
+						 aal_stream_t *),
+		     int32_t (*unpack_items_fn)(reiser4_node_t *,
+						aal_stream_t *));
 extern reiser4_node_t *node40_unpack(aal_block_t *block,
 				    reiser4_key_plug_t *kplug,
 				    aal_stream_t *stream);
 
+extern void node40_print_common(reiser4_node_t *entity, aal_stream_t *stream,
+				uint32_t start, uint32_t count,
+				uint16_t options,
+				void (*print_header_fn)(reiser4_node_t *,
+							aal_stream_t *));
 extern void node40_print(reiser4_node_t *entity, aal_stream_t *stream,
 			 uint32_t start, uint32_t count, uint16_t options);
 
+extern uint32_t node40_estimate_count_common(reiser4_node_t *entity,
+					     uint32_t nh_size);
+extern errno_t node40_count_check_common(reiser4_node_t *node,
+				  uint8_t mode,
+				  uint32_t (*estimate_count)(reiser4_node_t *));
+extern errno_t node40_ih_array_check_common(reiser4_node_t *node,
+					    uint8_t mode,
+					    uint32_t node_header_size);
 #endif
include/reiser4/format.h +2 -0
@@ -20,6 +20,7 @@ extern reiser4_format_t *reiser4_format_
 					       reiser4_format_plug_t *plug,
 					       rid_t policy,
 					       rid_t key,
+					       rid_t node,
 					       count_t blocks);
 
 extern errno_t reiser4_format_backup(reiser4_format_t *format,
@@ -60,6 +61,7 @@ extern errno_t reiser4_format_valid(reis
 extern rid_t reiser4_format_oid_pid(reiser4_format_t *format);
 extern rid_t reiser4_format_alloc_pid(reiser4_format_t *format);
 extern rid_t reiser4_format_journal_pid(reiser4_format_t *format);
+extern rid_t reiser4_format_node_pid(reiser4_format_t *format);
 
 extern blk_t reiser4_format_start(reiser4_format_t *format);
 extern count_t reiser4_format_get_len(reiser4_format_t *format);
libreiser4/filesystem.c +7 -4
@@ -250,7 +250,7 @@ reiser4_fs_t *reiser4_fs_create(
 	aal_device_t *device,           /* device filesystem will be lie on */
 	fs_hint_t *hint)                /* filesystem hint */
 {
-	reiser4_plug_t *format, *policy, *key;
+  reiser4_plug_t *format, *policy, *node, *key;
 
 	count_t free;
 	reiser4_fs_t *fs;
@@ -288,15 +288,18 @@ reiser4_fs_t *reiser4_fs_create(
 
 	/* Getting tail policy from default params. */
 	policy = reiser4_profile_plug(PROF_POLICY);
-	
+
+	/* Getting node plugin from default params. */
+	node = reiser4_profile_plug(PROF_NODE);
+
 	/* Taking care about key flags in format super block */
 	key = reiser4_profile_plug(PROF_KEY);
 	
 	/* Creates disk format. */
 	
 	fs->format = reiser4_format_create(fs, (reiser4_format_plug_t *)format,
-					   policy->id.id, key->id.id, 
-					   hint->blocks);
+					   policy->id.id, key->id.id,
+					   node->id.id, hint->blocks);
 	if (!fs->format) 
 		goto error_free_status;
 
libreiser4/format.c +11 -0
@@ -87,6 +87,7 @@ reiser4_format_t *reiser4_format_create(
 	reiser4_format_plug_t *plug,	/* format plugin */
 	rid_t policy,			/* policy plug id */
 	rid_t key,			/* key plug id */
+	rid_t node,                     /* node plug id */
 	count_t blocks)			/* block count */
 {
 	reiser4_format_t *format;
@@ -106,6 +107,7 @@ reiser4_format_t *reiser4_format_create(
 	desc.blocks = blocks;
 	desc.policy = policy;
 	desc.key = key;
+	desc.node = node;
 
 	/* Initializing entity of disk-format by means of calling "create"
 	   method from found plugin. Plugin "create" method will be creating 
@@ -261,6 +263,15 @@ uint16_t reiser4_format_get_policy(
 	return reiser4call(format, get_policy);
 }
 
+/* Returns node plugin id from the format-specific super-block */
+rid_t reiser4_format_node_pid(
+	reiser4_format_t *format)	/* format to be inspected */
+{
+	aal_assert("edward-19", format != NULL);
+
+	return reiser4call(format, node_pid);
+}
+
 /* Sets new root block */
 void reiser4_format_set_root(
 	reiser4_format_t *format,	/* format new root blocks will be set in */
libreiser4/tree.c +23 -5
@@ -856,12 +856,13 @@ errno_t reiser4_tree_next_key(reiser4_tr
 reiser4_node_t *reiser4_tree_alloc_node(reiser4_tree_t *tree,
 					uint8_t level)
 {
-	reiser4_node_plug_t *plug;
+	reiser4_plug_t *nplug;
 	reiser4_node_t *node;
 	uint32_t stamp;
 	errno_t res;
 	blk_t blk;
-	
+	rid_t node_pid;
+
 	reiser4_format_t *format;
     
 	aal_assert("umka-756", tree != NULL);
@@ -873,11 +874,17 @@ reiser4_node_t *reiser4_tree_alloc_node(
 	/* Setting up of the free blocks in format. */
 	if ((res = reiser4_format_dec_free(format, 1)))
 		return NULL;
-	
-	plug = (reiser4_node_plug_t *)tree->ent.tset[TSET_NODE];
+
+	/* Grab node plugin */
+	node_pid = reiser4_format_node_pid(format);
+	if (!(nplug = reiser4_factory_ifind(NODE_PLUG_TYPE, node_pid))) {
+		aal_error("Unknown node plugin.");
+		return NULL;
+	}
 	
 	/* Creating new node. */
-	if (!(node = reiser4_node_create(tree, plug, blk, level))) {
+	if (!(node = reiser4_node_create(tree, (reiser4_node_plug_t *)nplug,
+					 blk, level))) {
 		aal_error("Can't initialize new fake node.");
 		return NULL;
 	}
@@ -3317,3 +3324,14 @@ errno_t reiser4_tree_resize(reiser4_tree
 	return -EINVAL;
 }
 #endif
+
+/*
+   Local variables:
+   c-indentation-style: "K&R"
+   mode-name: "LC"
+   c-basic-offset: 8
+   tab-width: 8
+   fill-column: 80
+   scroll-step: 1
+   End:
+*/
plugin/format/format40/format40.c +9 -0
@@ -47,6 +47,11 @@ static rid_t format40_get_policy(reiser4
 	return get_sb_policy(SUPER(entity));
 }
 
+static uint32_t format40_node_pid(reiser4_format_ent_t *entity) {
+	aal_assert("edward-18", entity != NULL);
+	return get_sb_node_pid(SUPER(entity));
+}
+
 static uint64_t format40_start(reiser4_format_ent_t *entity) {
 	format40_t *format = (format40_t *)entity;
 	
@@ -238,6 +243,9 @@ static reiser4_format_ent_t *format40_cr
 	/* Setting up tail policy to passed @desc->policy value. */
 	set_sb_policy(super, desc->policy);
 
+	/* Set node plugin id */
+	set_sb_node_pid(super, desc->node);
+
 	/* Set the flags. */
 	/* FIXME: Hardcoded plugin ids for 2 cases. */
 	flags = (desc->key == KEY_LARGE_ID) ? (1 << FORMAT40_KEY_LARGE) : 0;
@@ -503,6 +511,7 @@ reiser4_format_plug_t format40_plug = {
 	.oid_area       = format40_oid_area,
 	.journal_pid	= format40_journal_pid,
 	.alloc_pid	= format40_alloc_pid,
+	.node_pid       = format40_node_pid,
 	.backup		= format40_backup,
 	.check_backup	= format40_check_backup,
 	.regenerate     = format40_regenerate,
plugin/format/format40/format40.h +16 -2
@@ -43,8 +43,8 @@ typedef struct format40_super {
 	d64_t sb_flags;
 	
 	d32_t sb_version;
-	
-	char sb_unused[428];
+	d32_t node_pid;
+	char sb_unused[424];
 } __attribute__((packed)) format40_super_t;
 
 typedef struct format40 {
@@ -101,6 +101,9 @@ extern reiser4_core_t *format40_core;
 #define get_sb_flags(sb)		aal_get_le64(sb, sb_flags)
 #define set_sb_flags(sb, val)		aal_set_le64(sb, sb_flags, val)
 
+#define get_sb_node_pid(sb)		aal_get_le32(sb, node_pid)
+#define set_sb_node_pid(sb, val)	aal_set_le32(sb, node_pid, val)
+
 #define get_sb_version(sb)	\
 	(aal_get_le32(sb, sb_version) & ~FORMAT40_UPDATE_BACKUP)
 
@@ -123,3 +126,14 @@ extern rid_t format40_get_key(reiser4_fo
 #endif
 
 #endif
+
+/*
+   Local variables:
+   c-indentation-style: "K&R"
+   mode-name: "LC"
+   c-basic-offset: 8
+   tab-width: 8
+   fill-column: 80
+   scroll-step: 1
+   End:
+*/
#1 lore raw

hello!
can this r4progs patch be claimed ready-to-go? i.e. should i ask distro maintainer to update r4prgos package, or should we wait for a new upstream version (1.10)?

#2 lore raw

Hello,

This stuff is incomplete. This is only intermediate results for testing. For the full picture reiser4 kernel module should update/check the checksums, and fsck should check the checksums and repair the tree, if something is wrong.

The program-maximum, however, is failover (mirroring / scrubbing) based on the checksums.

Thanks,
Edward.

Quoted 8 lines · dimas

hello!
can this r4progs patch be claimed ready-to-go? i.e. should i ask distro maintainer to update r4prgos package, or should we wait for a new upstream version (1.10)?
--
To unsubscribe from this list: send the line "unsubscribe reiserfs-devel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

Niltze, all!

Running Debian Jessie/Sid on root Reiser4 for Linux kernel 3.18.6.

Quoted 10 lines · Edward Shishkin

Hello,

This stuff is incomplete. This is only intermediate results for testing. For the full picture reiser4 kernel module should update/check the checksums, and fsck should check the checksums and repair the tree, if something is wrong.

The program-maximum, however, is failover (mirroring / scrubbing) based on the checksums.

Quoted 12 lines

Thanks,
Edward.

Quoted 6 lines · dimas

hello!
can this r4progs patch be claimed ready-to-go? i.e. should i ask distro maintainer to update r4prgos package, or should we wait for a new upstream version (1.10)?
--

After applying patch to reiser4progs1.0.9, during build:

./configure (finishes appropriately)
make

(error)
[...]
/bin/bash ../../libtool --tag=CC --mode=link gcc -D_REENTRANT
-D_FILE_OFFSET_BITS=64 -DENABLE_SYMLINKS -DENABLE_SPECIAL -DENABLE_R5_HASH -DENABLE_FNV1_HASH -DENABLE_RUPASOV_HASH -DENABLE_TEA_HASH -DENABLE_DEG_HASH -DENABLE_LARGE_KEYS -DENABLE_SHORT_KEYS -DENABLE_DOT_O_FIBRE -DENABLE_EXT_1_FIBRE -DENABLE_EXT_3_FIBRE -DENABLE_LEXIC_FIBRE -O3 -W -Wall -Wuninitialized
-Wno-unused-parameter -Wredundant-decls -o mkfs.reiser4
mkfs_reiser4-mkfs.o ../../libreiser4/libreiser4.la ../../libmisc/libmisc.la -lreadline -lncurses
libtool: link: gcc -D_REENTRANT -D_FILE_OFFSET_BITS=64 -DENABLE_SYMLINKS -DENABLE_SPECIAL -DENABLE_R5_HASH -DENABLE_FNV1_HASH -DENABLE_RUPASOV_HASH -DENABLE_TEA_HASH -DENABLE_DEG_HASH -DENABLE_LARGE_KEYS -DENABLE_SHORT_KEYS -DENABLE_DOT_O_FIBRE -DENABLE_EXT_1_FIBRE -DENABLE_EXT_3_FIBRE -DENABLE_LEXIC_FIBRE -O3 -W -Wall -Wuninitialized -Wno-unused-parameter -Wredundant-decls -o .libs/mkfs.reiser4 mkfs_reiser4-mkfs.o ../../libreiser4/.libs/libreiser4.so ../../libmisc/.libs/libmisc.a -laal -luuid -lreadline -lncurses ../../libreiser4/.libs/libreiser4.so: undefined reference to `node41_plug'
collect2: error: ld returned 1 exit status
make[3]: *** [mkfs.reiser4] Error 1
Makefile:387: recipe for target 'mkfs.reiser4' failed
make[3]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9/progs/mkfs'
make[2]: *** [all-recursive] Error 1
Makefile:345: recipe for target 'all-recursive' failed
make[2]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9/progs' make[1]: *** [all-recursive] Error 1
Makefile:453: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9'
make: *** [all] Error 2
Makefile:361: recipe for target 'all' failed

Best Professional Regards.

Signature · 7 lines
Jose R R
http://www.metztli-it.com
---------------------------------------------------------------------------------------------
Try at no charge http://b2evolution.net for http://OpenShift.com PaaS
---------------------------------------------------------------------------------------------
from our GitHub http://Nepohualtzintzin.com repository. Cloud the easy way!
---------------------------------------------------------------------------------------------
#4 lore raw
Quoted 22 lines · Jose R R

Niltze, all!

Running Debian Jessie/Sid on root Reiser4 for Linux kernel 3.18.6.

Quoted 15 lines · Edward Shishkin

Hello,

This stuff is incomplete. This is only intermediate results for testing. For the full picture reiser4 kernel module should update/check the checksums, and fsck should check the checksums and repair the tree, if something is wrong.

The program-maximum, however, is failover (mirroring / scrubbing) based on the checksums.

Thanks,
Edward.

Quoted 7 lines
Quoted 6 lines · dimas
Quoted 5 lines

hello!
can this r4progs patch be claimed ready-to-go? i.e. should i ask distro maintainer to update r4prgos package, or should we wait for a new upstream version (1.10)?
--

After applying patch to reiser4progs1.0.9, during build:

try autoreconf before ./configure

Quoted 41 lines

./configure (finishes appropriately)
make

(error)
[...]
/bin/bash ../../libtool --tag=CC --mode=link gcc -D_REENTRANT

(quoted diff) +0 -6
-D_FILE_OFFSET_BITS=64 -DENABLE_SYMLINKS -DENABLE_SPECIAL
-DENABLE_R5_HASH -DENABLE_FNV1_HASH -DENABLE_RUPASOV_HASH
-DENABLE_TEA_HASH -DENABLE_DEG_HASH -DENABLE_LARGE_KEYS
-DENABLE_SHORT_KEYS -DENABLE_DOT_O_FIBRE -DENABLE_EXT_1_FIBRE
-DENABLE_EXT_3_FIBRE -DENABLE_LEXIC_FIBRE -O3 -W -Wall -Wuninitialized
-Wno-unused-parameter -Wredundant-decls   -o mkfs.reiser4

mkfs_reiser4-mkfs.o ../../libreiser4/libreiser4.la ../../libmisc/libmisc.la -lreadline -lncurses
libtool: link: gcc -D_REENTRANT -D_FILE_OFFSET_BITS=64

(quoted diff) +0 -5
-DENABLE_SYMLINKS -DENABLE_SPECIAL -DENABLE_R5_HASH -DENABLE_FNV1_HASH
-DENABLE_RUPASOV_HASH -DENABLE_TEA_HASH -DENABLE_DEG_HASH
-DENABLE_LARGE_KEYS -DENABLE_SHORT_KEYS -DENABLE_DOT_O_FIBRE
-DENABLE_EXT_1_FIBRE -DENABLE_EXT_3_FIBRE -DENABLE_LEXIC_FIBRE -O3 -W
-Wall -Wuninitialized -Wno-unused-parameter -Wredundant-decls -o

.libs/mkfs.reiser4 mkfs_reiser4-mkfs.o ../../libreiser4/.libs/libreiser4.so ../../libmisc/.libs/libmisc.a -laal -luuid -lreadline -lncurses ../../libreiser4/.libs/libreiser4.so: undefined reference to `node41_plug'
collect2: error: ld returned 1 exit status
make[3]: *** [mkfs.reiser4] Error 1
Makefile:387: recipe for target 'mkfs.reiser4' failed
make[3]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9/progs/mkfs'
make[2]: *** [all-recursive] Error 1
Makefile:345: recipe for target 'all-recursive' failed
make[2]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9/progs' make[1]: *** [all-recursive] Error 1
Makefile:453: recipe for target 'all-recursive' failed
make[1]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9'
make: *** [all] Error 2
Makefile:361: recipe for target 'all' failed

Best Professional Regards.

#5 lore raw
Quoted 83 lines · Edward Shishkin
Quoted 81 lines · Jose R R

Niltze, all!

Running Debian Jessie/Sid on root Reiser4 for Linux kernel 3.18.6.

Quoted 11 lines · Edward Shishkin

Hello,

This stuff is incomplete. This is only intermediate results for testing. For the full picture reiser4 kernel module should update/check the checksums, and fsck should check the checksums and repair the tree, if something is wrong.

The program-maximum, however, is failover (mirroring / scrubbing) based on the checksums.

Quoted 13 lines

Thanks,
Edward.

Quoted 7 lines · dimas

hello!
can this r4progs patch be claimed ready-to-go? i.e. should i ask distro maintainer to update r4prgos package, or should we wait for a new upstream
version (1.10)?
--

After applying patch to reiser4progs1.0.9, during build:

./configure (finishes appropriately)
make

(error)
[...]
/bin/bash ../../libtool --tag=CC --mode=link gcc -D_REENTRANT

(quoted diff) +0 -6
-D_FILE_OFFSET_BITS=64 -DENABLE_SYMLINKS -DENABLE_SPECIAL
-DENABLE_R5_HASH -DENABLE_FNV1_HASH -DENABLE_RUPASOV_HASH
-DENABLE_TEA_HASH -DENABLE_DEG_HASH -DENABLE_LARGE_KEYS
-DENABLE_SHORT_KEYS -DENABLE_DOT_O_FIBRE -DENABLE_EXT_1_FIBRE
-DENABLE_EXT_3_FIBRE -DENABLE_LEXIC_FIBRE -O3 -W -Wall -Wuninitialized
-Wno-unused-parameter -Wredundant-decls   -o mkfs.reiser4

mkfs_reiser4-mkfs.o ../../libreiser4/libreiser4.la ../../libmisc/libmisc.la -lreadline -lncurses
libtool: link: gcc -D_REENTRANT -D_FILE_OFFSET_BITS=64

(quoted diff) +0 -5
-DENABLE_SYMLINKS -DENABLE_SPECIAL -DENABLE_R5_HASH -DENABLE_FNV1_HASH
-DENABLE_RUPASOV_HASH -DENABLE_TEA_HASH -DENABLE_DEG_HASH
-DENABLE_LARGE_KEYS -DENABLE_SHORT_KEYS -DENABLE_DOT_O_FIBRE
-DENABLE_EXT_1_FIBRE -DENABLE_EXT_3_FIBRE -DENABLE_LEXIC_FIBRE -O3 -W
-Wall -Wuninitialized -Wno-unused-parameter -Wredundant-decls -o

.libs/mkfs.reiser4 mkfs_reiser4-mkfs.o ../../libreiser4/.libs/libreiser4.so ../../libmisc/.libs/libmisc.a -laal -luuid -lreadline -lncurses ../../libreiser4/.libs/libreiser4.so: undefined reference to `node41_plug'
collect2: error: ld returned 1 exit status
make[3]: *** [mkfs.reiser4] Error 1
Makefile:387: recipe for target 'mkfs.reiser4' failed
make[3]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9/progs/mkfs' make[2]: *** [all-recursive] Error 1
Makefile:345: recipe for target 'all-recursive' failed make[2]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9/progs'
make[1]: *** [all-recursive] Error 1
Makefile:453: recipe for target 'all-recursive' failed make[1]: Leaving directory '/usr/src/build/reiser4/reiser4progs-1.0.9'
make: *** [all] Error 2
Makefile:361: recipe for target 'all' failed

Quoted 3 lines
Quoted 2 lines

Best Professional Regards.

"try autoreconf before ./configure"

Appreciated. It worked.

Best Professional Regards.

Signature · 7 lines
Jose R R
http://www.metztli-it.com
---------------------------------------------------------------------------------------------
Try at no charge http://b2evolution.net for http://OpenShift.com PaaS
---------------------------------------------------------------------------------------------
from our GitHub http://Nepohualtzintzin.com repository. Cloud the easy way!
---------------------------------------------------------------------------------------------