ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
PATCH 1/1 ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
ftrace_enable_ftrace_graph_caller and ftrace_disable_ftrace_graph_caller should replace B(jmp) instruction and not BL(call) instruction.
patch 9f1ae7596aad71d18c3e88a3927f3f76b037b8fe did a typo and used AARCH64_INSN_BRANCH_LINK instead of AARCH64_INSN_BRANCH_NOLINK.
--- arch/arm64/kernel/ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/kernel/ftrace.c +1 -1
@@ -156,7 +156,7 @@ static int ftrace_modify_graph_caller(bool enable) branch =aarch64_insn_gen_branch_imm (pc, (unsigned long )ftrace_graph_caller, -AARCH64_INSN_BRANCH_LINK ); +AARCH64_INSN_BRANCH_NOLINK ); nop =aarch64_insn_gen_nop ();if (enable)
Signature · 1 line
2.1.0
PATCH 1/1 ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
Hello.
Quoted 4 lines · Pratyush Anand
ftrace_enable_ftrace_graph_callerandftrace_disable_ftrace_graph_callershould replace B(jmp) instruction and not BL(call) instruction.patch
9f1ae7596aad71d18c3e88a3927f3f76b037b8fedid a typo and used
s/patch/commit/. And please specify that commit's summary line in parens.
Quoted 3 lines
AARCH64_INSN_BRANCH_LINKinstead ofAARCH64_INSN_BRANCH_NOLINK.Signed-off-by Pratyush Anand <[email protected]>
[...]
WBR, Sergei
PATCH 1/1 ARM64:ftrace: fix ftrace_modify_graph_caller for branch replace
Quoted 11 lines · Sergei Shtylyov
Hello.
Quoted 4 lines · Pratyush Anand
ftrace_enable_ftrace_graph_callerandftrace_disable_ftrace_graph_callershould replace B(jmp) instruction and not BL(call) instruction.patch
9f1ae7596aad71d18c3e88a3927f3f76b037b8fedid a typo and useds/patch/commit/. And please specify that commit's summary line in
parens.
Thanks for review, resend it with modified log.
~Pratyush
Quoted 9 lines
Quoted 4 lines
AARCH64_INSN_BRANCH_LINKinstead ofAARCH64_INSN_BRANCH_NOLINK.Signed-off-by Pratyush Anand <[email protected]>[...]
WBR, Sergei