MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
PATCH 1/1 MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
According to the MPC8555/MPC8541 reference manual the SS_EN (source synchronous enable) bit in the DDR_SDRAM_CLK_CNLT register must be set during initialization.
From section 9.4.1.8 of that manual:
Source synchronous enable. This bit field must be set during initialization. See Section 9.6.1, "DDR SDRAM Initialization Sequence," details.
0 - Reserved
1 - The address and command are sent to the DDR SDRAMs source
synchronously.
In addition, Freescale application note AN2805 is also very clear that this bit must be set.
This patch reverts a change introduced by commit457caecdbca3df21a93abff19eab12dbc61b7897.
Testing Done:
Compiled targets CONFIG_TARGET_MPC8555CDS and CONFIG_TARGET_MPC8541CDS and inspected the generated assembly code to verify the SS_EN bit was being set. There is one extra instruction emitted:
fff9b774: 65 29 80 00 oris r9,r9,32768
Compiled the CONFIG_TARGET_MPC8548CDS target and verified that no additional instructions were emitted related to this patch.
Booted an image on a MPC8541 based board successfully.
--- drivers/ddr/fsl/ctrl_regs.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/ddr/fsl/ctrl_regs.c +9 -1
@@ -1730,13 +1730,21 @@ static void set_ddr_data_init(fsl_ddr_cfg_regs_t *ddr)*/ static void set_ddr_sdram_clk_cntl (fsl_ddr_cfg_regs_t *ddr,const memctl_options_t *popts) {unsigned int clk_adjust;/* Clock adjust */ +unsigned int ss_en =0 ;/* Source synchronous enable */ +#if defined(CONFIG_MPC8541 ) || defined(CONFIG_MPC8555 ) +/* Per FSL Application Note: AN2805 */ + ss_en =1 ; +#endif clk_adjust = popts->clk_adjust; - ddr->ddr_sdram_clk_cntl = (clk_adjust &0xF ) <<23 ; + ddr->ddr_sdram_clk_cntl = (0 + | ((ss_en &0x1 ) <<31 ) + | ((clk_adjust &0xF ) <<23 ) + );debug ("FSLDDR: clk_cntl = 0x%08x\n" , ddr->ddr_sdram_clk_cntl); }/* DDR Initialization Address (DDR_INIT_ADDR) */ static void set_ddr_init_addr (fsl_ddr_cfg_regs_t *ddr)
Signature · 1 line
1.7.10.4
PATCH 1/1 MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
Quoted 28 lines · Curt Brune
According to the MPC8555/MPC8541 reference manual the
SS_EN(source synchronous enable) bit in theDDR_SDRAM_CLK_CNLTregister must be set during initialization.From section 9.4.1.8 of that manual:
Source synchronous enable. This bit field must be set during initialization. See Section 9.6.1, "DDR SDRAM Initialization Sequence," details.
0 - Reserved
1 - The address and command are sent to the DDR SDRAMs source
synchronously.In addition, Freescale application note AN2805 is also very clear that this bit must be set.
This patch reverts a change introduced by commit
457caecdbca3df21a93abff19eab12dbc61b7897.Testing Done:
Compiled targets
CONFIG_TARGET_MPC8555CDSandCONFIG_TARGET_MPC8541CDSand inspected the generated assembly code to verify theSS_ENbit was being set. There is one extra instruction emitted:
fff9b774: 65 29 80 00 oris r9,r9,32768
Quoted 7 lines
Compiled the
CONFIG_TARGET_MPC8548CDStarget and verified that no additional instructions were emitted related to this patch.Booted an image on a MPC8541 based board successfully.
Signed-off-by Curt Brune <[email protected]>---
Thanks for fixing this.
York
York Sun
AppliedPATCH 1/1 MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
In reply to Curt BruneQuoted 28 lines · Curt Brune
According to the MPC8555/MPC8541 reference manual the
SS_EN(source synchronous enable) bit in theDDR_SDRAM_CLK_CNLTregister must be set during initialization.From section 9.4.1.8 of that manual:
Source synchronous enable. This bit field must be set during initialization. See Section 9.6.1, "DDR SDRAM Initialization Sequence," details.
0 - Reserved
1 - The address and command are sent to the DDR SDRAMs source
synchronously.In addition, Freescale application note AN2805 is also very clear that this bit must be set.
This patch reverts a change introduced by commit
457caecdbca3df21a93abff19eab12dbc61b7897.Testing Done:
Compiled targets
CONFIG_TARGET_MPC8555CDSandCONFIG_TARGET_MPC8541CDSand inspected the generated assembly code to verify theSS_ENbit was being set. There is one extra instruction emitted:
fff9b774: 65 29 80 00 oris r9,r9,32768
Quoted 7 lines
Compiled the
CONFIG_TARGET_MPC8548CDStarget and verified that no additional instructions were emitted related to this patch.Booted an image on a MPC8541 based board successfully.
Signed-off-by Curt Brune <[email protected]>---
Applied to mpc85xx master, awaiting upstream.
York