Skip to contentSkip to conversation

TWL4030 charger

PATCH In review Nicolas JOURDEN 2 participants 3 messages Feb 21, 2015 – Feb 23, 2015

lore
Share & tools
lore

Nicolas JOURDEN

author
#0 lore raw

PATCH 1/1 TWL4030 charger

Hello,

This patch fix the TWL4030 charger module for the RTC battery.

Cheers,
Nicolas

Signed-off-by Nicolas JOURDEN <[email protected]>

---

drivers/power/twl4030_charger.c +2 -1
index 2598c58..89184ae 100644
@@ -719,10 +719,11 @@ static struct platform_driver twl4030_bci_driver = {
                .owner  = THIS_MODULE,
                .of_match_table = of_match_ptr(twl_bci_of_match),
        },
+       .probe  = twl4030_bci_probe,
        .remove = __exit_p(twl4030_bci_remove),
 };
 
-module_platform_driver_probe(twl4030_bci_driver, twl4030_bci_probe);
+module_platform_driver(twl4030_bci_driver);
 
 MODULE_AUTHOR("Gražvydas Ignotas");
 MODULE_DESCRIPTION("TWL4030 Battery Charger Interface driver");
author
#1 lore raw

Hello,

Looks like my mailer changed the format/indent for the patch. This patch fix the TWL4030 charger module for the RTC battery.

Signed-off-by Nicolas JOURDEN <[email protected]>

---

drivers/power/twl4030_charger.c +2 -1
index 2598c58..89184ae 100644
@@ -719,10 +719,11 @@ static struct platform_driver twl4030_bci_driver = {
 		.owner	= THIS_MODULE,
 		.of_match_table = of_match_ptr(twl_bci_of_match),
 	},
+	.probe  = twl4030_bci_probe,
 	.remove	= __exit_p(twl4030_bci_remove),
 };
 
-module_platform_driver_probe(twl4030_bci_driver, twl4030_bci_probe);
+module_platform_driver(twl4030_bci_driver);
 
 MODULE_AUTHOR("Gražvydas Ignotas");
 MODULE_DESCRIPTION("TWL4030 Battery Charger Interface driver");
#2 lore raw

2015-02-22 12:50 GMT+01:00 Nicolas JOURDEN <[email protected]>:

Quoted 5 lines

Hello,

Looks like my mailer changed the format/indent for the patch. This patch fix the TWL4030 charger module for the RTC battery.

Could you put a proper title for this patch describing in few words what is fixed? Additionally could you describe the exact fix details in commit message. For example these details could be useful:
1. What is the problem,
2. When the problem appears (or how the problem can be reproduced).
3. What is the "fix".

I am asking for these details to better understand the error you found and the fix for it.

Best regards,
Krzysztof

Quoted 20 lines
Signed-off-by Nicolas JOURDEN <[email protected]>

---

drivers/power/twl4030_charger.c +2 -1
index 2598c58..89184ae 100644
@@ -719,10 +719,11 @@ static struct platform_driver twl4030_bci_driver = {
                .owner  = THIS_MODULE,
                .of_match_table = of_match_ptr(twl_bci_of_match),
        },
+       .probe  = twl4030_bci_probe,
        .remove = __exit_p(twl4030_bci_remove),
 };
 
-module_platform_driver_probe(twl4030_bci_driver, twl4030_bci_probe);
+module_platform_driver(twl4030_bci_driver);
 
 MODULE_AUTHOR("Gražvydas Ignotas");
 MODULE_DESCRIPTION("TWL4030 Battery Charger Interface driver");