Staging: rtl8188eu: Remove unused variable
PATCH v2 1/1 Staging: rtl8188eu: Remove unused variable
We only need the last 8 bits of the offset variable so we can directly operate on it instead of introducing unneeded newoffset variable.
---
Changes in v2: Changed commit message to make it more descriptive.
drivers/staging/rtl8188eu/hal/phy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/staging/rtl8188eu/hal/phy.c +2 -3
@@ -117,10 +117,9 @@ static void rf_serial_write(struct adapter *adapt,u32 data_and_addr =0 ;struct hal_data_8188e *hal_data =GET_HAL_DATA (adapt);struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath]; -u32 newoffset; - newoffset = offset &0xff ; - data_and_addr = ((newoffset<<20 ) | (data&0x000fffff )) &0x0fffffff ; + offset &=0xff ; + data_and_addr = ((offset<<20 ) | (data&0x000fffff )) &0x0fffffff ;phy_set_bb_reg (adapt, phyreg->rf3wireOffset, bMaskDWord, data_and_addr); }
Signature · 1 line
1.9.1
Quoted 5 lines · Vatika Harlalka
We only need the last 8 bits of the offset variable so we can directly operate on it instead of introducing unneeded newoffset variable.
Signed-off-by Vatika Harlalka <[email protected]>
Quoted 16 lines · Vatika Harlalka
We only need the last 8 bits of the offset variable so we can directly operate on it instead of introducing unneeded newoffset variable.
Signed-off-by Vatika Harlalka <[email protected]>---
Changes in v2: Changed commit message to make it more descriptive.drivers/staging/rtl8188eu/hal/phy.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)drivers/staging/rtl8188eu/hal/phy.c +0
-0
drivers/staging/rtl8188eu/hal/phy.c static void rf_serial_write(struct adapter *adapt, · line 122
Quoted 9 lines
drivers/staging/rtl8188eu/hal/phy.c +2
-3@@ -117,10 +117,9 @@ static void rf_serial_write(struct adapter *adapt,u32 data_and_addr =0 ;struct hal_data_8188e *hal_data =GET_HAL_DATA (adapt);struct bb_reg_def *phyreg = &hal_data->PHYRegDef[rfpath]; -u32 newoffset; - newoffset = offset &0xff ; - data_and_addr = ((newoffset<<20 ) | (data&0x000fffff )) &0x0fffffff ; + offset &=0xff ; + data_and_addr = ((offset<<20 ) | (data&0x000fffff )) &0x0fffffff ;
Fix is good, but you need to comply with the space rules as well when you do this. It should say:
data_and_addr = ((offset << 20) | (data & 0x000fffff)) & 0x0fffffff;
Cheers,
Jes
Quoted 4 lines
drivers/staging/rtl8188eu/hal/phy.c +0
-0phy_set_bb_reg (adapt, phyreg->rf3wireOffset, bMaskDWord, data_and_addr); }